Mirrors/blakeblackshear.frigate
1
0
Fork 0
mirror of https://github.com/blakeblackshear/frigate.git synced 2024-11-21 19:07:46 +01:00
Code Issues Projects Releases Wiki Activity

handle onvif connection failure in autotrack init (#8838)

Browse Source 
* handle onvif connection failure in autotrack init

* remove whitespace and add consistency

* error message consistency

* more consistency
This commit is contained in:
Josh Hawkins 2023-12-02 21:14:52 -06:00 committed by GitHub
parent f27025aef3
commit cc5297f180
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
frigate/ptz/autotrack.py
View File

@ -238,32 +238,40 @@ class PtzAutoTracker:
self.move_queues[camera] = queue.Queue() self.move_queues[camera] = queue.Queue()
self.move_queue_locks[camera] = threading.Lock() self.move_queue_locks[camera] = threading.Lock()
if not self.onvif.cams[camera]["init"]: # handle onvif constructor failing due to no connection
if not self.onvif._init_onvif(camera): if camera not in self.onvif.cams:
logger.warning(f"Unable to initialize onvif for {camera}") logger.warning(
f"Disabling autotracking for {camera}: onvif connection failed"
)
camera_config.onvif.autotracking.enabled = False camera_config.onvif.autotracking.enabled = False
self.ptz_metrics[camera]["ptz_autotracker_enabled"].value = False self.ptz_metrics[camera]["ptz_autotracker_enabled"].value = False
return
if not self.onvif.cams[camera]["init"]:
if not self.onvif._init_onvif(camera):
logger.warning(
f"Disabling autotracking for {camera}: Unable to initialize onvif"
)
camera_config.onvif.autotracking.enabled = False
self.ptz_metrics[camera]["ptz_autotracker_enabled"].value = False
return return
if "pt-r-fov" not in self.onvif.cams[camera]["features"]: if "pt-r-fov" not in self.onvif.cams[camera]["features"]:
camera_config.onvif.autotracking.enabled = False
self.ptz_metrics[camera]["ptz_autotracker_enabled"].value = False
logger.warning( logger.warning(
f"Disabling autotracking for {camera}: FOV relative movement not supported" f"Disabling autotracking for {camera}: FOV relative movement not supported"
) )
camera_config.onvif.autotracking.enabled = False
self.ptz_metrics[camera]["ptz_autotracker_enabled"].value = False
return return
movestatus_supported = self.onvif.get_service_capabilities(camera) movestatus_supported = self.onvif.get_service_capabilities(camera)
if movestatus_supported is None or movestatus_supported.lower() != "true": if movestatus_supported is None or movestatus_supported.lower() != "true":
camera_config.onvif.autotracking.enabled = False
self.ptz_metrics[camera]["ptz_autotracker_enabled"].value = False
logger.warning( logger.warning(
f"Disabling autotracking for {camera}: ONVIF MoveStatus not supported" f"Disabling autotracking for {camera}: ONVIF MoveStatus not supported"
) )
camera_config.onvif.autotracking.enabled = False
self.ptz_metrics[camera]["ptz_autotracker_enabled"].value = False
return return
if self.onvif.cams[camera]["init"]: if self.onvif.cams[camera]["init"]: