Mirrors/blakeblackshear.frigate
1
0
Fork 0
mirror of https://github.com/blakeblackshear/frigate.git synced 2024-11-21 19:07:46 +01:00
Code Issues Projects Releases Wiki Activity

Fix recording events intermittently missing (#8162)

Browse Source 
* fix queues not emptying fully by changing gets to a blocking call with short timeout

* add extra error/warning messages when there's a possibility of missing recording segments
This commit is contained in:
winstona 2023-10-18 04:52:48 -07:00 committed by GitHub
parent 126aed2798
commit cd35481e92
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 32 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
frigate/record/maintainer.py
View File

@ -410,7 +410,8 @@ class RecordingMaintainer(threading.Thread):
wait_time = 0.0 wait_time = 0.0
while not self.stop_event.wait(wait_time): while not self.stop_event.wait(wait_time):
run_start = datetime.datetime.now().timestamp() run_start = datetime.datetime.now().timestamp()
stale_frame_count = 0
stale_frame_count_threshold = 10
# empty the object recordings info queue # empty the object recordings info queue
while True: while True:
try: try:
@ -420,7 +421,10 @@ class RecordingMaintainer(threading.Thread):
current_tracked_objects, current_tracked_objects,
motion_boxes, motion_boxes,
regions, regions,
) = self.object_recordings_info_queue.get(False) ) = self.object_recordings_info_queue.get(True, timeout=0.1)
if frame_time < run_start - stale_frame_count_threshold:
stale_frame_count += 1
if self.process_info[camera]["record_enabled"].value: if self.process_info[camera]["record_enabled"].value:
self.object_recordings_info[camera].append( self.object_recordings_info[camera].append(
@ -432,17 +436,32 @@ class RecordingMaintainer(threading.Thread):
) )
) )
except queue.Empty: except queue.Empty:
q_size = self.object_recordings_info_queue.qsize()
if q_size > 5:
logger.warning(
f"object_recordings_info loop queue not empty ({q_size}) - recording segments may be missing"
)
break break
if stale_frame_count > 0:
logger.error(
f"Found {stale_frame_count} old frames, segments from recordings may be missing"
)
# empty the audio recordings info queue if audio is enabled # empty the audio recordings info queue if audio is enabled
if self.audio_recordings_info_queue: if self.audio_recordings_info_queue:
stale_frame_count = 0
while True: while True:
try: try:
( (
camera, camera,
frame_time, frame_time,
dBFS, dBFS,
) = self.audio_recordings_info_queue.get(False) ) = self.audio_recordings_info_queue.get(True, timeout=0.1)
if frame_time < run_start - stale_frame_count_threshold:
stale_frame_count += 1
if self.process_info[camera]["record_enabled"].value: if self.process_info[camera]["record_enabled"].value:
self.audio_recordings_info[camera].append( self.audio_recordings_info[camera].append(
@ -452,8 +471,18 @@ class RecordingMaintainer(threading.Thread):
) )
) )
except queue.Empty: except queue.Empty:
q_size = self.audio_recordings_info_queue.qsize()
if q_size > 5:
logger.warning(
f"object_recordings_info loop audio queue not empty ({q_size}) - recording segments may be missing"
)
break break
if stale_frame_count > 0:
logger.error(
f"Found {stale_frame_count} old audio frames, segments from recordings may be missing"
)
try: try:
asyncio.run(self.move_files()) asyncio.run(self.move_files())
except Exception as e: except Exception as e: