From d558ac83b6ffb92a780daf5bd97ac2b421e2f61e Mon Sep 17 00:00:00 2001
From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com>
Date: Tue, 8 Oct 2024 08:01:31 -0500
Subject: [PATCH] Search fixes (#14217)

* Ensure semantic search is enabled before checking model download state

* Only clear similarity search when removing similarity pill
---
 web/src/components/input/InputWithTags.tsx |  7 ++++++-
 web/src/pages/Explore.tsx                  | 11 ++++++-----
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/web/src/components/input/InputWithTags.tsx b/web/src/components/input/InputWithTags.tsx
index 3e40b36c8..6c06e67e7 100644
--- a/web/src/components/input/InputWithTags.tsx
+++ b/web/src/components/input/InputWithTags.tsx
@@ -397,6 +397,11 @@ export default function InputWithTags({
     setIsSimilaritySearch(false);
   }, [setFilters, resetSuggestions, setSearch, setInputFocused]);
 
+  const handleClearSimilarity = useCallback(() => {
+    removeFilter("event_id", filters.event_id!);
+    removeFilter("search_type", "similarity");
+  }, [removeFilter, filters]);
+
   const handleInputBlur = useCallback(
     (e: React.FocusEvent) => {
       if (
@@ -638,7 +643,7 @@ export default function InputWithTags({
                   <span className="inline-flex items-center whitespace-nowrap rounded-full bg-blue-100 px-2 py-0.5 text-sm text-blue-800">
                     Similarity Search
                     <button
-                      onClick={handleClearInput}
+                      onClick={handleClearSimilarity}
                       className="ml-1 focus:outline-none"
                       aria-label="Clear similarity search"
                     >
diff --git a/web/src/pages/Explore.tsx b/web/src/pages/Explore.tsx
index 7fc0f9286..2bed37ac1 100644
--- a/web/src/pages/Explore.tsx
+++ b/web/src/pages/Explore.tsx
@@ -225,10 +225,11 @@ export default function Explore() {
   };
 
   if (
-    !minilmModelState ||
-    !minilmTokenizerState ||
-    !clipImageModelState ||
-    !clipTextModelState
+    config?.semantic_search.enabled &&
+    (!minilmModelState ||
+      !minilmTokenizerState ||
+      !clipImageModelState ||
+      !clipTextModelState)
   ) {
     return (
       <ActivityIndicator className="absolute left-1/2 top-1/2 -translate-x-1/2 -translate-y-1/2" />
@@ -237,7 +238,7 @@ export default function Explore() {
 
   return (
     <>
-      {!allModelsLoaded ? (
+      {config?.semantic_search.enabled && !allModelsLoaded ? (
         <div className="absolute inset-0 left-1/2 top-1/2 flex h-96 w-96 -translate-x-1/2 -translate-y-1/2">
           <div className="flex flex-col items-center justify-center space-y-3 rounded-lg bg-background/50 p-5">
             <div className="my-5 flex flex-col items-center gap-2 text-xl">