From dc2e8f7f70248199e350e952f48ed2413177af43 Mon Sep 17 00:00:00 2001
From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com>
Date: Sat, 10 Feb 2024 13:41:24 -0600
Subject: [PATCH] Onvif: skip non-video profiles in setup (#9708)

* use first h264 onvif profile

* error if profile remains unset

* move create_ptz_service call

* add profile logger debug
---
 frigate/ptz/onvif.py | 46 ++++++++++++++++++++++++++++++++++++++------
 1 file changed, 40 insertions(+), 6 deletions(-)

diff --git a/frigate/ptz/onvif.py b/frigate/ptz/onvif.py
index 8aae216f1..a7a2cd68b 100644
--- a/frigate/ptz/onvif.py
+++ b/frigate/ptz/onvif.py
@@ -67,22 +67,56 @@ class OnvifController:
 
         # create init services
         media = onvif.create_media_service()
+        logger.debug(f"Onvif media xaddr for {camera_name}: {media.xaddr}")
 
         try:
             # this will fire an exception if camera is not a ptz
             capabilities = onvif.get_definition("ptz")
             logger.debug(f"Onvif capabilities for {camera_name}: {capabilities}")
-            profile = media.GetProfiles()[0]
         except (ONVIFError, Fault, TransportError) as e:
-            logger.error(f"Unable to connect to camera: {camera_name}: {e}")
+            logger.error(
+                f"Unable to get Onvif capabilities for camera: {camera_name}: {e}"
+            )
+            return False
+
+        try:
+            profiles = media.GetProfiles()
+        except (ONVIFError, Fault, TransportError) as e:
+            logger.error(
+                f"Unable to get Onvif media profiles for camera: {camera_name}: {e}"
+            )
+            return False
+
+        profile = None
+        for key, onvif_profile in enumerate(profiles):
+            if (
+                onvif_profile.VideoEncoderConfiguration
+                and onvif_profile.VideoEncoderConfiguration.Encoding == "H264"
+            ):
+                profile = onvif_profile
+                logger.debug(f"Selected Onvif profile for {camera_name}: {profile}")
+                break
+
+        if profile is None:
+            logger.error(
+                f"No appropriate Onvif profiles found for camera: {camera_name}."
+            )
+            return False
+
+        # get the PTZ config for the profile
+        try:
+            configs = profile.PTZConfiguration
+            logger.debug(
+                f"Onvif ptz config for media profile in {camera_name}: {configs}"
+            )
+        except Exception as e:
+            logger.error(
+                f"Invalid Onvif PTZ configuration for camera: {camera_name}: {e}"
+            )
             return False
 
         ptz = onvif.create_ptz_service()
 
-        # get the PTZ config for the first onvif profile
-        configs = profile.PTZConfiguration
-        logger.debug(f"Onvif ptz config for media profile in {camera_name}: {configs}")
-
         request = ptz.create_type("GetConfigurationOptions")
         request.ConfigurationToken = profile.PTZConfiguration.token
         ptz_config = ptz.GetConfigurationOptions(request)