From ea364aced322b3a7a8cc30877f140beccddb6872 Mon Sep 17 00:00:00 2001 From: Rui Alves Date: Sun, 12 Jan 2025 16:06:35 +0000 Subject: [PATCH] Continued unit tests for GET /review/event/{event_id} Endpoint --- frigate/test/http_api/base_http_test.py | 5 +++-- frigate/test/http_api/test_http_review.py | 16 +++++++++------- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/frigate/test/http_api/base_http_test.py b/frigate/test/http_api/base_http_test.py index 7ce4b9482..a901fa3ee 100644 --- a/frigate/test/http_api/base_http_test.py +++ b/frigate/test/http_api/base_http_test.py @@ -124,7 +124,8 @@ class BaseTestHttp(unittest.TestCase): def insert_mock_event( self, id: str, - start_time: datetime.datetime = datetime.datetime.now().timestamp(), + start_time: float = datetime.datetime.now().timestamp(), + end_time: float = datetime.datetime.now().timestamp() + 20, ) -> Event: """Inserts a basic event model with a given id.""" return Event.insert( @@ -132,7 +133,7 @@ class BaseTestHttp(unittest.TestCase): label="Mock", camera="front_door", start_time=start_time, - end_time=start_time + 20, + end_time=end_time, top_score=100, false_positive=False, zones=list(), diff --git a/frigate/test/http_api/test_http_review.py b/frigate/test/http_api/test_http_review.py index 58c0fd671..f52d7aefc 100644 --- a/frigate/test/http_api/test_http_review.py +++ b/frigate/test/http_api/test_http_review.py @@ -682,7 +682,7 @@ class TestHttpReview(BaseTestHttp): response_json, ) - def test_review_event_specific_not_found_in_data(self): + def test_review_event_not_found_in_data(self): now = datetime.now().timestamp() with TestClient(self.app) as client: @@ -696,27 +696,29 @@ class TestHttpReview(BaseTestHttp): response_json, ) - def test_review_event_specific(self): + def test_review_get_specific_event(self): now = datetime.now().timestamp() with TestClient(self.app) as client: - id = "123456.random" + event_id = "123456.event.random" + super().insert_mock_event(event_id) + review_id = "123456.review.random" super().insert_mock_review_segment( - id, now + 1, now + 2, data={"detections": {"event_id": id}} + review_id, now + 1, now + 2, data={"detections": {"event_id": event_id}} ) - response = client.get(f"/review/event/{id}") + response = client.get(f"/review/event/{event_id}") assert response.status_code == 200 response_json = response.json() self.assertDictEqual( { - "id": id, + "id": review_id, "camera": "front_door", "start_time": now + 1, "end_time": now + 2, "has_been_reviewed": False, "severity": SeverityEnum.alert, "thumb_path": 'False', - "data": {"detections": {"event_id": id}}, + "data": {"detections": {"event_id": event_id}}, }, response_json, )