mirror of
				https://github.com/juanfont/headscale.git
				synced 2025-10-28 10:51:44 +01:00 
			
		
		
		
	move populate to after when given_name exist
This commit is contained in:
		
							parent
							
								
									77ceeaf5fd
								
							
						
					
					
						commit
						5fa987519d
					
				
							
								
								
									
										65
									
								
								db.go
									
									
									
									
									
								
							
							
						
						
									
										65
									
								
								db.go
									
									
									
									
									
								
							| @ -45,38 +45,6 @@ func (h *Headscale) initDB() error { | ||||
| 	// the field is populated and normalized if it was not when the
 | ||||
| 	// machine was registered.
 | ||||
| 	_ = db.Migrator().RenameColumn(&Machine{}, "nickname", "given_name") | ||||
| 	if db.Migrator().HasColumn(&Machine{}, "given_name") { | ||||
| 		machines := Machines{} | ||||
| 		if err := h.db.Find(&machines).Error; err != nil { | ||||
| 			log.Error().Err(err).Msg("Error accessing db") | ||||
| 		} | ||||
| 
 | ||||
| 		for _, machine := range machines { | ||||
| 			if machine.GivenName == "" { | ||||
| 				normalizedHostname, err := NormalizeToFQDNRules( | ||||
| 					machine.Hostname, | ||||
| 					h.cfg.OIDC.StripEmaildomain, | ||||
| 				) | ||||
| 				if err != nil { | ||||
| 					log.Error(). | ||||
| 						Caller(). | ||||
| 						Str("hostname", machine.Hostname). | ||||
| 						Err(err). | ||||
| 						Msg("Failed to normalize machine hostname in DB migration") | ||||
| 				} | ||||
| 
 | ||||
| 				err = h.RenameMachine(&machine, normalizedHostname) | ||||
| 				if err != nil { | ||||
| 					log.Error(). | ||||
| 						Caller(). | ||||
| 						Str("hostname", machine.Hostname). | ||||
| 						Err(err). | ||||
| 						Msg("Failed to save normalized machine name in DB migration") | ||||
| 				} | ||||
| 
 | ||||
| 			} | ||||
| 		} | ||||
| 	} | ||||
| 
 | ||||
| 	// If the Machine table has a column for registered,
 | ||||
| 	// find all occourences of "false" and drop them. Then
 | ||||
| @ -115,6 +83,39 @@ func (h *Headscale) initDB() error { | ||||
| 		return err | ||||
| 	} | ||||
| 
 | ||||
| 	if db.Migrator().HasColumn(&Machine{}, "given_name") { | ||||
| 		machines := Machines{} | ||||
| 		if err := h.db.Find(&machines).Error; err != nil { | ||||
| 			log.Error().Err(err).Msg("Error accessing db") | ||||
| 		} | ||||
| 
 | ||||
| 		for _, machine := range machines { | ||||
| 			if machine.GivenName == "" { | ||||
| 				normalizedHostname, err := NormalizeToFQDNRules( | ||||
| 					machine.Hostname, | ||||
| 					h.cfg.OIDC.StripEmaildomain, | ||||
| 				) | ||||
| 				if err != nil { | ||||
| 					log.Error(). | ||||
| 						Caller(). | ||||
| 						Str("hostname", machine.Hostname). | ||||
| 						Err(err). | ||||
| 						Msg("Failed to normalize machine hostname in DB migration") | ||||
| 				} | ||||
| 
 | ||||
| 				err = h.RenameMachine(&machine, normalizedHostname) | ||||
| 				if err != nil { | ||||
| 					log.Error(). | ||||
| 						Caller(). | ||||
| 						Str("hostname", machine.Hostname). | ||||
| 						Err(err). | ||||
| 						Msg("Failed to save normalized machine name in DB migration") | ||||
| 				} | ||||
| 
 | ||||
| 			} | ||||
| 		} | ||||
| 	} | ||||
| 
 | ||||
| 	err = db.AutoMigrate(&KV{}) | ||||
| 	if err != nil { | ||||
| 		return err | ||||
|  | ||||
		Loading…
	
		Reference in New Issue
	
	Block a user