diff --git a/hscontrol/grpcv1.go b/hscontrol/grpcv1.go index b216e5e6..75156a1b 100644 --- a/hscontrol/grpcv1.go +++ b/hscontrol/grpcv1.go @@ -29,6 +29,7 @@ import ( "github.com/juanfont/headscale/hscontrol/state" "github.com/juanfont/headscale/hscontrol/types" "github.com/juanfont/headscale/hscontrol/util" + "github.com/juanfont/headscale/hscontrol/util/zlog/zf" ) type headscaleV1APIServer struct { // v1.HeadscaleServiceServer @@ -241,10 +242,10 @@ func (api headscaleV1APIServer) RegisterNode( log.Trace(). Caller(). - Str("user", request.GetUser()). - Str("registration_id", request.GetKey()). - Str("registration_key", registrationKey). - Msg("Registering node") + Str(zf.UserName, request.GetUser()). + Str(zf.RegistrationID, request.GetKey()). + Str(zf.RegistrationKey, registrationKey). + Msg("registering node") registrationId, err := types.RegistrationIDFromString(request.GetKey()) if err != nil { @@ -264,17 +265,16 @@ func (api headscaleV1APIServer) RegisterNode( ) if err != nil { log.Error(). - Str("registration_key", registrationKey). + Str(zf.RegistrationKey, registrationKey). Err(err). - Msg("Failed to register node") + Msg("failed to register node") return nil, err } log.Info(). - Str("registration_key", registrationKey). - Str("node_id", fmt.Sprintf("%d", node.ID())). - Str("hostname", node.Hostname()). - Msg("Node registered successfully") + Str(zf.RegistrationKey, registrationKey). + EmbedObject(node). + Msg("node registered successfully") // This is a bit of a back and forth, but we have a bit of a chicken and egg // dependency here. @@ -355,9 +355,9 @@ func (api headscaleV1APIServer) SetTags( log.Trace(). Caller(). - Str("node", node.Hostname()). + EmbedObject(node). Strs("tags", request.GetTags()). - Msg("Changing tags of node") + Msg("changing tags of node") return &v1.SetTagsResponse{Node: node.Proto()}, nil } @@ -368,7 +368,7 @@ func (api headscaleV1APIServer) SetApprovedRoutes( ) (*v1.SetApprovedRoutesResponse, error) { log.Debug(). Caller(). - Uint64("node.id", request.GetNodeId()). + Uint64(zf.NodeID, request.GetNodeId()). Strs("requestedRoutes", request.GetRoutes()). Msg("gRPC SetApprovedRoutes called") @@ -466,8 +466,8 @@ func (api headscaleV1APIServer) ExpireNode( log.Trace(). Caller(). - Str("node", node.Hostname()). - Time("expiry", *node.AsStruct().Expiry). + EmbedObject(node). + Time(zf.ExpiresAt, *node.AsStruct().Expiry). Msg("node expired") return &v1.ExpireNodeResponse{Node: node.Proto()}, nil @@ -487,8 +487,8 @@ func (api headscaleV1APIServer) RenameNode( log.Trace(). Caller(). - Str("node", node.Hostname()). - Str("new_name", request.GetNewName()). + EmbedObject(node). + Str(zf.NewName, request.GetNewName()). Msg("node renamed") return &v1.RenameNodeResponse{Node: node.Proto()}, nil