mirror of
https://github.com/juanfont/headscale.git
synced 2025-12-09 20:04:54 +01:00
22ee2bfc9c
This PR investigates, adds tests and aims to correctly implement Tailscale's model for how Tags should be accepted, assigned and used to identify nodes in the Tailscale access and ownership model. When evaluating in Headscale's policy, Tags are now only checked against a nodes "tags" list, which defines the source of truth for all tags for a given node. This simplifies the code for dealing with tags greatly, and should help us have less access bugs related to nodes belonging to tags or users. A node can either be owned by a user, or a tag. Next, to ensure the tags list on the node is correctly implemented, we first add tests for every registration scenario and combination of user, pre auth key and pre auth key with tags with the same registration expectation as observed by trying them all with the Tailscale control server. This should ensure that we implement the correct behaviour and that it does not change or break over time. Lastly, the missing parts of the auth has been added, or changed in the cases where it was wrong. This has in large parts allowed us to delete and simplify a lot of code. Now, tags can only be changed when a node authenticates or if set via the CLI/API. Tags can only be fully overwritten/replaced and any use of either auth or CLI will replace the current set if different. A user owned device can be converted to a tagged device, but it cannot be changed back. A tagged device can never remove the last tag either, it has to have a minimum of one.
126 lines
3.1 KiB
Go
126 lines
3.1 KiB
Go
package mapper
|
|
|
|
import (
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/juanfont/headscale/hscontrol/types"
|
|
"tailscale.com/net/tsaddr"
|
|
"tailscale.com/tailcfg"
|
|
"tailscale.com/types/views"
|
|
)
|
|
|
|
func tailNodes(
|
|
nodes views.Slice[types.NodeView],
|
|
capVer tailcfg.CapabilityVersion,
|
|
primaryRouteFunc routeFilterFunc,
|
|
cfg *types.Config,
|
|
) ([]*tailcfg.Node, error) {
|
|
tNodes := make([]*tailcfg.Node, 0, nodes.Len())
|
|
|
|
for _, node := range nodes.All() {
|
|
tNode, err := tailNode(
|
|
node,
|
|
capVer,
|
|
primaryRouteFunc,
|
|
cfg,
|
|
)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
tNodes = append(tNodes, tNode)
|
|
}
|
|
|
|
return tNodes, nil
|
|
}
|
|
|
|
// tailNode converts a Node into a Tailscale Node.
|
|
func tailNode(
|
|
node types.NodeView,
|
|
capVer tailcfg.CapabilityVersion,
|
|
primaryRouteFunc routeFilterFunc,
|
|
cfg *types.Config,
|
|
) (*tailcfg.Node, error) {
|
|
addrs := node.Prefixes()
|
|
|
|
var derp int
|
|
|
|
// TODO(kradalby): legacyDERP was removed in tailscale/tailscale@2fc4455e6dd9ab7f879d4e2f7cffc2be81f14077
|
|
// and should be removed after 111 is the minimum capver.
|
|
var legacyDERP string
|
|
if node.Hostinfo().Valid() && node.Hostinfo().NetInfo().Valid() {
|
|
legacyDERP = fmt.Sprintf("127.3.3.40:%d", node.Hostinfo().NetInfo().PreferredDERP())
|
|
derp = node.Hostinfo().NetInfo().PreferredDERP()
|
|
} else {
|
|
legacyDERP = "127.3.3.40:0" // Zero means disconnected or unknown.
|
|
}
|
|
|
|
var keyExpiry time.Time
|
|
if node.Expiry().Valid() {
|
|
keyExpiry = node.Expiry().Get()
|
|
} else {
|
|
keyExpiry = time.Time{}
|
|
}
|
|
|
|
hostname, err := node.GetFQDN(cfg.BaseDomain)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
routes := primaryRouteFunc(node.ID())
|
|
allowed := append(addrs, routes...)
|
|
allowed = append(allowed, node.ExitRoutes()...)
|
|
tsaddr.SortPrefixes(allowed)
|
|
|
|
tNode := tailcfg.Node{
|
|
ID: tailcfg.NodeID(node.ID()), // this is the actual ID
|
|
StableID: node.ID().StableID(),
|
|
Name: hostname,
|
|
Cap: capVer,
|
|
|
|
User: node.TailscaleUserID(),
|
|
|
|
Key: node.NodeKey(),
|
|
KeyExpiry: keyExpiry.UTC(),
|
|
|
|
Machine: node.MachineKey(),
|
|
DiscoKey: node.DiscoKey(),
|
|
Addresses: addrs,
|
|
PrimaryRoutes: routes,
|
|
AllowedIPs: allowed,
|
|
Endpoints: node.Endpoints().AsSlice(),
|
|
HomeDERP: derp,
|
|
LegacyDERPString: legacyDERP,
|
|
Hostinfo: node.Hostinfo(),
|
|
Created: node.CreatedAt().UTC(),
|
|
|
|
Online: node.IsOnline().Clone(),
|
|
|
|
Tags: node.Tags().AsSlice(),
|
|
|
|
MachineAuthorized: !node.IsExpired(),
|
|
Expired: node.IsExpired(),
|
|
}
|
|
|
|
tNode.CapMap = tailcfg.NodeCapMap{
|
|
tailcfg.CapabilityFileSharing: []tailcfg.RawMessage{},
|
|
tailcfg.CapabilityAdmin: []tailcfg.RawMessage{},
|
|
tailcfg.CapabilitySSH: []tailcfg.RawMessage{},
|
|
}
|
|
|
|
if cfg.RandomizeClientPort {
|
|
tNode.CapMap[tailcfg.NodeAttrRandomizeClientPort] = []tailcfg.RawMessage{}
|
|
}
|
|
|
|
// Set LastSeen only for offline nodes to avoid confusing Tailscale clients
|
|
// during rapid reconnection cycles. Online nodes should not have LastSeen set
|
|
// as this can make clients interpret them as "not online" despite Online=true.
|
|
if node.LastSeen().Valid() && node.IsOnline().Valid() && !node.IsOnline().Get() {
|
|
lastSeen := node.LastSeen().Get()
|
|
tNode.LastSeen = &lastSeen
|
|
}
|
|
|
|
return &tNode, nil
|
|
}
|