mirror of
				https://github.com/juanfont/headscale.git
				synced 2025-10-28 10:51:44 +01:00 
			
		
		
		
	* replace ephemeral deletion logic this commit replaces the way we remove ephemeral nodes, currently they are deleted in a loop and we look at last seen time. This time is now only set when a node disconnects and there was a bug (#2006) where nodes that had never disconnected was deleted since they did not have a last seen. The new logic will start an expiry timer when the node disconnects and delete the node from the database when the timer is up. If the node reconnects within the expiry, the timer is cancelled. Fixes #2006 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> * use uint64 as authekyid and ptr helper in tests Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> * add test db helper Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> * add list ephemeral node func Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> * schedule ephemeral nodes for removal on startup Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> * fix gorm query for postgres Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> * add godoc Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> --------- Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
		
			
				
	
	
		
			69 lines
		
	
	
		
			1002 B
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			69 lines
		
	
	
		
			1002 B
		
	
	
	
		
			Go
		
	
	
	
	
	
| package db
 | |
| 
 | |
| import (
 | |
| 	"log"
 | |
| 	"os"
 | |
| 	"testing"
 | |
| 
 | |
| 	"github.com/juanfont/headscale/hscontrol/types"
 | |
| 	"gopkg.in/check.v1"
 | |
| )
 | |
| 
 | |
| func Test(t *testing.T) {
 | |
| 	check.TestingT(t)
 | |
| }
 | |
| 
 | |
| var _ = check.Suite(&Suite{})
 | |
| 
 | |
| type Suite struct{}
 | |
| 
 | |
| var (
 | |
| 	tmpDir string
 | |
| 	db     *HSDatabase
 | |
| )
 | |
| 
 | |
| func (s *Suite) SetUpTest(c *check.C) {
 | |
| 	s.ResetDB(c)
 | |
| }
 | |
| 
 | |
| func (s *Suite) TearDownTest(c *check.C) {
 | |
| 	// os.RemoveAll(tmpDir)
 | |
| }
 | |
| 
 | |
| func (s *Suite) ResetDB(c *check.C) {
 | |
| 	// if len(tmpDir) != 0 {
 | |
| 	// 	os.RemoveAll(tmpDir)
 | |
| 	// }
 | |
| 
 | |
| 	var err error
 | |
| 	db, err = newTestDB()
 | |
| 	if err != nil {
 | |
| 		c.Fatal(err)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func newTestDB() (*HSDatabase, error) {
 | |
| 	var err error
 | |
| 	tmpDir, err = os.MkdirTemp("", "headscale-db-test-*")
 | |
| 	if err != nil {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 
 | |
| 	log.Printf("database path: %s", tmpDir+"/headscale_test.db")
 | |
| 
 | |
| 	db, err = NewHeadscaleDatabase(
 | |
| 		types.DatabaseConfig{
 | |
| 			Type: "sqlite3",
 | |
| 			Sqlite: types.SqliteConfig{
 | |
| 				Path: tmpDir + "/headscale_test.db",
 | |
| 			},
 | |
| 		},
 | |
| 		"",
 | |
| 	)
 | |
| 	if err != nil {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 
 | |
| 	return db, nil
 | |
| }
 |