Mirrors/knx
1
0
Fork 0
mirror of https://github.com/thelsing/knx.git synced 2026-02-23 13:50:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix Sending Wrong Values on Failed Conversion to DPT (#30)

Browse Source 
* Fix `valueNoSendCompare`: DPT Conversion Fail Resulted in Setting KO to 0
* Fix `valueNoSend`: Do NOT End KO Uninitialized when Value Conversion Failed
* Fix: Do NOT Send when Updating KO Failed on Value Conversion
* Group-Object Value Update: Return Indication for Success/Fail of Conversion to DPT
* Update Changelog: #30 Fix and Signature Change of `GroupObject` Value Update
This commit is contained in:
Cornelius Köpp
2024-11-18 20:29:02 +01:00
committed by GitHub
parent 677a645f96
commit 2cd5a28d8e
3 changed files with 50 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
README.md
View File

@@ -16,6 +16,11 @@ See the examples for basic usage options
## Changelog
### v1dev (replace this with version and date when releasing to v1)
- Fix [#30](https://github.com/OpenKNX/knx/pull/30): Unexpected behaviour of `GroupObject` on failed conversion to DPT
- `GroupObject::value[No]SendCompare(..)` resulted in value 0 (and returned change based on this value)
- `GroupObject::valueNoSend(..)` updated state from unitialized to OK, without updating the value
- `GroupObject::value(..)` wrote to GA without setting the KO value
- Extension [#30](https://github.com/OpenKNX/knx/pull/30): Return successful conversion to DPT on values update operations in `GroupObject` (changed result-type of some methods from `void` to `bool`)
- only set pinMode of Prog button pin if valid (PROG_BUTTON_PIN >= 0)
- Strings are now \0 terminated in group objects (#25)
- change defines in the rp2040 plattform for LAN / WLAN usage to KNX_IP_LAN or KNX_IP_WIFI, remove KNX_IP_GENERIC