Merge pull request #244 from OpenKNX/hotfix-uninitialized-asap

Hotfix: remove of _savedAsapXXX = 0
This commit is contained in:
thelsing 2023-05-13 10:07:22 +02:00 committed by GitHub
commit 4cdf6d4ffe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -86,21 +86,18 @@ void ApplicationLayer::dataGroupConfirm(AckType ack, HopCountType hopType, Prior
_bau.groupValueReadLocalConfirm(ack, _savedAsapReadRequest, priority, hopType, secCtrl, status); _bau.groupValueReadLocalConfirm(ack, _savedAsapReadRequest, priority, hopType, secCtrl, status);
else else
println("dataGroupConfirm: APDU-Type GroupValueRead has _savedAsapReadRequest = 0"); println("dataGroupConfirm: APDU-Type GroupValueRead has _savedAsapReadRequest = 0");
_savedAsapReadRequest = 0;
break; break;
case GroupValueResponse: case GroupValueResponse:
if (_savedAsapResponse > 0) if (_savedAsapResponse > 0)
_bau.groupValueReadResponseConfirm(ack, _savedAsapResponse, priority, hopType, secCtrl, apdu.data(), apdu.length() - 1, status); _bau.groupValueReadResponseConfirm(ack, _savedAsapResponse, priority, hopType, secCtrl, apdu.data(), apdu.length() - 1, status);
else else
println("dataGroupConfirm: APDU-Type GroupValueResponse has _savedAsapResponse = 0"); println("dataGroupConfirm: APDU-Type GroupValueResponse has _savedAsapResponse = 0");
_savedAsapResponse = 0;
break; break;
case GroupValueWrite: case GroupValueWrite:
if (_savedAsapWriteRequest > 0) if (_savedAsapWriteRequest > 0)
_bau.groupValueWriteLocalConfirm(ack, _savedAsapWriteRequest, priority, hopType, secCtrl, apdu.data(), apdu.length() - 1, status); _bau.groupValueWriteLocalConfirm(ack, _savedAsapWriteRequest, priority, hopType, secCtrl, apdu.data(), apdu.length() - 1, status);
else else
println("dataGroupConfirm: APDU-Type GroupValueWrite has _savedAsapWriteRequest = 0"); println("dataGroupConfirm: APDU-Type GroupValueWrite has _savedAsapWriteRequest = 0");
_savedAsapWriteRequest = 0;
break; break;
default: default:
print("datagroup-confirm: unhandled APDU-Type: "); print("datagroup-confirm: unhandled APDU-Type: ");