Mirrors/knx
1
0
Fork 0
mirror of https://github.com/thelsing/knx.git synced 2024-10-20 20:07:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

get rid of some warnings during build (#214)

Browse Source 
(comparison between signed and unsigned integer expressions)

Co-authored-by: Waldemar Porscha <wp@porscha.eu>
This commit is contained in:
mumpf 2022-10-15 22:24:58 +02:00 committed by GitHub
parent 920b1d287a
commit 5b48f21f53
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/knx/memory.cpp
View File

@ -127,7 +127,7 @@ void Memory::readMemory()
void Memory::writeMemory()
{
// first get the necessary size of the writeBuffer
size_t writeBufferSize = _metadataSize;
uint16_t writeBufferSize = _metadataSize;
for (int i = 0; i < _saveCount; i++)
writeBufferSize = MAX(writeBufferSize, _saveRestores[i]->saveSize());

8
src/knx/platform.cpp
View File

@ -181,8 +181,8 @@ uint32_t Platform::writeNonVolatileMemory(uint32_t relativeAddress, uint8_t* buf
uint32_t start = _bufferedEraseblockNumber * (flashEraseBlockSize() * flashPageSize());
uint32_t end = start + (flashEraseBlockSize() * flashPageSize());
ptrdiff_t offset = relativeAddress - start;
ptrdiff_t length = end - relativeAddress;
uint32_t offset = relativeAddress - start;
uint32_t length = end - relativeAddress;
if(length > size)
length = size;
memcpy(_eraseblockBuffer + offset, buffer, length);
@ -227,7 +227,7 @@ void Platform::writeBufferedEraseBlock()
if(_bufferedEraseblockNumber > -1 && _bufferedEraseblockDirty)
{
flashErase(_bufferedEraseblockNumber);
for(int i = 0; i < flashEraseBlockSize(); i++)
for(uint32_t i = 0; i < flashEraseBlockSize(); i++)
{
int32_t pageNumber = _bufferedEraseblockNumber * flashEraseBlockSize() + i;
uint8_t *data = _eraseblockBuffer + flashPageSize() * i;
@ -238,7 +238,7 @@ void Platform::writeBufferedEraseBlock()
}
void Platform::bufferEraseBlock(uint32_t eraseBlockNumber)
void Platform::bufferEraseBlock(int32_t eraseBlockNumber)
{
if(_bufferedEraseblockNumber == eraseBlockNumber)
return;

2
src/knx/platform.h
View File

@ -104,7 +104,7 @@ class Platform
// writes _eraseblockBuffer to flash
virtual void writeBufferedEraseBlock();
// copies a EraseBlock into the _eraseblockBuffer
void bufferEraseBlock(uint32_t eraseBlockNumber);
void bufferEraseBlock(int32_t eraseBlockNumber);
// in theory we would have to use this buffer for memory reads too,
// but because ets always restarts the device after programming it

2
src/knx/table_object.cpp
View File

@ -110,7 +110,7 @@ bool TableObject::allocTable(uint32_t size, bool doFill, uint8_t fillByte)
if (doFill)
{
uint32_t addr = _memory.toRelative(_data);
for(int i = 0; i< size;i++)
for(uint32_t i = 0; i < size;i++)
_memory.writeMemory(addr+i, 1, &fillByte);
}