Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2024-12-22 19:07:54 +01:00
Code Issues Projects Releases Wiki Activity
64f212fdda
unleash.unleash/.github/workflows/build_prs.yaml

23 lines
486 B
YAML
Raw Normal View History

fix: modify actions for PRs
2021-10-06 22:16:58 +02:00
name: PR -> Build & Lint
chore: setup separate workflow for PRs
2021-03-04 14:27:43 +01:00
on:
pull_request:
jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
chore: update to node 18 (#3527) ## About the changes This upgrades our main branch to use node 18 which is the active LTS version and stops using node 14 which reaches the end of life in a few weeks: https://nodejs.dev/en/about/releases/ This PR also adds `--no-experimental-fetch` for frontend tests and other frontend commands. Related to: https://github.com/node-fetch/node-fetch/issues/1566 More about the experimental fetch release: https://nodejs.org/en/blog/announcements/v18-release-announce#fetch-experimental
2023-04-18 10:35:32 +02:00
node-version: [18.x]
chore: setup separate workflow for PRs
2021-03-04 14:27:43 +01:00
steps:
chore(deps): update actions/checkout action to v3 (#1407) Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-06 21:43:00 +02:00
- uses: actions/checkout@v3
chore: setup separate workflow for PRs
2021-03-04 14:27:43 +01:00
- name: Use Node.js ${{ matrix.node-version }}
chore(deps): update actions/setup-node action to v3 (#1396) Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-06 21:43:29 +02:00
uses: actions/setup-node@v3
chore: setup separate workflow for PRs
2021-03-04 14:27:43 +01:00
with:
node-version: ${{ matrix.node-version }}
chore: update setup-node task to activate yarn cache (#1661)
2022-06-09 14:26:35 +02:00
cache: 'yarn'
Merge frontend with backend (#1962) * fix: use the frontend dir from the backend * Build is now working * Fix workflows * Fix workflows * Fix build PRs * Test coverage workflow * Test coverage * Test coverage run * Fix jest report * refactor: add missing frontend build * refactor: ignore frontend dir for coverage * refactor: run frontend build in PRs * refactor: run backend tests in PRs * Revert "refactor: run backend tests in PRs" This reverts commit 22cabddfd14f586199517de49d40e7200233c92b. * refactor: remove unused frontend build file * refactor: test workflows in PR * refactor: use a prepare script for the frontend * refactor: simplify yarn build scripts * refactor: fix check-release script * Revert "refactor: test workflows in PR" This reverts commit 496ae194041744ebb54780037dab5e4edf3946ac. * refactor: remove unused gitignore lines * refactor: remove renovate config from the frontend repo * refactor: remove frontend repo license * refactor: remove frontend repo changelog * refactor: update frontend repo readme * refactor: add frontend node_modules to dockerignore * refactor: update the docker yarn.lock snapshot Co-authored-by: olav <mail@olav.io>
2022-08-26 09:25:31 +02:00
- run: yarn install --frozen-lockfile --ignore-scripts
chore: setup separate workflow for PRs
2021-03-04 14:27:43 +01:00
- run: yarn lint
chore: simplify package scripts (#3736) # Simplify package scripts This PR's purpose is to raise a discussion surrounding our current package scripts. It includes some suggestions that aim to simplify the scripts and hopefully bring a much more straightforward approach to developing and contributing to Unleash. Building (prod) should only happen **explicitly** and when needed. ## Before PR (current behavior) - Clone the project; - Open 2 terminals: One for `unleash` and another for `unleash/frontend`; - On `unleash`: - Run `yarn` (which will also build, for some reason?); - Run `yarn start:dev` to start backend in dev mode (`tsc-watch`); - On `unleash/frontend`: - Run `yarn` (which will also build, for some reason?); - Run `yarn start` to start frontend in dev mode (`vite`); So it seems to me like we build unnecessarily every time we install dependencies. Neither dev scripts need to build the project, as backend uses `tsc-watch` and frontend uses `vite`. I'm unsure why this is the case, as building can take a very long time. ![image](https://github.com/Unleash/unleash/assets/14320932/5ecb7df1-e5b4-4d70-ba7e-97119f5d1116) There's also some complexity in the way we need to split the terminal to `cd` into `frontend` and treat it as a different project. The fact that we have different script names is also confusing (`yarn start`, `yarn start:dev`, etc). ## After PR - Clone the project; - Run `yarn` to install all dependencies; - Run `yarn dev` to get started developing Unleash; Running `yarn` should take care of everything needed to start developing. This includes installing dependencies for frontend as well. It should not build projects if we are not being explicit about it, especially since we don't need to build them at this stage. ![image](https://github.com/Unleash/unleash/assets/14320932/614e42fc-3467-432f-91fc-624b1b35c7c1) Running `yarn dev` should start the project in dev mode. This means running both projects in `dev` mode, which for `backend` means running `tsc-watch` and for `frontend` means running `vite`. Here this PR attempts to provide a better DX by using [concurrently](https://www.npmjs.com/package/concurrently) and [wait-on](https://www.npmjs.com/package/wait-on) - This means both tasks are ran simultaneously, stdout is labeled accordingly, and are stopped together. It also means that `frontend` waits for `backend` to be serving at `4242` before starting, since `frontend` starts pretty much immediately with `vite` and `backend` takes a bit longer. Of course, when the `backend` is hot-reloading you may still find some `ECONNREFUSED`s on `frontend` stdout while it recompiles. ![image](https://github.com/Unleash/unleash/assets/14320932/8bde8ee2-3cad-4e3f-a0db-9eed60cfb04d) No more splitting your terminal and treating `frontend` as a separate project. ## Discussion points Maybe there's a better alternative to `tsc-watch`? I briefly explored some alternatives and while they had a much faster starting speed, hot-reload was sometimes slower. IMO we should aspire to run `src/server-dev.ts` directly and only compile when needed. Running `dev:backend` still serves a version of the frontend (at 4242). **Why? Can we remove that behavior?** I can't imagine a scenario in dev where we wouldn't want to run the latest version of the frontend with `vite`. ~~**Note:** This PR removes all other out-of-scope scripts to focus on this revamp. If we decide to merge it, we should evaluate what other existing scripts we still want to include. May be a good opportunity to clean up unused ones and only include the ones we really use. This includes scripts that our GH actions rely on.~~ **Update:** In an effort to minimize impact surface of this PR and make it a bit more ready for merging: - It updates some docs in https://github.com/Unleash/unleash/pull/3736/commits/2a4ff805e87b65d9c1256effaa189ddcccba15fb and https://github.com/Unleash/unleash/pull/3736/commits/1bbc4882519b5a82e3116f0be255ad24a6f3ce53 to reflect our new simplified flow; - It includes the old package scripts for now in https://github.com/Unleash/unleash/pull/3736/commits/039bc04699ac880e491fd3ce01f9bcd6f97a94b9; - It updates some of our GH actions to reflect the new scripts in https://github.com/Unleash/unleash/pull/3736/commits/7782cb9b12e37ee844507e41ef2b7137eaf55666; Given its current status I'll promote the PR to "ready for review". I still think we should have a second look at our existing scripts and GH actions to see what we really need and/or should adapt, but it should be a team effort so we have a broader context. Maybe on a follow-up PR. Does this require any changes to related projects (e.g. Enterprise)? --------- Co-authored-by: Gastón Fournier <gaston@getunleash.io>
2023-05-12 12:23:22 +02:00
- run: yarn build:backend
Reference in New Issue Copy Permalink