2021-09-13 10:23:57 +02:00
|
|
|
import { Knex } from 'knex';
|
|
|
|
import metricsHelper from '../util/metrics-helper';
|
|
|
|
import { DB_TIME } from '../metric-events';
|
|
|
|
import { Logger, LogProvider } from '../logger';
|
|
|
|
import {
|
|
|
|
IFeatureToggleClient,
|
|
|
|
IFeatureToggleQuery,
|
|
|
|
IStrategyConfig,
|
2022-11-15 11:24:36 +01:00
|
|
|
ITag,
|
2021-09-13 10:23:57 +02:00
|
|
|
} from '../types/model';
|
|
|
|
import { IFeatureToggleClientStore } from '../types/stores/feature-toggle-client-store';
|
2021-09-24 13:55:00 +02:00
|
|
|
import { DEFAULT_ENV } from '../util/constants';
|
2022-03-29 14:59:14 +02:00
|
|
|
import { PartialDeep } from '../types/partial';
|
Complete open api schemas for project features controller (#1563)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* revert
* revert
* revert
* revert
* revert
* mapper
* revert
* revert
* revert
* remove serialize-dates.ts
* remove serialize-dates.ts
* remove serialize-dates.ts
* remove serialize-dates.ts
* remove serialize-dates.ts
* revert
* revert
* add mappers
* add mappers
* fix pr comments
* ignore report.json
* ignore report.json
* Route permission required
Co-authored-by: olav <mail@olav.io>
2022-05-18 15:17:09 +02:00
|
|
|
import EventEmitter from 'events';
|
2022-07-01 13:51:26 +02:00
|
|
|
import FeatureToggleStore from './feature-toggle-store';
|
2022-06-29 10:11:34 +02:00
|
|
|
import { ensureStringValue } from '../util/ensureStringValue';
|
|
|
|
import { mapValues } from '../util/map-values';
|
2022-11-15 11:24:36 +01:00
|
|
|
import { IFlagResolver } from '../types/experimental';
|
2022-11-30 12:41:53 +01:00
|
|
|
import Raw = Knex.Raw;
|
2021-09-13 10:23:57 +02:00
|
|
|
|
|
|
|
export interface FeaturesTable {
|
|
|
|
name: string;
|
|
|
|
description: string;
|
|
|
|
type: string;
|
|
|
|
stale: boolean;
|
|
|
|
variants: string;
|
|
|
|
project: string;
|
|
|
|
last_seen_at?: Date;
|
|
|
|
created_at?: Date;
|
|
|
|
}
|
|
|
|
|
2022-11-29 16:06:08 +01:00
|
|
|
export interface IGetAllFeatures {
|
|
|
|
featureQuery?: IFeatureToggleQuery;
|
|
|
|
archived: boolean;
|
|
|
|
isAdmin: boolean;
|
|
|
|
includeStrategyIds?: boolean;
|
|
|
|
userId?: number;
|
|
|
|
}
|
|
|
|
|
|
|
|
export interface IGetAdminFeatures {
|
|
|
|
featureQuery?: IFeatureToggleQuery;
|
|
|
|
archived?: boolean;
|
|
|
|
userId?: number;
|
|
|
|
}
|
|
|
|
|
2021-09-13 10:23:57 +02:00
|
|
|
export default class FeatureToggleClientStore
|
|
|
|
implements IFeatureToggleClientStore
|
|
|
|
{
|
|
|
|
private db: Knex;
|
|
|
|
|
|
|
|
private logger: Logger;
|
|
|
|
|
2022-06-02 10:44:45 +02:00
|
|
|
private inlineSegmentConstraints: boolean;
|
2022-03-29 14:59:14 +02:00
|
|
|
|
2021-09-13 10:23:57 +02:00
|
|
|
private timer: Function;
|
|
|
|
|
2022-11-15 11:24:36 +01:00
|
|
|
private flagResolver: IFlagResolver;
|
|
|
|
|
2022-03-29 14:59:14 +02:00
|
|
|
constructor(
|
|
|
|
db: Knex,
|
|
|
|
eventBus: EventEmitter,
|
|
|
|
getLogger: LogProvider,
|
2022-06-02 10:44:45 +02:00
|
|
|
inlineSegmentConstraints: boolean,
|
2022-11-15 11:24:36 +01:00
|
|
|
flagResolver: IFlagResolver,
|
2022-03-29 14:59:14 +02:00
|
|
|
) {
|
2021-09-13 10:23:57 +02:00
|
|
|
this.db = db;
|
|
|
|
this.logger = getLogger('feature-toggle-client-store.ts');
|
2022-06-02 10:44:45 +02:00
|
|
|
this.inlineSegmentConstraints = inlineSegmentConstraints;
|
2021-09-13 10:23:57 +02:00
|
|
|
this.timer = (action) =>
|
|
|
|
metricsHelper.wrapTimer(eventBus, DB_TIME, {
|
|
|
|
store: 'feature-toggle',
|
|
|
|
action,
|
|
|
|
});
|
2022-11-15 11:24:36 +01:00
|
|
|
this.flagResolver = flagResolver;
|
2021-09-13 10:23:57 +02:00
|
|
|
}
|
|
|
|
|
2022-11-29 16:06:08 +01:00
|
|
|
private async getAll({
|
|
|
|
featureQuery,
|
|
|
|
archived,
|
|
|
|
isAdmin,
|
|
|
|
includeStrategyIds,
|
|
|
|
userId,
|
|
|
|
}: IGetAllFeatures): Promise<IFeatureToggleClient[]> {
|
2021-09-24 13:55:00 +02:00
|
|
|
const environment = featureQuery?.environment || DEFAULT_ENV;
|
2021-09-13 10:23:57 +02:00
|
|
|
const stopTimer = this.timer('getFeatureAdmin');
|
2022-03-29 14:59:14 +02:00
|
|
|
|
|
|
|
let selectColumns = [
|
|
|
|
'features.name as name',
|
|
|
|
'features.description as description',
|
|
|
|
'features.type as type',
|
|
|
|
'features.project as project',
|
|
|
|
'features.stale as stale',
|
|
|
|
'features.impression_data as impression_data',
|
2022-11-21 10:37:16 +01:00
|
|
|
'fe.variants as variants',
|
2022-03-29 14:59:14 +02:00
|
|
|
'features.created_at as created_at',
|
|
|
|
'features.last_seen_at as last_seen_at',
|
|
|
|
'fe.enabled as enabled',
|
|
|
|
'fe.environment as environment',
|
|
|
|
'fs.id as strategy_id',
|
|
|
|
'fs.strategy_name as strategy_name',
|
|
|
|
'fs.parameters as parameters',
|
|
|
|
'fs.constraints as constraints',
|
2022-05-30 09:10:20 +02:00
|
|
|
'segments.id as segment_id',
|
|
|
|
'segments.constraints as segment_constraints',
|
2022-11-30 12:41:53 +01:00
|
|
|
] as (string | Raw<any>)[];
|
2022-03-29 14:59:14 +02:00
|
|
|
|
2021-09-13 10:23:57 +02:00
|
|
|
let query = this.db('features')
|
2022-07-01 13:51:26 +02:00
|
|
|
.modify(FeatureToggleStore.filterByArchived, archived)
|
2022-08-10 08:56:57 +02:00
|
|
|
.leftJoin(
|
2021-10-01 12:27:05 +02:00
|
|
|
this.db('feature_strategies')
|
|
|
|
.select('*')
|
|
|
|
.where({ environment })
|
|
|
|
.as('fs'),
|
|
|
|
'fs.feature_name',
|
|
|
|
'features.name',
|
|
|
|
)
|
2022-08-10 08:56:57 +02:00
|
|
|
.leftJoin(
|
2021-10-01 12:27:05 +02:00
|
|
|
this.db('feature_environments')
|
2022-11-21 10:37:16 +01:00
|
|
|
.select(
|
|
|
|
'feature_name',
|
|
|
|
'enabled',
|
|
|
|
'environment',
|
|
|
|
'variants',
|
|
|
|
)
|
2021-10-01 12:27:05 +02:00
|
|
|
.where({ environment })
|
|
|
|
.as('fe'),
|
|
|
|
'fe.feature_name',
|
2021-09-13 10:23:57 +02:00
|
|
|
'features.name',
|
2022-05-30 09:10:20 +02:00
|
|
|
)
|
2022-07-18 09:30:04 +02:00
|
|
|
.leftJoin(
|
2022-05-30 09:10:20 +02:00
|
|
|
'feature_strategy_segment as fss',
|
|
|
|
`fss.feature_strategy_id`,
|
|
|
|
`fs.id`,
|
|
|
|
)
|
2022-07-14 13:11:22 +02:00
|
|
|
.leftJoin('segments', `segments.id`, `fss.segment_id`);
|
2022-03-29 14:59:14 +02:00
|
|
|
|
2022-11-29 16:06:08 +01:00
|
|
|
if (isAdmin) {
|
|
|
|
if (this.flagResolver.isEnabled('toggleTagFiltering')) {
|
|
|
|
query = query.leftJoin(
|
|
|
|
'feature_tag as ft',
|
|
|
|
'ft.feature_name',
|
|
|
|
'features.name',
|
|
|
|
);
|
|
|
|
selectColumns = [
|
|
|
|
...selectColumns,
|
|
|
|
'ft.tag_value as tag_value',
|
|
|
|
'ft.tag_type as tag_type',
|
|
|
|
];
|
|
|
|
}
|
|
|
|
|
|
|
|
if (userId && this.flagResolver.isEnabled('favorites')) {
|
2022-11-30 12:41:53 +01:00
|
|
|
query = query.leftJoin(`favorite_features`, function () {
|
|
|
|
this.on(
|
|
|
|
'favorite_features.feature',
|
|
|
|
'features.name',
|
|
|
|
).andOnVal('favorite_features.user_id', '=', userId);
|
2022-11-29 16:06:08 +01:00
|
|
|
});
|
2022-11-30 12:41:53 +01:00
|
|
|
selectColumns = [
|
|
|
|
...selectColumns,
|
|
|
|
this.db.raw(
|
|
|
|
'favorite_features.feature is not null as favorite',
|
|
|
|
),
|
|
|
|
];
|
2022-11-29 16:06:08 +01:00
|
|
|
}
|
2022-11-15 11:24:36 +01:00
|
|
|
}
|
|
|
|
|
2022-11-29 16:06:08 +01:00
|
|
|
query = query.select(selectColumns);
|
|
|
|
|
2021-09-13 10:23:57 +02:00
|
|
|
if (featureQuery) {
|
|
|
|
if (featureQuery.tag) {
|
|
|
|
const tagQuery = this.db
|
|
|
|
.from('feature_tag')
|
|
|
|
.select('feature_name')
|
|
|
|
.whereIn(['tag_type', 'tag_value'], featureQuery.tag);
|
2022-03-29 14:59:14 +02:00
|
|
|
query = query.whereIn('features.name', tagQuery);
|
2021-09-13 10:23:57 +02:00
|
|
|
}
|
|
|
|
if (featureQuery.project) {
|
|
|
|
query = query.whereIn('project', featureQuery.project);
|
|
|
|
}
|
|
|
|
if (featureQuery.namePrefix) {
|
|
|
|
query = query.where(
|
2022-03-29 14:59:14 +02:00
|
|
|
'features.name',
|
2021-09-13 10:23:57 +02:00
|
|
|
'like',
|
|
|
|
`${featureQuery.namePrefix}%`,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|
2021-10-01 12:27:05 +02:00
|
|
|
|
2021-09-13 10:23:57 +02:00
|
|
|
const rows = await query;
|
|
|
|
stopTimer();
|
2022-03-29 14:59:14 +02:00
|
|
|
|
2021-09-13 10:23:57 +02:00
|
|
|
const featureToggles = rows.reduce((acc, r) => {
|
2022-03-29 14:59:14 +02:00
|
|
|
let feature: PartialDeep<IFeatureToggleClient> = acc[r.name] ?? {
|
|
|
|
strategies: [],
|
|
|
|
};
|
|
|
|
if (this.isUnseenStrategyRow(feature, r)) {
|
Complete open api schemas for project features controller (#1563)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* revert
* revert
* revert
* revert
* revert
* mapper
* revert
* revert
* revert
* remove serialize-dates.ts
* remove serialize-dates.ts
* remove serialize-dates.ts
* remove serialize-dates.ts
* remove serialize-dates.ts
* revert
* revert
* add mappers
* add mappers
* fix pr comments
* ignore report.json
* ignore report.json
* Route permission required
Co-authored-by: olav <mail@olav.io>
2022-05-18 15:17:09 +02:00
|
|
|
feature.strategies.push(
|
|
|
|
FeatureToggleClientStore.rowToStrategy(r),
|
|
|
|
);
|
2021-09-13 10:23:57 +02:00
|
|
|
}
|
2022-11-15 11:24:36 +01:00
|
|
|
if (this.isNewTag(feature, r)) {
|
|
|
|
this.addTag(feature, r);
|
|
|
|
}
|
2022-06-02 14:07:46 +02:00
|
|
|
if (featureQuery?.inlineSegmentConstraints && r.segment_id) {
|
2022-03-29 14:59:14 +02:00
|
|
|
this.addSegmentToStrategy(feature, r);
|
2022-06-02 14:07:46 +02:00
|
|
|
} else if (
|
|
|
|
!featureQuery?.inlineSegmentConstraints &&
|
|
|
|
r.segment_id
|
|
|
|
) {
|
2022-05-30 09:10:20 +02:00
|
|
|
this.addSegmentIdsToStrategy(feature, r);
|
2021-09-13 10:23:57 +02:00
|
|
|
}
|
2022-02-03 11:06:51 +01:00
|
|
|
feature.impressionData = r.impression_data;
|
2021-10-01 12:27:05 +02:00
|
|
|
feature.enabled = !!r.enabled;
|
2021-09-13 10:23:57 +02:00
|
|
|
feature.name = r.name;
|
2022-11-30 12:41:53 +01:00
|
|
|
feature.favorite = r.favorite;
|
2021-09-13 10:23:57 +02:00
|
|
|
feature.description = r.description;
|
|
|
|
feature.project = r.project;
|
|
|
|
feature.stale = r.stale;
|
|
|
|
feature.type = r.type;
|
2022-11-21 10:37:16 +01:00
|
|
|
feature.variants = r.variants || [];
|
2021-09-13 10:23:57 +02:00
|
|
|
feature.project = r.project;
|
|
|
|
if (isAdmin) {
|
|
|
|
feature.lastSeenAt = r.last_seen_at;
|
|
|
|
feature.createdAt = r.created_at;
|
|
|
|
}
|
|
|
|
acc[r.name] = feature;
|
|
|
|
return acc;
|
|
|
|
}, {});
|
2022-03-29 14:59:14 +02:00
|
|
|
|
|
|
|
const features: IFeatureToggleClient[] = Object.values(featureToggles);
|
|
|
|
|
feat(#1873/playground): Return detailed information on feature toggle evaluation (#1839)
* Feat: return reasons why a feature evaluated to true or false
Note: this is very rough and just straight ripped from the nodejs
client. It will need a lot of work, but is a good place to start
* Feat: add suggested shape for new payload
* Chore: minor cleanup
* Wip: make server compile again
* Remove unused schema ref
* Export new schemas
* Chore: fix some tests to use sub property
* Fix: fix some tests
* Refactor: rename some variables, uncomment some stuff
* Add segments type to bootstrap options
* Add segments capability to offline feature evaluator
* Fix function calls after turning params into an option abject
* Feat: test strategy order, etc
* Feat: add test to check that all strats are returned correctly
* Feat: allow you to include strategy ids in clients
* Wip: hook up segments in the offline client.
Note: compared to regular clients, they still fail
* Feat: add segments validation
* Fix: fix test case invariant.
* Chore: revert to returning only `boolean` from strategies.
This _should_ make it work with custom strategies too 🤞
* Feat: make more properties of the returned feature required
* Wip: add some comments and unfinished tests for edge cases
* Feat: add `isEnabledInCurrentEnvironment` prop
* Feat: consider more strategy failure cases
* Feat: test that isenabledinenvironment matches expectations
* Feat: add unknown strategies
* Fix: fix property access typo
* Feat: add unknown strategy for fallback purposes
* Feat: test edge case: all unknown strategies
* Feat: add custom strategy to arbitrary
* Feat: test that features can be true, even if not enabled in env
* Chore: add some comments
* Wip: fix sdk tests
* Remove comments, improve test logging
* Feat: add descriptions and examples to playground feature schema
* Switch `examples` for `example`
* Update schemas with descriptions and examples
* Fix: update snapshot
* Fix: openapi example
* Fix: merge issues
* Fix: fix issue where feature evaluation state was wrong
* Chore: update openapi spec
* Fix: fix broken offline client tests
* Refactor: move schemas into separate files
* Refactor: remove "reason" for incomplete evaluation.
The only instances where evaluation is incomplete is when we don't
know what the strategy is.
* Refactor: move unleash node client into test and dev dependencies
* Wip: further removal of stuff
* Chore: remove a bunch of code that we don't use
* Chore: remove comment
* Chore: remove unused code
* Fix: fix some prettier errors
* Type parameters in strategies to avoid `any`
* Fix: remove commented out code
* Feat: make `id` required on playground strategies
* Chore: remove redundant type
* Fix: remove redundant if and fix fallback evaluation
* Refactor: reduce nesting and remove duplication
* Fix: remove unused helper function
* Refactor: type `parameters` as `unknown`
* Chore: remove redundant comment
* Refactor: move constraint code into a separate file
* Refactor: rename `unleash` -> `feature-evaluator`
* Rename class `Unleash` -> `FeatureEvaluator`
* Refactor: remove this.ready and sync logic from feature evaluator
* Refactor: remove unused code, rename config type
* Refactor: remove event emission from the Unleash client
* Remove unlistened-for events in feature evaluator
* Refactor: make offline client synchronous; remove code
* Fix: update openapi snapshot after adding required strategy ids
* Feat: change `strategies` format.
This commit changes the format of a playground feature's `strategies`
properties from a list of strategies to an object with properties
`result` and `data`. It looks a bit like this:
```ts
type Strategies = {
result: boolean | "unknown",
data: Strategy[]
}
```
The reason is that this allows us to avoid the breaking change that
was previously suggested in the PR:
`feature.isEnabled` used to be a straight boolean. Then, when we found
out we couldn't necessarily evaluate all strategies (custom strats are
hard!) we changed it to `boolean | 'unevaluated'`. However, this is
confusing on a few levels as the playground results are no longer the
same as the SDK would be, nor are they strictly boolean anymore.
This change reverts the `isEnabled` functionality to what it was
before (so it's always a mirror of what the SDK would show).
The equivalent of `feature.isEnabled === 'unevaluated'` now becomes
`feature.isEnabled && strategy.result === 'unknown'`.
* Fix: Fold long string descriptions over multiple lines.
* Fix: update snapshot after adding line breaks to descriptions
2022-08-04 15:41:52 +02:00
|
|
|
if (!isAdmin && !includeStrategyIds) {
|
2022-03-29 14:59:14 +02:00
|
|
|
// We should not send strategy IDs from the client API,
|
|
|
|
// as this breaks old versions of the Go SDK (at least).
|
Complete open api schemas for project features controller (#1563)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* revert
* revert
* revert
* revert
* revert
* mapper
* revert
* revert
* revert
* remove serialize-dates.ts
* remove serialize-dates.ts
* remove serialize-dates.ts
* remove serialize-dates.ts
* remove serialize-dates.ts
* revert
* revert
* add mappers
* add mappers
* fix pr comments
* ignore report.json
* ignore report.json
* Route permission required
Co-authored-by: olav <mail@olav.io>
2022-05-18 15:17:09 +02:00
|
|
|
FeatureToggleClientStore.removeIdsFromStrategies(features);
|
2022-03-29 14:59:14 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
return features;
|
|
|
|
}
|
|
|
|
|
Complete open api schemas for project features controller (#1563)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* revert
* revert
* revert
* revert
* revert
* mapper
* revert
* revert
* revert
* remove serialize-dates.ts
* remove serialize-dates.ts
* remove serialize-dates.ts
* remove serialize-dates.ts
* remove serialize-dates.ts
* revert
* revert
* add mappers
* add mappers
* fix pr comments
* ignore report.json
* ignore report.json
* Route permission required
Co-authored-by: olav <mail@olav.io>
2022-05-18 15:17:09 +02:00
|
|
|
private static rowToStrategy(row: Record<string, any>): IStrategyConfig {
|
2022-03-29 14:59:14 +02:00
|
|
|
return {
|
|
|
|
id: row.strategy_id,
|
|
|
|
name: row.strategy_name,
|
|
|
|
constraints: row.constraints || [],
|
2022-06-29 10:11:34 +02:00
|
|
|
parameters: mapValues(row.parameters || {}, ensureStringValue),
|
2022-03-29 14:59:14 +02:00
|
|
|
};
|
|
|
|
}
|
|
|
|
|
2022-11-15 11:24:36 +01:00
|
|
|
private static rowToTag(row: Record<string, any>): ITag {
|
|
|
|
return {
|
|
|
|
value: row.tag_value,
|
|
|
|
type: row.tag_type,
|
|
|
|
};
|
|
|
|
}
|
|
|
|
|
Complete open api schemas for project features controller (#1563)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* Completed OpenAPI Schemas for ProjectFeatures Controller
Completed OpenAPI Schemas for Feature Controller (tags)
* bug fix
* bug fix
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* fix merge conflicts, some refactoring
* added emptyResponse, patch feature operation schemas and request
* added emptyResponse, patch feature operation schemas and request
* patch strategy
* patch strategy
* update strategy
* update strategy
* fix pr comment
* fix pr comments
* improvements
* added operationId to schema for better generation
* fix pr comment
* fix pr comment
* fix pr comment
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* improvements to generated and dynamic types
* Update response types to use inferred types
* Update addTag response status to 201
* refactor: move schema ref destructuring into createSchemaObject
* made serialize date handle deep objects
* made serialize date handle deep objects
* add `name` to IFeatureStrategy nad fix tests
* fix pr comments
* fix pr comments
* Add types to IAuthRequest
* Sync StrategySchema for FE and BE - into the rabbit hole
* Sync model with OAS spec
* revert
* revert
* revert
* revert
* revert
* mapper
* revert
* revert
* revert
* remove serialize-dates.ts
* remove serialize-dates.ts
* remove serialize-dates.ts
* remove serialize-dates.ts
* remove serialize-dates.ts
* revert
* revert
* add mappers
* add mappers
* fix pr comments
* ignore report.json
* ignore report.json
* Route permission required
Co-authored-by: olav <mail@olav.io>
2022-05-18 15:17:09 +02:00
|
|
|
private static removeIdsFromStrategies(features: IFeatureToggleClient[]) {
|
2022-03-29 14:59:14 +02:00
|
|
|
features.forEach((feature) => {
|
|
|
|
feature.strategies.forEach((strategy) => {
|
|
|
|
delete strategy.id;
|
|
|
|
});
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
|
|
|
private isUnseenStrategyRow(
|
|
|
|
feature: PartialDeep<IFeatureToggleClient>,
|
|
|
|
row: Record<string, any>,
|
|
|
|
): boolean {
|
|
|
|
return (
|
|
|
|
row.strategy_id &&
|
|
|
|
!feature.strategies.find((s) => s.id === row.strategy_id)
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2022-11-15 11:24:36 +01:00
|
|
|
private addTag(
|
|
|
|
feature: Record<string, any>,
|
|
|
|
row: Record<string, any>,
|
|
|
|
): void {
|
|
|
|
const tags = feature.tags || [];
|
|
|
|
const newTag = FeatureToggleClientStore.rowToTag(row);
|
|
|
|
feature.tags = [...tags, newTag];
|
|
|
|
}
|
|
|
|
|
|
|
|
private isNewTag(
|
|
|
|
feature: PartialDeep<IFeatureToggleClient>,
|
|
|
|
row: Record<string, any>,
|
|
|
|
): boolean {
|
|
|
|
return (
|
|
|
|
row.tag_type &&
|
|
|
|
row.tag_value &&
|
|
|
|
!feature.tags?.some(
|
|
|
|
(tag) =>
|
|
|
|
tag.type === row.tag_type && tag.value === row.tag_value,
|
|
|
|
)
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2022-03-29 14:59:14 +02:00
|
|
|
private addSegmentToStrategy(
|
|
|
|
feature: PartialDeep<IFeatureToggleClient>,
|
|
|
|
row: Record<string, any>,
|
|
|
|
) {
|
|
|
|
feature.strategies
|
|
|
|
.find((s) => s.id === row.strategy_id)
|
|
|
|
?.constraints.push(...row.segment_constraints);
|
2021-09-13 10:23:57 +02:00
|
|
|
}
|
|
|
|
|
2022-05-30 09:10:20 +02:00
|
|
|
private addSegmentIdsToStrategy(
|
|
|
|
feature: PartialDeep<IFeatureToggleClient>,
|
|
|
|
row: Record<string, any>,
|
|
|
|
) {
|
|
|
|
const strategy = feature.strategies.find(
|
|
|
|
(s) => s.id === row.strategy_id,
|
|
|
|
);
|
|
|
|
if (!strategy) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
if (!strategy.segments) {
|
|
|
|
strategy.segments = [];
|
|
|
|
}
|
|
|
|
strategy.segments.push(row.segment_id);
|
|
|
|
}
|
|
|
|
|
2021-09-13 10:23:57 +02:00
|
|
|
async getClient(
|
|
|
|
featureQuery?: IFeatureToggleQuery,
|
feat(#1873/playground): Return detailed information on feature toggle evaluation (#1839)
* Feat: return reasons why a feature evaluated to true or false
Note: this is very rough and just straight ripped from the nodejs
client. It will need a lot of work, but is a good place to start
* Feat: add suggested shape for new payload
* Chore: minor cleanup
* Wip: make server compile again
* Remove unused schema ref
* Export new schemas
* Chore: fix some tests to use sub property
* Fix: fix some tests
* Refactor: rename some variables, uncomment some stuff
* Add segments type to bootstrap options
* Add segments capability to offline feature evaluator
* Fix function calls after turning params into an option abject
* Feat: test strategy order, etc
* Feat: add test to check that all strats are returned correctly
* Feat: allow you to include strategy ids in clients
* Wip: hook up segments in the offline client.
Note: compared to regular clients, they still fail
* Feat: add segments validation
* Fix: fix test case invariant.
* Chore: revert to returning only `boolean` from strategies.
This _should_ make it work with custom strategies too 🤞
* Feat: make more properties of the returned feature required
* Wip: add some comments and unfinished tests for edge cases
* Feat: add `isEnabledInCurrentEnvironment` prop
* Feat: consider more strategy failure cases
* Feat: test that isenabledinenvironment matches expectations
* Feat: add unknown strategies
* Fix: fix property access typo
* Feat: add unknown strategy for fallback purposes
* Feat: test edge case: all unknown strategies
* Feat: add custom strategy to arbitrary
* Feat: test that features can be true, even if not enabled in env
* Chore: add some comments
* Wip: fix sdk tests
* Remove comments, improve test logging
* Feat: add descriptions and examples to playground feature schema
* Switch `examples` for `example`
* Update schemas with descriptions and examples
* Fix: update snapshot
* Fix: openapi example
* Fix: merge issues
* Fix: fix issue where feature evaluation state was wrong
* Chore: update openapi spec
* Fix: fix broken offline client tests
* Refactor: move schemas into separate files
* Refactor: remove "reason" for incomplete evaluation.
The only instances where evaluation is incomplete is when we don't
know what the strategy is.
* Refactor: move unleash node client into test and dev dependencies
* Wip: further removal of stuff
* Chore: remove a bunch of code that we don't use
* Chore: remove comment
* Chore: remove unused code
* Fix: fix some prettier errors
* Type parameters in strategies to avoid `any`
* Fix: remove commented out code
* Feat: make `id` required on playground strategies
* Chore: remove redundant type
* Fix: remove redundant if and fix fallback evaluation
* Refactor: reduce nesting and remove duplication
* Fix: remove unused helper function
* Refactor: type `parameters` as `unknown`
* Chore: remove redundant comment
* Refactor: move constraint code into a separate file
* Refactor: rename `unleash` -> `feature-evaluator`
* Rename class `Unleash` -> `FeatureEvaluator`
* Refactor: remove this.ready and sync logic from feature evaluator
* Refactor: remove unused code, rename config type
* Refactor: remove event emission from the Unleash client
* Remove unlistened-for events in feature evaluator
* Refactor: make offline client synchronous; remove code
* Fix: update openapi snapshot after adding required strategy ids
* Feat: change `strategies` format.
This commit changes the format of a playground feature's `strategies`
properties from a list of strategies to an object with properties
`result` and `data`. It looks a bit like this:
```ts
type Strategies = {
result: boolean | "unknown",
data: Strategy[]
}
```
The reason is that this allows us to avoid the breaking change that
was previously suggested in the PR:
`feature.isEnabled` used to be a straight boolean. Then, when we found
out we couldn't necessarily evaluate all strategies (custom strats are
hard!) we changed it to `boolean | 'unevaluated'`. However, this is
confusing on a few levels as the playground results are no longer the
same as the SDK would be, nor are they strictly boolean anymore.
This change reverts the `isEnabled` functionality to what it was
before (so it's always a mirror of what the SDK would show).
The equivalent of `feature.isEnabled === 'unevaluated'` now becomes
`feature.isEnabled && strategy.result === 'unknown'`.
* Fix: Fold long string descriptions over multiple lines.
* Fix: update snapshot after adding line breaks to descriptions
2022-08-04 15:41:52 +02:00
|
|
|
includeStrategyIds?: boolean,
|
2021-09-13 10:23:57 +02:00
|
|
|
): Promise<IFeatureToggleClient[]> {
|
2022-11-29 16:06:08 +01:00
|
|
|
return this.getAll({
|
|
|
|
featureQuery,
|
|
|
|
archived: false,
|
|
|
|
isAdmin: false,
|
|
|
|
includeStrategyIds,
|
|
|
|
});
|
2021-09-13 10:23:57 +02:00
|
|
|
}
|
|
|
|
|
2022-11-29 16:06:08 +01:00
|
|
|
async getAdmin({
|
|
|
|
featureQuery,
|
|
|
|
userId,
|
|
|
|
archived,
|
|
|
|
}: IGetAdminFeatures): Promise<IFeatureToggleClient[]> {
|
|
|
|
return this.getAll({ featureQuery, archived, isAdmin: true, userId });
|
2021-09-13 10:23:57 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
module.exports = FeatureToggleClientStore;
|