Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-09 00:18:00 +01:00
Code Issues Projects Releases Wiki Activity

fix: use getCreatedBy to set created by on events stored (#1648)

Browse Source
This commit is contained in:
Christopher Kolstad 2022-06-02 13:52:10 +02:00 committed by GitHub
parent 224b9cb229
commit 00c84f3c75
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/services/project-service.ts
View File

@ -217,7 +217,7 @@ export default class ProjectService {
const updatedFeature = await this.featureToggleService.changeProject(
featureName,
newProjectId,
user.username,
getCreatedBy(user),
);
await this.featureToggleService.updateFeatureStrategyProject(
featureName,

18
src/test/e2e/services/project-service.e2e.test.ts
View File

@ -467,6 +467,24 @@ test('should change project when checks pass', async () => {
expect(updatedFeature.project).toBe(projectB.id);
});
test('changing project should emit event even if user does not have a username set', async () => {
const projectA = { id: randomId(), name: randomId() };
const projectB = { id: randomId(), name: randomId() };
const toggle = { name: randomId() };
await projectService.createProject(projectA, user);
await projectService.createProject(projectB, user);
await featureToggleService.createFeatureToggle(projectA.id, toggle, user);
const eventsBeforeChange = await stores.eventStore.getEvents();
await projectService.changeProject(
projectB.id,
toggle.name,
user,
projectA.id,
);
const eventsAfterChange = await stores.eventStore.getEvents();
expect(eventsAfterChange.length).toBe(eventsBeforeChange.length + 1);
}, 10000);
test('should require equal project environments to move features', async () => {
const projectA = { id: randomId(), name: randomId() };
const projectB = { id: randomId(), name: randomId() };