Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-03-18 00:19:49 +01:00
Code Issues Projects Releases Wiki Activity

fix: Playground variants don't show correctly (#1829)

Browse Source 
* Refactor: use the `ALL` constant for tests

* Fix: context is not passed to `getVariant` call

This commit fixes a bug wherein a toggle with variants would show as
enabled but without variants. This was because the `getVariant` call
didn't receive the provided context as an argument.
This commit is contained in:
Thomas Heartman 2022-07-18 13:15:27 +02:00 committed by GitHub
parent 19b95b1bd9
commit 05c390e893
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 61 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/services/playground-service.ts
View File

@ -58,7 +58,7 @@ export class PlaygroundService {
projectId: await this.featureToggleService.getProjectId(
feature.name,
),
variant: client.getVariant(feature.name),
variant: client.getVariant(feature.name, clientContext),
name: feature.name,
};
}),

65
src/test/e2e/api/admin/playground.e2e.test.ts
View File

@ -6,6 +6,7 @@ import { IUnleashTest, setupAppWithAuth } from '../../helpers/test-helper';
import { FeatureToggle, WeightType } from '../../../../lib/types/model';
import getLogger from '../../../fixtures/no-logger';
import {
ALL,
ApiTokenType,
IApiToken,
} from '../../../../lib/types/models/api-token';
@ -25,8 +26,8 @@ beforeAll(async () => {
token = await apiTokenService.createApiTokenWithProjects({
type: ApiTokenType.ADMIN,
username: 'tester',
environment: '*',
projects: ['*'],
environment: ALL,
projects: [ALL],
});
});
@ -172,7 +173,7 @@ describe('Playground API E2E', () => {
// get a subset of projects that exist among the features
const [projects] = fc.sample(
fc.oneof(
fc.constant('*' as '*'),
fc.constant(ALL as '*'),
fc.uniqueArray(
fc.constantFrom(
...features.map(
@ -194,7 +195,7 @@ describe('Playground API E2E', () => {
);
switch (projects) {
case '*':
case ALL:
// no features have been filtered out
return body.features.length === features.length;
case []:
@ -228,7 +229,7 @@ describe('Playground API E2E', () => {
app,
token.secret,
{
projects: '*',
projects: ALL,
environment: 'default',
context: {
appName: 'playground-test',
@ -576,5 +577,59 @@ describe('Playground API E2E', () => {
testParams,
);
});
test('context is applied to variant checks', async () => {
const environment = 'development';
const featureName = 'feature-name';
const customContextFieldName = 'customField';
const customContextValue = 'customValue';
const features = [
{
project: 'any-project',
strategies: [
{
name: 'default',
constraints: [
{
contextName: customContextFieldName,
operator: 'IN' as 'IN',
values: [customContextValue],
},
],
},
],
stale: false,
enabled: true,
name: featureName,
type: 'experiment',
variants: [
{
name: 'a',
weight: 1000,
weightType: 'variable',
stickiness: 'default',
overrides: [],
},
],
},
];
await seedDatabase(db, features, environment);
const request = {
projects: ALL as '*',
environment,
context: {
appName: 'playground',
[customContextFieldName]: customContextValue,
},
};
const body = await playgroundRequest(app, token.secret, request);
// when enabled, this toggle should have one of the variants
expect(body.features[0].variant.name).toBe('a');
});
});
});