Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-04-10 01:16:39 +02:00
Code Issues Projects Releases Wiki Activity

fix: outdated sdk version handles non semver versions (#6586)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2024-03-15 14:58:53 +01:00 committed by GitHub
parent d5bc3585aa
commit 06e2c6e514
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/lib/features/metrics/instance/findOutdatedSdks.test.ts
View File

@ -52,7 +52,13 @@ describe('findOutdatedSDKs', () => {
});
it('should ignore invalid SDK versions', () => {
const sdkVersions = ['unleash-client-node', '1.2.3', null];
const sdkVersions = [
'unleash-client-node',
'1.2.3',
'unleash-client-node:0.0',
'unleash-client-node:development',
null,
];
const result = findOutdatedSDKs(sdkVersions);
expect(result).toEqual([]);
});

1
src/lib/features/metrics/instance/findOutdatedSdks.ts
View File

@ -21,6 +21,7 @@ export const isOutdatedSdk = (sdkVersion: string | null) => {
const [sdkName, version] = result;
const minVersion = config[sdkName];
if (!minVersion) return false;
if (!semver.valid(version)) return false;
if (semver.lt(version, minVersion)) return true;
return false;
};