fix: uintroduce call to update last_seen on client-instance

src/lib/db/client-instance-store.ts

@@ -77,6 +77,19 @@ export default class ClientInstanceStore implements IClientInstanceStore {
         }
     }
 
+    async setLastSeen({
+        appName,
+        instanceId,
+        environment,
+        clientIp,
+    }: INewClientInstance): Promise<void> {
+        await this.db(TABLE)
+            .update({ last_seen: new Date(), client_ip: clientIp })
+            .where({ app_name: appName, instance_id: instanceId, environment })
+            .onConflict(['app_name', 'instance_id', 'environment'])
+            .ignore();
+    }
+
     async bulkUpsert(instances: INewClientInstance[]): Promise<void> {
         const rows = instances.map(mapToDb);
         await this.db(TABLE)

src/lib/services/client-metrics/instance-service.ts

@@ -94,10 +94,11 @@ export default class ClientInstanceService {
         clientIp: string,
     ): Promise<void> {
         const value = await clientMetricsSchema.validateAsync(data);
-        await this.clientInstanceStore.insert({
+        await this.clientInstanceStore.setLastSeen({
             appName: value.appName,
             instanceId: value.instanceId,
-            clientIp,
+            environment: value.environment,
+            clientIp: clientIp,
         });
     }
 

src/lib/types/stores/client-instance-store.ts

@@ -18,6 +18,7 @@ export interface IClientInstanceStore
         Pick<INewClientInstance, 'appName' | 'instanceId'>
     > {
     bulkUpsert(instances: INewClientInstance[]): Promise<void>;
+    setLastSeen(INewClientInstance): Promise<void>;
     insert(details: INewClientInstance): Promise<void>;
     getByAppName(appName: string): Promise<IClientInstance[]>;
     getDistinctApplications(): Promise<string[]>;

src/test/fixtures/fake-client-instance-store.ts

@@ -27,6 +27,10 @@ export default class FakeClientInstanceStore implements IClientInstanceStore {
         );
     }
 
+    setLastSeen(): Promise<void> {
+        return;
+    }
+
     async deleteAll(): Promise<void> {
         this.instances = [];
     }