Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-04 00:18:01 +01:00
Code Issues Projects Releases Wiki Activity

fix: Prevent text highlighting overlap between chips (#188)

Browse Source
This commit is contained in:
Valentin Jonovs 2019-10-08 11:58:35 +02:00 committed by Ivar Conradi Østhus
parent c536a42c79
commit 0989f8e681
2 changed files with 61 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

75
frontend/src/component/feature/form/__tests__/__snapshots__/strategy-input-list-test.jsx.snap
View File

@ -5,24 +5,32 @@ exports[`renders correctly when disabled 1`] = `
<p> <p>
featureName featureName
</p> </p>
<react-mdl-Chip <div
style={ style={
Object { Object {
"marginRight": "3px", "display": "flex",
} }
} }
> >
item1 <react-mdl-Chip
</react-mdl-Chip> style={
<react-mdl-Chip Object {
style={ "marginRight": "3px",
Object { }
"marginRight": "3px",
} }
} >
> item1
item2 </react-mdl-Chip>
</react-mdl-Chip> <react-mdl-Chip
style={
Object {
"marginRight": "3px",
}
}
>
item2
</react-mdl-Chip>
</div>
</div> </div>
`; `;
@ -32,6 +40,13 @@ exports[`renders strategy with empty list as param 1`] = `
<p> <p>
featureName featureName
</p> </p>
<div
style={
Object {
"display": "flex",
}
}
/>
<div <div
style={ style={
Object { Object {
@ -73,26 +88,34 @@ exports[`renders strategy with list as param 1`] = `
<p> <p>
featureName featureName
</p> </p>
<react-mdl-Chip <div
onClose={[Function]}
style={ style={
Object { Object {
"marginRight": "3px", "display": "flex",
} }
} }
> >
item1 <react-mdl-Chip
</react-mdl-Chip> onClose={[Function]}
<react-mdl-Chip style={
onClose={[Function]} Object {
style={ "marginRight": "3px",
Object { }
"marginRight": "3px",
} }
} >
> item1
item2 </react-mdl-Chip>
</react-mdl-Chip> <react-mdl-Chip
onClose={[Function]}
style={
Object {
"marginRight": "3px",
}
}
>
item2
</react-mdl-Chip>
</div>
<div <div
style={ style={
Object { Object {

21
frontend/src/component/feature/form/strategy-input-list.jsx
View File

@ -54,15 +54,18 @@ export default class InputList extends Component {
return ( return (
<div> <div>
<p>{name}</p> <p>{name}</p>
{list.map((entryValue, index) => (
<Chip <div style={{ display: 'flex' }}>
key={index + entryValue} {list.map((entryValue, index) => (
style={{ marginRight: '3px' }} <Chip
onClose={disabled ? undefined : () => this.onClose(index)} key={index + entryValue}
> style={{ marginRight: '3px' }}
{entryValue} onClose={disabled ? undefined : () => this.onClose(index)}
</Chip> >
))} {entryValue}
</Chip>
))}
</div>
{disabled ? ( {disabled ? (
'' ''