From 0a67cfed6760d805d4ab0304870c45d4317318a2 Mon Sep 17 00:00:00 2001 From: Christopher Kolstad Date: Mon, 27 Feb 2023 15:42:13 +0100 Subject: [PATCH] chore: Renames login_events to sign_on_log (#3203) This makes the distinction from the event services clearer. In enterprise we'll also rename LoginEventService etc to reflect this rename. In addition this adds a setting for how long of a retention one should have, defaulting to 336 hours (2 weeks) --- ...7115320-rename-login-events-table-to-sign-on-log.js | 7 +++++++ ...0227123106-add-setting-for-sign-on-log-retention.js | 10 ++++++++++ src/test/e2e/stores/setting-store.e2e.test.ts | 2 +- 3 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 src/migrations/20230227115320-rename-login-events-table-to-sign-on-log.js create mode 100644 src/migrations/20230227123106-add-setting-for-sign-on-log-retention.js diff --git a/src/migrations/20230227115320-rename-login-events-table-to-sign-on-log.js b/src/migrations/20230227115320-rename-login-events-table-to-sign-on-log.js new file mode 100644 index 0000000000..7df8a07389 --- /dev/null +++ b/src/migrations/20230227115320-rename-login-events-table-to-sign-on-log.js @@ -0,0 +1,7 @@ +exports.up = function (db, cb) { + db.runSql(`ALTER TABLE login_events RENAME TO sign_on_log`, cb); +}; + +exports.down = function (db, cb) { + db.runSql(`ALTER TABLE sign_on_log RENAME TO login_events`, cb); +}; diff --git a/src/migrations/20230227123106-add-setting-for-sign-on-log-retention.js b/src/migrations/20230227123106-add-setting-for-sign-on-log-retention.js new file mode 100644 index 0000000000..07440ff0fd --- /dev/null +++ b/src/migrations/20230227123106-add-setting-for-sign-on-log-retention.js @@ -0,0 +1,10 @@ +exports.up = function (db, cb) { + db.runSql( + `INSERT INTO settings(name, content) VALUES ('sign_on_log_retention', '{"hours": 336}')`, + cb, + ); +}; + +exports.down = function (db, cb) { + db.runSql(`DELETE FROM settings WHERE name = 'sign_on_log_retention'`, cb); +}; diff --git a/src/test/e2e/stores/setting-store.e2e.test.ts b/src/test/e2e/stores/setting-store.e2e.test.ts index 3140b41323..ade6d5ee0a 100644 --- a/src/test/e2e/stores/setting-store.e2e.test.ts +++ b/src/test/e2e/stores/setting-store.e2e.test.ts @@ -48,7 +48,7 @@ test('should getAll', async () => { await stores.settingStore.insert('unleash.custom.2', { b: 'hello' }); await stores.settingStore.insert('unleash.custom.3', { b: 'hello' }); const ret = await stores.settingStore.getAll(); - expect(ret).toHaveLength(5); + expect(ret).toHaveLength(6); }); test('should exists', async () => {