From 0a855604af7fe56fbfe8edef5179b16eac616308 Mon Sep 17 00:00:00 2001 From: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com> Date: Wed, 2 Nov 2022 16:05:27 +0100 Subject: [PATCH] feat: review your draft sidebar (#2305) * refactor playground status chip component * fix: update change request sidebar * refactor: status badge cleanup * fix: prettier formatting --- .../ChangeRequest/ChangeRequest.tsx | 10 +- .../ToggleStatusChange.tsx | 12 +- .../ChangeRequestHeader.tsx | 4 +- .../ChangeRequestOverview.tsx | 2 +- .../ChangeRequestSidebar.tsx | 58 +++- .../ChangeRequestStatusBadge.tsx} | 28 +- .../ChangeRequestStatusCell.tsx | 6 +- .../FeatureStatusChip.styles.ts} | 0 .../FeatureStatusChip.tsx} | 9 +- .../FeatureToggleListItem.tsx | 208 ------------- .../FeatureToggleListItem.test.jsx.snap | 291 ------------------ .../FeatureToggleListItem/styles.ts | 37 --- .../FeatureOverviewEnvSwitch.tsx | 2 +- .../feature/FeatureView/FeatureView.tsx | 4 +- .../PlaygroundResultChip.tsx | 71 +---- .../useChangeRequestDraft.ts | 37 +-- frontend/src/themes/theme.ts | 4 + 17 files changed, 107 insertions(+), 676 deletions(-) rename frontend/src/component/changeRequest/{changeRequest.utils.tsx => ChangeRequestStatusBadge/ChangeRequestStatusBadge.tsx} (60%) rename frontend/src/component/common/{StatusChip/StatusChip.styles.ts => FeatureStatusChip/FeatureStatusChip.styles.ts} (100%) rename frontend/src/component/common/{StatusChip/StatusChip.tsx => FeatureStatusChip/FeatureStatusChip.tsx} (81%) delete mode 100644 frontend/src/component/feature/FeatureToggleList/FeatureToggleListItem/FeatureToggleListItem.tsx delete mode 100644 frontend/src/component/feature/FeatureToggleList/FeatureToggleListItem/__snapshots__/FeatureToggleListItem.test.jsx.snap delete mode 100644 frontend/src/component/feature/FeatureToggleList/FeatureToggleListItem/styles.ts diff --git a/frontend/src/component/changeRequest/ChangeRequest/ChangeRequest.tsx b/frontend/src/component/changeRequest/ChangeRequest/ChangeRequest.tsx index 1263ce7c48..f5ea7bc3be 100644 --- a/frontend/src/component/changeRequest/ChangeRequest/ChangeRequest.tsx +++ b/frontend/src/component/changeRequest/ChangeRequest/ChangeRequest.tsx @@ -4,18 +4,18 @@ import { ChangeRequestFeatureToggleChange } from '../ChangeRequestOverview/Chang import { objectId } from 'utils/objectId'; import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender'; import { ToggleStatusChange } from '../ChangeRequestOverview/ChangeRequestFeatureToggleChange/ToggleStatusChange'; -import type { IChangeRequestResponse } from 'hooks/api/getters/useChangeRequestDraft/useChangeRequestDraft'; import { useChangeRequestApi } from 'hooks/api/actions/useChangeRequestApi/useChangeRequestApi'; import { formatUnknownError } from 'utils/formatUnknownError'; import useToast from 'hooks/useToast'; +import type { IChangeRequest } from '../changeRequest.types'; -interface IChangeRequest { - changeRequest: IChangeRequestResponse; +interface IChangeRequestProps { + changeRequest: IChangeRequest; onRefetch?: () => void; onNavigate?: () => void; } -export const ChangeRequest: VFC = ({ +export const ChangeRequest: VFC = ({ changeRequest, onRefetch, onNavigate, @@ -41,7 +41,6 @@ export const ChangeRequest: VFC = ({ return ( - Changes {changeRequest.features?.map(featureToggleChange => ( = ({ condition={change.action === 'updateEnabled'} show={ diff --git a/frontend/src/component/changeRequest/ChangeRequestOverview/ChangeRequestFeatureToggleChange/ToggleStatusChange.tsx b/frontend/src/component/changeRequest/ChangeRequestOverview/ChangeRequestFeatureToggleChange/ToggleStatusChange.tsx index f8da0ccc6b..2cdbb521ef 100644 --- a/frontend/src/component/changeRequest/ChangeRequestOverview/ChangeRequestFeatureToggleChange/ToggleStatusChange.tsx +++ b/frontend/src/component/changeRequest/ChangeRequestOverview/ChangeRequestFeatureToggleChange/ToggleStatusChange.tsx @@ -1,7 +1,7 @@ import { VFC } from 'react'; -import { Link, Box, Typography } from '@mui/material'; -import { PlaygroundResultChip } from 'component/playground/Playground/PlaygroundResultsTable/PlaygroundResultChip/PlaygroundResultChip'; +import { Link, Box } from '@mui/material'; import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender'; +import { Badge } from 'component/common/Badge/Badge'; interface IPlaygroundResultsTable { enabled: boolean; @@ -16,11 +16,9 @@ export const ToggleStatusChange: VFC = ({ New status:{' '} - + + {enabled ? ' Enabled' : 'Disabled'} + = ({ Change request #{changeRequest.id} - {resolveChangeRequestStatusIcon(changeRequest.state)} + ; diff --git a/frontend/src/component/changeRequest/ChangeRequestOverview/ChangeRequestOverview.tsx b/frontend/src/component/changeRequest/ChangeRequestOverview/ChangeRequestOverview.tsx index 58c7471eba..cea58f9821 100644 --- a/frontend/src/component/changeRequest/ChangeRequestOverview/ChangeRequestOverview.tsx +++ b/frontend/src/component/changeRequest/ChangeRequestOverview/ChangeRequestOverview.tsx @@ -65,6 +65,7 @@ export const ChangeRequestOverview: FC = () => { padding: theme.spacing(2), })} > + Changes { changeRequest.state === 'Applied' } /> -