Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-04-24 01:18:01 +02:00
Code Issues Projects Releases Wiki Activity

fix: disallow deletion of all login history entries (#4159)

Browse Source 
https://linear.app/unleash/issue/2-1191/disallow-deletion-of-all-login-entries-in-history-ui

Disallows deletion of all login history entries on the UI.


![image](https://github.com/Unleash/unleash/assets/14320932/f2378d61-0738-4614-b9c5-e81444e8dde1)
This commit is contained in:
Nuno Góis 2023-07-06 12:19:48 +01:00 committed by GitHub
parent e22662e140
commit 0dec24722d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 80 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
frontend/src/component/loginHistory/LoginHistoryTable/LoginHistoryDeleteAllDialog/LoginHistoryDeleteAllDialog.tsx
View File

@ -1,28 +0,0 @@
import { Dialogue } from 'component/common/Dialogue/Dialogue';
interface ILoginHistoryDeleteAllDialogProps {
open: boolean;
setOpen: React.Dispatch<React.SetStateAction<boolean>>;
onConfirm: () => void;
}
export const LoginHistoryDeleteAllDialog = ({
open,
setOpen,
onConfirm,
}: ILoginHistoryDeleteAllDialogProps) => (
<Dialogue
title="Clear login history?"
open={open}
primaryButtonText="Clear login history"
secondaryButtonText="Cancel"
onClick={onConfirm}
onClose={() => {
setOpen(false);
}}
>
You are about to clear the login history.
<br />
This will delete all the login events.
</Dialogue>
);

43
frontend/src/component/loginHistory/LoginHistoryTable/LoginHistoryTable.tsx
View File

@ -1,8 +1,6 @@
import { useEffect, useMemo, useState } from 'react'; import { useEffect, useMemo, useState } from 'react';
import { TablePlaceholder, VirtualizedTable } from 'component/common/Table'; import { TablePlaceholder, VirtualizedTable } from 'component/common/Table';
import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender'; import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
import useToast from 'hooks/useToast';
import { formatUnknownError } from 'utils/formatUnknownError';
import { PageContent } from 'component/common/PageContent/PageContent'; import { PageContent } from 'component/common/PageContent/PageContent';
import { PageHeader } from 'component/common/PageHeader/PageHeader'; import { PageHeader } from 'component/common/PageHeader/PageHeader';
import { IconButton, Tooltip, useMediaQuery } from '@mui/material'; import { IconButton, Tooltip, useMediaQuery } from '@mui/material';
@ -23,8 +21,7 @@ import { useLoginHistoryApi } from 'hooks/api/actions/useLoginHistoryApi/useLogi
import { formatDateYMDHMS } from 'utils/formatDate'; import { formatDateYMDHMS } from 'utils/formatDate';
import { useSearchParams } from 'react-router-dom'; import { useSearchParams } from 'react-router-dom';
import { createLocalStorage } from 'utils/createLocalStorage'; import { createLocalStorage } from 'utils/createLocalStorage';
import { Delete, Download } from '@mui/icons-material'; import { Download } from '@mui/icons-material';
import { LoginHistoryDeleteAllDialog } from './LoginHistoryDeleteAllDialog/LoginHistoryDeleteAllDialog';
export type PageQueryType = Partial< export type PageQueryType = Partial<
Record<'sort' | 'order' | 'search', string> Record<'sort' | 'order' | 'search', string>
@ -45,10 +42,8 @@ const AUTH_TYPE_LABEL: { [key: string]: string } = {
}; };
export const LoginHistoryTable = () => { export const LoginHistoryTable = () => {
const { setToastData, setToastApiError } = useToast(); const { events, loading } = useLoginHistory();
const { downloadCSV } = useLoginHistoryApi();
const { events, loading, refetch } = useLoginHistory();
const { removeAllEvents, downloadCSV } = useLoginHistoryApi();
const [searchParams, setSearchParams] = useSearchParams(); const [searchParams, setSearchParams] = useSearchParams();
const [initialState] = useState(() => ({ const [initialState] = useState(() => ({
@ -65,21 +60,6 @@ export const LoginHistoryTable = () => {
})); }));
const [searchValue, setSearchValue] = useState(initialState.globalFilter); const [searchValue, setSearchValue] = useState(initialState.globalFilter);
const [deleteAllOpen, setDeleteAllOpen] = useState(false);
const onDeleteAllConfirm = async () => {
try {
await removeAllEvents();
setToastData({
title: `History has been cleared`,
type: 'success',
});
refetch();
setDeleteAllOpen(false);
} catch (error: unknown) {
setToastApiError(formatUnknownError(error));
}
};
const isExtraSmallScreen = useMediaQuery(theme.breakpoints.down('sm')); const isExtraSmallScreen = useMediaQuery(theme.breakpoints.down('sm'));
const isSmallScreen = useMediaQuery(theme.breakpoints.down('md')); const isSmallScreen = useMediaQuery(theme.breakpoints.down('md'));
@ -235,18 +215,6 @@ export const LoginHistoryTable = () => {
<Download /> <Download />
</IconButton> </IconButton>
</Tooltip> </Tooltip>
<Tooltip
title="Clear login history"
arrow
>
<IconButton
onClick={() =>
setDeleteAllOpen(true)
}
>
<Delete />
</IconButton>
</Tooltip>
</> </>
} }
/> />
@ -294,11 +262,6 @@ export const LoginHistoryTable = () => {
/> />
} }
/> />
<LoginHistoryDeleteAllDialog
open={deleteAllOpen}
setOpen={setDeleteAllOpen}
onConfirm={onDeleteAllConfirm}
/>
</PageContent> </PageContent>
); );
}; };

12
frontend/src/hooks/api/actions/useLoginHistoryApi/useLoginHistoryApi.ts
View File

@ -22,20 +22,8 @@ export const useLoginHistoryApi = () => {
window.location.assign(url); window.location.assign(url);
}; };
const removeAllEvents = async () => {
const requestId = 'removeAllEvents';
const req = createRequest(
'api/admin/logins',
{ method: 'DELETE' },
requestId
);
await makeRequest(req.caller, req.id);
};
return { return {
downloadCSV, downloadCSV,
removeAllEvents,
errors, errors,
loading, loading,
}; };