Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-25 00:07:47 +01:00
Code Issues Projects Releases Wiki Activity

fix: CR button shows docs for change requests when selected (#7196)

Browse Source 
The props had been left out of the config button by mistake.

It also puts the CR table in a scrollable div that had been removed by
mistake.
This commit is contained in:
Thomas Heartman 2024-05-29 08:38:00 +02:00 committed by GitHub
parent 3aa7e89a3e
commit 0f3d93099d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
frontend/src/component/project/Project/CreateProject/NewCreateProjectForm/ConfigButtons/ChangeRequestTableConfigButton.tsx
View File

@ -3,7 +3,10 @@ import { ConfigButton, type ConfigButtonProps } from './ConfigButton';
import { InputAdornment } from '@mui/material'; import { InputAdornment } from '@mui/material';
import Search from '@mui/icons-material/Search'; import Search from '@mui/icons-material/Search';
import { ChangeRequestTable } from './ChangeRequestTable'; import { ChangeRequestTable } from './ChangeRequestTable';
import { TableSearchInput } from './ChangeRequestTableConfigButton.styles'; import {
ScrollContainer,
TableSearchInput,
} from './ChangeRequestTableConfigButton.styles';
type ChangeRequestTableConfigButtonProps = Pick< type ChangeRequestTableConfigButtonProps = Pick<
ConfigButtonProps, ConfigButtonProps,
@ -35,8 +38,6 @@ export const ChangeRequestTableConfigButton: FC<
projectChangeRequestConfiguration, projectChangeRequestConfiguration,
updateProjectChangeRequestConfiguration, updateProjectChangeRequestConfiguration,
activeEnvironments, activeEnvironments,
onOpen = () => {},
onClose = () => {},
...props ...props
}) => { }) => {
const configured = useMemo(() => { const configured = useMemo(() => {
@ -118,11 +119,13 @@ export const ChangeRequestTableConfigButton: FC<
}} }}
onKeyDown={toggleTopItem} onKeyDown={toggleTopItem}
/> />
<ChangeRequestTable <ScrollContainer>
environments={filteredEnvs} <ChangeRequestTable
enableEnvironment={onEnable} environments={filteredEnvs}
disableEnvironment={onDisable} enableEnvironment={onEnable}
/> disableEnvironment={onDisable}
/>
</ScrollContainer>
</ConfigButton> </ConfigButton>
); );
}; };