From 1081b9d86510ea84c3c3a71d045948af2c919d98 Mon Sep 17 00:00:00 2001 From: ivaosthu Date: Fri, 4 Aug 2017 16:03:15 +0200 Subject: [PATCH] Implement support for logger provider. This allows the users of 'unleash-server' to programatically change the logger implemnentation. #175 --- docs/getting-started.md | 35 +++++++++++++++- lib/app.js | 13 +++--- lib/db/client-instance-store.js | 2 +- lib/db/client-metrics-db.js | 2 +- lib/db/client-metrics-store.js | 2 +- lib/db/feature-toggle-store.js | 2 +- lib/db/strategy-store.js | 2 +- lib/event-differ.test.js | 5 --- lib/logger.js | 40 +++++++++++++------ lib/logger.test.js | 22 ++++++++++ lib/routes/admin-api/applications.test.js | 5 --- lib/routes/admin-api/archive.js | 2 +- lib/routes/admin-api/events.test.js | 5 --- lib/routes/admin-api/feature.js | 2 +- lib/routes/admin-api/feature.test.js | 5 --- lib/routes/admin-api/metrics.js | 2 +- lib/routes/admin-api/metrics.test.js | 5 --- lib/routes/admin-api/route-utils.js | 2 +- lib/routes/admin-api/strategy.js | 2 +- lib/routes/admin-api/strategy.test.js | 5 --- lib/routes/backstage.test.js | 5 --- lib/routes/client-api/feature.test.js | 5 --- lib/routes/client-api/metrics.js | 2 +- lib/routes/client-api/metrics.test.js | 5 --- lib/routes/client-api/register.js | 2 +- lib/routes/client-api/register.test.js | 5 --- lib/routes/health-check.js | 2 +- lib/routes/health-check.test.js | 5 --- lib/routes/index.test.js | 5 --- lib/server-impl.js | 2 +- logger.js | 5 +++ package.json | 2 +- test/e2e/api/admin/event.e2e.test.js | 5 --- .../e2e/api/admin/feature-archive.e2e.test.js | 5 --- test/e2e/api/admin/feature.e2e.test.js | 5 --- test/e2e/api/admin/metrics.e2e.test.js | 5 --- test/e2e/api/admin/strategy.e2e.test.js | 5 --- test/e2e/health.e2e.test.js | 5 --- 38 files changed, 108 insertions(+), 127 deletions(-) create mode 100644 lib/logger.test.js create mode 100644 logger.js diff --git a/docs/getting-started.md b/docs/getting-started.md index 492dd42b97..66a6cf2e47 100644 --- a/docs/getting-started.md +++ b/docs/getting-started.md @@ -37,4 +37,37 @@ Available unleash options includes: - databaseUrl - port -- logLevel - ('INFO', 'ERROR',) + +## How do I configure the log output? + +By default, `unleash` uses [log4js](https://github.com/nomiddlename/log4js-node) to log important information. It is possible to swap out the logger provider (only when using Unleash programatically). This enables filtering of log levels and easy redirection of output streams. + +### What is a logger provider? + +A logger provider is a function which takes the name of a logger and returns a logger implementation. For instance, the following code snippet shows how a logger provider for the global `console` object could be written: + +```javascript +function consoleLoggerProvider (name) { + // do something with the name + return { + debug: console.debug.bind(console), + info: console.info.bind(console), + warn: console.warn.bind(console), + error: console.error.bind(console) + }; +} +``` + +The logger interface with its `debug`, `info`, `warn` and `error` methods expects format string support as seen in `debug` or the JavaScript `console` object. Many commonly used logging implementations cover this API, e.g. bunyan, pino or winston. + +### How do I set a logger provider? + +Custom logger providers need to be set *before requiring the `unleash-server` module*. The following example shows how this can be done: + +```javascript +// first configure the logger provider +const unleashLogger = require('unleash-server/logger'); +unleashLogger.setLoggerProvider(consoleLoggerProvider); + +// then require unleash-server and continue as normal +const unleash = require('unleash-server'); \ No newline at end of file diff --git a/lib/app.js b/lib/app.js index d88a605781..3970894bb5 100644 --- a/lib/app.js +++ b/lib/app.js @@ -6,8 +6,7 @@ const bodyParser = require('body-parser'); const cookieParser = require('cookie-parser'); const validator = require('express-validator'); const responseTime = require('response-time'); -const log4js = require('log4js'); -const logger = require('./logger'); +const logger = require('./logger')('app.js'); const routes = require('./routes'); const path = require('path'); const errorHandler = require('errorhandler'); @@ -56,12 +55,10 @@ module.exports = function(config) { app.use(bodyParser.json({ strict: false })); if (config.enableRequestLogger) { - app.use( - log4js.connectLogger(logger, { - format: ':status :method :url :response-timems', - level: 'auto', // 3XX=WARN, 4xx/5xx=ERROR - }) - ); + app.use((req, res, next) => { + next(); + logger.info(`${res.statusCode} ${req.method} ${req.path}`); + }); } if (typeof config.preRouterHook === 'function') { diff --git a/lib/db/client-instance-store.js b/lib/db/client-instance-store.js index 61d417c5ea..08666c77e2 100644 --- a/lib/db/client-instance-store.js +++ b/lib/db/client-instance-store.js @@ -1,7 +1,7 @@ /* eslint camelcase: "off" */ 'use strict'; -const logger = require('../logger'); +const logger = require('../logger')('client-instance-store.js'); const COLUMNS = [ 'app_name', 'instance_id', diff --git a/lib/db/client-metrics-db.js b/lib/db/client-metrics-db.js index 37f57db3ac..1ee94adfc0 100644 --- a/lib/db/client-metrics-db.js +++ b/lib/db/client-metrics-db.js @@ -1,6 +1,6 @@ 'use strict'; -const logger = require('../logger'); +const logger = require('../logger')('client-metrics-db.js'); const METRICS_COLUMNS = ['id', 'created_at', 'metrics']; const TABLE = 'client_metrics'; diff --git a/lib/db/client-metrics-store.js b/lib/db/client-metrics-store.js index 18522b6390..8630787c2e 100644 --- a/lib/db/client-metrics-store.js +++ b/lib/db/client-metrics-store.js @@ -1,6 +1,6 @@ 'use strict'; -const logger = require('../logger'); +const logger = require('../logger')('client-metrics-store.js'); const { EventEmitter } = require('events'); diff --git a/lib/db/feature-toggle-store.js b/lib/db/feature-toggle-store.js index 8db10c8340..31ae86b46e 100644 --- a/lib/db/feature-toggle-store.js +++ b/lib/db/feature-toggle-store.js @@ -6,7 +6,7 @@ const { FEATURE_ARCHIVED, FEATURE_REVIVED, } = require('../event-type'); -const logger = require('../logger'); +const logger = require('../logger')('client-toggle-store.js'); const NotFoundError = require('../error/notfound-error'); const FEATURE_COLUMNS = [ 'name', diff --git a/lib/db/strategy-store.js b/lib/db/strategy-store.js index 6eaa15193b..c274febbd1 100644 --- a/lib/db/strategy-store.js +++ b/lib/db/strategy-store.js @@ -5,7 +5,7 @@ const { STRATEGY_DELETED, STRATEGY_UPDATED, } = require('../event-type'); -const logger = require('../logger'); +const logger = require('../logger')('strategy-store.js'); const NotFoundError = require('../error/notfound-error'); const STRATEGY_COLUMNS = ['name', 'description', 'parameters', 'built_in']; const TABLE = 'strategies'; diff --git a/lib/event-differ.test.js b/lib/event-differ.test.js index 3dd76dfdcf..8daa7add79 100644 --- a/lib/event-differ.test.js +++ b/lib/event-differ.test.js @@ -3,11 +3,6 @@ const { test } = require('ava'); const eventDiffer = require('./event-differ'); const { FEATURE_CREATED, FEATURE_UPDATED } = require('./event-type'); -const logger = require('./logger'); - -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); test('fails if events include an unknown event type', t => { const events = [ diff --git a/lib/logger.js b/lib/logger.js index 553ee98d48..511e8a6f47 100644 --- a/lib/logger.js +++ b/lib/logger.js @@ -1,19 +1,33 @@ 'use strict'; const log4js = require('log4js'); -log4js.configure({ - appenders: [{ type: 'console' }], -}); -const logger = log4js.getLogger('unleash'); +let loggerProvider = getDefaultLogProvider(); -// TODO: make level configurable -if (process.env.NODE_ENV === 'production') { - logger.setLevel(log4js.levels.ERROR); -} else if (process.env.NODE_ENV === 'test') { - logger.setLevel(log4js.levels.ERROR); -} else { - logger.setLevel(log4js.levels.DEBUG); +module.exports = exports = function getLogger(name) { + return loggerProvider(name); +}; + +exports.setLoggerProvider = function setLoggerProvider(provider) { + loggerProvider = provider; +}; + +function getDefaultLogProvider() { + let level; + if (process.env.NODE_ENV === 'production') { + level = log4js.levels.ERROR; + } else if (process.env.NODE_ENV === 'test') { + level = log4js.levels.FATAL; + } else { + level = log4js.levels.DEBUG; + } + + log4js.configure({ + appenders: [{ type: 'console' }], + levels: { + '[all]': level, + }, + }); + + return log4js.getLogger; } - -module.exports = logger; diff --git a/lib/logger.test.js b/lib/logger.test.js new file mode 100644 index 0000000000..0ceea9f73f --- /dev/null +++ b/lib/logger.test.js @@ -0,0 +1,22 @@ +'use strict'; + +const { test } = require('ava'); +const createLogger = require('./logger'); +const logger = require('../logger'); +const sinon = require('sinon'); + +test('should expose a setLoggerProvider function', t => { + t.true(logger.setLoggerProvider instanceof Function); +}); + +test('should create logger via custom logger provider', t => { + const provider = sinon.stub(); + const loggerName = 'test'; + const loggerImpl = {}; + provider.withArgs(loggerName).returns(loggerImpl); + logger.setLoggerProvider(provider); + + const log = createLogger(loggerName); + + t.is(log, loggerImpl); +}); diff --git a/lib/routes/admin-api/applications.test.js b/lib/routes/admin-api/applications.test.js index 851c2cf383..0f88c2a04b 100644 --- a/lib/routes/admin-api/applications.test.js +++ b/lib/routes/admin-api/applications.test.js @@ -3,16 +3,11 @@ const { test } = require('ava'); const store = require('./../../../test/fixtures/store'); const supertest = require('supertest'); -const logger = require('../../logger'); const getApp = require('../../app'); const { EventEmitter } = require('events'); const eventBus = new EventEmitter(); -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); - function getSetup() { const stores = store.createStores(); const app = getApp({ diff --git a/lib/routes/admin-api/archive.js b/lib/routes/admin-api/archive.js index 5b1791cc2f..b955994282 100644 --- a/lib/routes/admin-api/archive.js +++ b/lib/routes/admin-api/archive.js @@ -2,7 +2,7 @@ const { Router } = require('express'); -const logger = require('../../logger'); +const logger = require('../../logger')('/admin-api/archive.js'); const { FEATURE_REVIVED } = require('../../event-type'); const ValidationError = require('../../error/validation-error'); const validateRequest = require('../../error/validate-request'); diff --git a/lib/routes/admin-api/events.test.js b/lib/routes/admin-api/events.test.js index b9d37f1e23..ef2c2f7839 100644 --- a/lib/routes/admin-api/events.test.js +++ b/lib/routes/admin-api/events.test.js @@ -4,7 +4,6 @@ const { test } = require('ava'); const store = require('./../../../test/fixtures/store'); const supertest = require('supertest'); -const logger = require('../../logger'); const getApp = require('../../app'); const { EventEmitter } = require('events'); @@ -22,10 +21,6 @@ function getSetup() { return { base, eventStore: stores.eventStore, request: supertest(app) }; } -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); - test('should get empty events list via admin', t => { t.plan(1); const { request, base } = getSetup(); diff --git a/lib/routes/admin-api/feature.js b/lib/routes/admin-api/feature.js index 852e9c256b..b1cc0f3221 100644 --- a/lib/routes/admin-api/feature.js +++ b/lib/routes/admin-api/feature.js @@ -3,7 +3,7 @@ const { Router } = require('express'); const joi = require('joi'); -const logger = require('../../logger'); +const logger = require('../../logger')('/admin-api/feature.js'); const { FEATURE_CREATED, FEATURE_UPDATED, diff --git a/lib/routes/admin-api/feature.test.js b/lib/routes/admin-api/feature.test.js index 67a4911941..cb6f30f546 100644 --- a/lib/routes/admin-api/feature.test.js +++ b/lib/routes/admin-api/feature.test.js @@ -3,16 +3,11 @@ const { test } = require('ava'); const store = require('./../../../test/fixtures/store'); const supertest = require('supertest'); -const logger = require('../../logger'); const getApp = require('../../app'); const { EventEmitter } = require('events'); const eventBus = new EventEmitter(); -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); - function getSetup() { const base = `/random${Math.round(Math.random() * 1000)}`; const stores = store.createStores(); diff --git a/lib/routes/admin-api/metrics.js b/lib/routes/admin-api/metrics.js index b57d6a5de6..f2b057f4a6 100644 --- a/lib/routes/admin-api/metrics.js +++ b/lib/routes/admin-api/metrics.js @@ -2,7 +2,7 @@ const { Router } = require('express'); -const logger = require('../../logger'); +const logger = require('../../logger')('/admin-api/metrics.js'); const ClientMetrics = require('../../client-metrics'); const { catchLogAndSendErrorResponse } = require('./route-utils'); diff --git a/lib/routes/admin-api/metrics.test.js b/lib/routes/admin-api/metrics.test.js index 8d82389fa9..4fa5baafac 100644 --- a/lib/routes/admin-api/metrics.test.js +++ b/lib/routes/admin-api/metrics.test.js @@ -3,16 +3,11 @@ const { test } = require('ava'); const store = require('./../../../test/fixtures/store'); const supertest = require('supertest'); -const logger = require('../../logger'); const getApp = require('../../app'); const { EventEmitter } = require('events'); const eventBus = new EventEmitter(); -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); - function getSetup() { const stores = store.createStores(); const app = getApp({ diff --git a/lib/routes/admin-api/route-utils.js b/lib/routes/admin-api/route-utils.js index fcfcb29dd3..23f93dd627 100644 --- a/lib/routes/admin-api/route-utils.js +++ b/lib/routes/admin-api/route-utils.js @@ -1,6 +1,6 @@ 'use strict'; -const logger = require('../../logger'); +const logger = require('../../logger')('route-utils.js'); const catchLogAndSendErrorResponse = (err, res) => { logger.error(err); diff --git a/lib/routes/admin-api/strategy.js b/lib/routes/admin-api/strategy.js index 7375946004..30f836daaf 100644 --- a/lib/routes/admin-api/strategy.js +++ b/lib/routes/admin-api/strategy.js @@ -4,7 +4,7 @@ const { Router } = require('express'); const joi = require('joi'); const eventType = require('../../event-type'); -const logger = require('../../logger'); +const logger = require('../../logger')('/admin-api/strategy.js'); const NameExistsError = require('../../error/name-exists-error'); const extractUser = require('../../extract-user'); const strategySchema = require('./strategy-schema'); diff --git a/lib/routes/admin-api/strategy.test.js b/lib/routes/admin-api/strategy.test.js index f761c2f0ae..89b6912a57 100644 --- a/lib/routes/admin-api/strategy.test.js +++ b/lib/routes/admin-api/strategy.test.js @@ -4,7 +4,6 @@ const { test } = require('ava'); const store = require('./../../../test/fixtures/store'); const supertest = require('supertest'); const getApp = require('../../app'); -const logger = require('../../logger'); const { EventEmitter } = require('events'); const eventBus = new EventEmitter(); @@ -25,10 +24,6 @@ function getSetup() { }; } -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); - test('add version numbers for /stategies', t => { t.plan(1); const { request, base } = getSetup(); diff --git a/lib/routes/backstage.test.js b/lib/routes/backstage.test.js index f2e5a9977b..98f0cfe417 100644 --- a/lib/routes/backstage.test.js +++ b/lib/routes/backstage.test.js @@ -3,16 +3,11 @@ const { test } = require('ava'); const store = require('./../../test/fixtures/store'); const supertest = require('supertest'); -const logger = require('../logger'); const getApp = require('../app'); const { EventEmitter } = require('events'); const eventBus = new EventEmitter(); -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); - test('should use enable prometheus', t => { t.plan(0); const stores = store.createStores(); diff --git a/lib/routes/client-api/feature.test.js b/lib/routes/client-api/feature.test.js index ace8c38549..2b41600503 100644 --- a/lib/routes/client-api/feature.test.js +++ b/lib/routes/client-api/feature.test.js @@ -3,16 +3,11 @@ const { test } = require('ava'); const store = require('./../../../test/fixtures/store'); const supertest = require('supertest'); -const logger = require('../../logger'); const getApp = require('../../app'); const { EventEmitter } = require('events'); const eventBus = new EventEmitter(); -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); - function getSetup() { const base = `/random${Math.round(Math.random() * 1000)}`; const stores = store.createStores(); diff --git a/lib/routes/client-api/metrics.js b/lib/routes/client-api/metrics.js index 50ead3d286..81fa73cca8 100644 --- a/lib/routes/client-api/metrics.js +++ b/lib/routes/client-api/metrics.js @@ -2,7 +2,7 @@ const { Router } = require('express'); const joi = require('joi'); -const logger = require('../../logger'); +const logger = require('../../logger')('client-api/metrics.js'); const { clientMetricsSchema } = require('./metrics-schema'); diff --git a/lib/routes/client-api/metrics.test.js b/lib/routes/client-api/metrics.test.js index 78578c626c..310fd0e0be 100644 --- a/lib/routes/client-api/metrics.test.js +++ b/lib/routes/client-api/metrics.test.js @@ -3,16 +3,11 @@ const { test } = require('ava'); const store = require('./../../../test/fixtures/store'); const supertest = require('supertest'); -const logger = require('../../logger'); const getApp = require('../../app'); const { EventEmitter } = require('events'); const eventBus = new EventEmitter(); -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); - function getSetup() { const stores = store.createStores(); const app = getApp({ diff --git a/lib/routes/client-api/register.js b/lib/routes/client-api/register.js index 034a95c5aa..28acf7146f 100644 --- a/lib/routes/client-api/register.js +++ b/lib/routes/client-api/register.js @@ -2,7 +2,7 @@ const { Router } = require('express'); const joi = require('joi'); -const logger = require('../../logger'); +const logger = require('../../logger')('/client-api/register.js'); const { clientRegisterSchema } = require('./register-schema'); diff --git a/lib/routes/client-api/register.test.js b/lib/routes/client-api/register.test.js index 913e73879c..706407ac65 100644 --- a/lib/routes/client-api/register.test.js +++ b/lib/routes/client-api/register.test.js @@ -3,16 +3,11 @@ const { test } = require('ava'); const store = require('./../../../test/fixtures/store'); const supertest = require('supertest'); -const logger = require('../../logger'); const getApp = require('../../app'); const { EventEmitter } = require('events'); const eventBus = new EventEmitter(); -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); - function getSetup() { const stores = store.createStores(); const app = getApp({ diff --git a/lib/routes/health-check.js b/lib/routes/health-check.js index 578c1eb124..2d95c168dd 100644 --- a/lib/routes/health-check.js +++ b/lib/routes/health-check.js @@ -1,6 +1,6 @@ 'use strict'; -const logger = require('../logger'); +const logger = require('../logger')('health-check.js'); const { Router } = require('express'); exports.router = function(config) { diff --git a/lib/routes/health-check.test.js b/lib/routes/health-check.test.js index 322e73c665..873e15df28 100644 --- a/lib/routes/health-check.test.js +++ b/lib/routes/health-check.test.js @@ -3,16 +3,11 @@ const { test } = require('ava'); const store = require('./../../test/fixtures/store'); const supertest = require('supertest'); -const logger = require('../logger'); const getApp = require('../app'); const { EventEmitter } = require('events'); const eventBus = new EventEmitter(); -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); - function getSetup() { const stores = store.createStores(); const db = stores.db; diff --git a/lib/routes/index.test.js b/lib/routes/index.test.js index d819275903..c1e91fbb3f 100644 --- a/lib/routes/index.test.js +++ b/lib/routes/index.test.js @@ -3,16 +3,11 @@ const { test } = require('ava'); const store = require('./../../test/fixtures/store'); const supertest = require('supertest'); -const logger = require('../logger'); const getApp = require('../app'); const { EventEmitter } = require('events'); const eventBus = new EventEmitter(); -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); - function getSetup() { const base = `/random${Math.round(Math.random() * 1000)}`; const stores = store.createStores(); diff --git a/lib/server-impl.js b/lib/server-impl.js index 1734cac4de..da4ff2687b 100644 --- a/lib/server-impl.js +++ b/lib/server-impl.js @@ -2,7 +2,7 @@ const { EventEmitter } = require('events'); -const logger = require('./logger'); +const logger = require('./logger')('server-impl.js'); const migrator = require('../migrator'); const getApp = require('./app'); diff --git a/logger.js b/logger.js new file mode 100644 index 0000000000..fde89611dd --- /dev/null +++ b/logger.js @@ -0,0 +1,5 @@ +'use strict'; + +const logger = require('./lib/logger'); + +exports.setLoggerProvider = logger.setLoggerProvider; diff --git a/package.json b/package.json index 2dd756c3ab..84e997a5a9 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ "db-migrate": "db-migrate", "lint": "eslint .", "pretest": "npm run lint", - "test": "PORT=4243 ava lib/*.test.js lib/**/*.test.js lib/**/**/*.test.js lib/**/**/**/*.test.js test", + "test": "NODE_ENV=test PORT=4243 ava lib/*.test.js lib/**/*.test.js lib/**/**/*.test.js lib/**/**/**/*.test.js test", "test:docker": "./scripts/docker-postgres.sh", "test:watch": "npm run test -- --watch", "test:pg-virtualenv": "pg_virtualenv npm run test:pg-virtualenv-chai", diff --git a/test/e2e/api/admin/event.e2e.test.js b/test/e2e/api/admin/event.e2e.test.js index 18a5ed8c84..c4a62e3981 100644 --- a/test/e2e/api/admin/event.e2e.test.js +++ b/test/e2e/api/admin/event.e2e.test.js @@ -2,11 +2,6 @@ const { test } = require('ava'); const { setupApp } = require('./../../helpers/test-helper'); -const logger = require('../../../../lib/logger'); - -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); test.serial('returns events', async t => { t.plan(0); diff --git a/test/e2e/api/admin/feature-archive.e2e.test.js b/test/e2e/api/admin/feature-archive.e2e.test.js index 72983b7344..8129bfdcf2 100644 --- a/test/e2e/api/admin/feature-archive.e2e.test.js +++ b/test/e2e/api/admin/feature-archive.e2e.test.js @@ -2,11 +2,6 @@ const { test } = require('ava'); const { setupApp } = require('./../../helpers/test-helper'); -const logger = require('../../../../lib/logger'); - -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); test.serial('returns three archived toggles', async t => { t.plan(1); diff --git a/test/e2e/api/admin/feature.e2e.test.js b/test/e2e/api/admin/feature.e2e.test.js index 998d9e4ed5..4532a026a5 100644 --- a/test/e2e/api/admin/feature.e2e.test.js +++ b/test/e2e/api/admin/feature.e2e.test.js @@ -2,11 +2,6 @@ const { test } = require('ava'); const { setupApp } = require('./../../helpers/test-helper'); -const logger = require('../../../../lib/logger'); - -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); test.serial('returns three feature toggles', async t => { const { request, destroy } = await setupApp('feature_api_serial'); diff --git a/test/e2e/api/admin/metrics.e2e.test.js b/test/e2e/api/admin/metrics.e2e.test.js index df2b4d1871..48d9f7a243 100644 --- a/test/e2e/api/admin/metrics.e2e.test.js +++ b/test/e2e/api/admin/metrics.e2e.test.js @@ -2,11 +2,6 @@ const { test } = require('ava'); const { setupApp } = require('./../../helpers/test-helper'); -const logger = require('../../../../lib/logger'); - -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); test.serial('should register client', async t => { t.plan(0); diff --git a/test/e2e/api/admin/strategy.e2e.test.js b/test/e2e/api/admin/strategy.e2e.test.js index f0e7a37587..e2eb4bb225 100644 --- a/test/e2e/api/admin/strategy.e2e.test.js +++ b/test/e2e/api/admin/strategy.e2e.test.js @@ -2,11 +2,6 @@ const { test } = require('ava'); const { setupApp } = require('./../../helpers/test-helper'); -const logger = require('../../../../lib/logger'); - -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); test.serial('gets all strategies', async t => { t.plan(1); diff --git a/test/e2e/health.e2e.test.js b/test/e2e/health.e2e.test.js index c3447408de..a6697f5e69 100644 --- a/test/e2e/health.e2e.test.js +++ b/test/e2e/health.e2e.test.js @@ -2,11 +2,6 @@ const { test } = require('ava'); const { setupApp } = require('./helpers/test-helper'); -const logger = require('../../lib/logger'); - -test.beforeEach(() => { - logger.setLevel('FATAL'); -}); test('returns health good', async t => { t.plan(0);