From 111a676093c90aaffea0762c48035c5eacbb0bfc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gast=C3=B3n=20Fournier?= Date: Tue, 11 Mar 2025 12:04:25 +0100 Subject: [PATCH] chore: remove deprecated getAdmin from client features store (#9497) This method has been deprecated 2 years ago and is not used --- .../client-feature-toggle-store.ts | 19 ------------------- .../fakes/fake-client-feature-toggle-store.ts | 12 ++---------- .../types/client-feature-toggle-store-type.ts | 4 ---- 3 files changed, 2 insertions(+), 33 deletions(-) diff --git a/src/lib/features/client-feature-toggles/client-feature-toggle-store.ts b/src/lib/features/client-feature-toggles/client-feature-toggle-store.ts index d6c28cffc7..6804dcdcb6 100644 --- a/src/lib/features/client-feature-toggles/client-feature-toggle-store.ts +++ b/src/lib/features/client-feature-toggles/client-feature-toggle-store.ts @@ -31,12 +31,6 @@ export interface IGetAllFeatures { userId?: number; } -export interface IGetAdminFeatures { - featureQuery?: IFeatureToggleQuery; - archived?: boolean; - userId?: number; -} - export default class FeatureToggleClientStore implements IFeatureToggleClientStore { @@ -369,19 +363,6 @@ export default class FeatureToggleClientStore requestType: 'playground', }); } - - async getAdmin({ - featureQuery, - userId, - archived, - }: IGetAdminFeatures): Promise { - return this.getAll({ - featureQuery, - archived: Boolean(archived), - requestType: 'admin', - userId, - }); - } } module.exports = FeatureToggleClientStore; diff --git a/src/lib/features/client-feature-toggles/fakes/fake-client-feature-toggle-store.ts b/src/lib/features/client-feature-toggles/fakes/fake-client-feature-toggle-store.ts index 93554b4274..56654ed84d 100644 --- a/src/lib/features/client-feature-toggles/fakes/fake-client-feature-toggle-store.ts +++ b/src/lib/features/client-feature-toggles/fakes/fake-client-feature-toggle-store.ts @@ -4,7 +4,6 @@ import type { IFeatureToggleQuery, } from '../../../types/model'; import type { IFeatureToggleClientStore } from '../types/client-feature-toggle-store-type'; -import type { IGetAdminFeatures } from '../client-feature-toggle-store'; export default class FakeClientFeatureToggleStore implements IFeatureToggleClientStore @@ -16,7 +15,7 @@ export default class FakeClientFeatureToggleStore archived: boolean = false, ): Promise { const rows = this.featureToggles.filter((toggle) => { - if (featureQuery.namePrefix) { + if (featureQuery?.namePrefix) { if (featureQuery.project) { return ( toggle.name.startsWith(featureQuery.namePrefix) && @@ -27,7 +26,7 @@ export default class FakeClientFeatureToggleStore } return toggle.name.startsWith(featureQuery.namePrefix); } - if (featureQuery.project) { + if (featureQuery?.project) { return featureQuery.project.some((project) => project.includes(toggle.project), ); @@ -73,13 +72,6 @@ export default class FakeClientFeatureToggleStore })); } - async getAdmin({ - featureQuery: query, - archived, - }: IGetAdminFeatures): Promise { - return this.getFeatures(query, archived); - } - // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types async createFeature(feature: any): Promise { this.featureToggles.push({ diff --git a/src/lib/features/client-feature-toggles/types/client-feature-toggle-store-type.ts b/src/lib/features/client-feature-toggles/types/client-feature-toggle-store-type.ts index 3d045d74f8..34f1934673 100644 --- a/src/lib/features/client-feature-toggles/types/client-feature-toggle-store-type.ts +++ b/src/lib/features/client-feature-toggles/types/client-feature-toggle-store-type.ts @@ -2,7 +2,6 @@ import type { IFeatureToggleClient, IFeatureToggleQuery, } from '../../../types/model'; -import type { IGetAdminFeatures } from '../client-feature-toggle-store'; export interface IFeatureToggleClientStore { getClient( @@ -16,7 +15,4 @@ export interface IFeatureToggleClientStore { getPlayground( featureQuery: Partial, ): Promise; - - // @Deprecated - getAdmin(params: IGetAdminFeatures): Promise; }