From 11715a296b88cdc7a89490deaecbf5c22466e5c1 Mon Sep 17 00:00:00 2001
From: Thomas Heartman <thomas@getunleash.io>
Date: Tue, 21 Nov 2023 11:20:37 +0100
Subject: [PATCH] feat: avoid duplicates in changerequeststrategies

---
 src/lib/services/segment-service.ts | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/lib/services/segment-service.ts b/src/lib/services/segment-service.ts
index 74751d800f..0b9657422b 100644
--- a/src/lib/services/segment-service.ts
+++ b/src/lib/services/segment-service.ts
@@ -119,10 +119,13 @@ export class SegmentService implements ISegmentService {
         const strategies =
             await this.featureStrategiesStore.getStrategiesBySegment(id);
 
-        const changeRequestStrategies =
+        const strategyIds = new Set(strategies.map((s) => s.id));
+
+        const changeRequestStrategies = (
             await this.changeRequestSegmentUsageReadModel.getStrategiesUsedInActiveChangeRequests(
                 id,
-            );
+            )
+        ).filter((strategy) => !strategyIds.has(strategy.id));
 
         return { strategies, changeRequestStrategies };
     }