From 138410eafdaa914568ba2e6f13eb2c86e6c3e1a9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nuno=20G=C3=B3is?= <github@nunogois.com>
Date: Mon, 3 Feb 2025 16:24:25 +0000
Subject: [PATCH] chore: drop release plan template view permissions (#9195)

https://linear.app/unleash/issue/2-3225/drop-the-release-template-view-permissions

Drops the release plan template view permissions in favor of an "open by
default" approach.

Should merge the Enterprise PR first.
---
 src/lib/types/permissions.ts                  |  5 -----
 ...20250203145735-drop-rp-view-permissions.js | 21 +++++++++++++++++++
 2 files changed, 21 insertions(+), 5 deletions(-)
 create mode 100644 src/migrations/20250203145735-drop-rp-view-permissions.js

diff --git a/src/lib/types/permissions.ts b/src/lib/types/permissions.ts
index 849bbb61c0..aa76183da7 100644
--- a/src/lib/types/permissions.ts
+++ b/src/lib/types/permissions.ts
@@ -80,9 +80,6 @@ export const PROJECT_DEFAULT_STRATEGY_WRITE = 'PROJECT_DEFAULT_STRATEGY_WRITE';
 export const PROJECT_CHANGE_REQUEST_WRITE = 'PROJECT_CHANGE_REQUEST_WRITE';
 export const PROJECT_SETTINGS_WRITE = 'PROJECT_SETTINGS_WRITE';
 
-export const RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW =
-    'RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW';
-export const RELEASE_PLAN_TEMPLATE_VIEW = 'RELEASE_PLAN_TEMPLATE_VIEW';
 export const RELEASE_PLAN_TEMPLATE_CREATE = 'RELEASE_PLAN_TEMPLATE_CREATE';
 export const RELEASE_PLAN_TEMPLATE_UPDATE = 'RELEASE_PLAN_TEMPLATE_UPDATE';
 export const RELEASE_PLAN_TEMPLATE_DELETE = 'RELEASE_PLAN_TEMPLATE_DELETE';
@@ -140,8 +137,6 @@ export const ROOT_PERMISSION_CATEGORIES = [
     {
         label: 'Release plan templates',
         permissions: [
-            RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW,
-            RELEASE_PLAN_TEMPLATE_VIEW,
             RELEASE_PLAN_TEMPLATE_CREATE,
             RELEASE_PLAN_TEMPLATE_DELETE,
             RELEASE_PLAN_TEMPLATE_UPDATE,
diff --git a/src/migrations/20250203145735-drop-rp-view-permissions.js b/src/migrations/20250203145735-drop-rp-view-permissions.js
new file mode 100644
index 0000000000..c8d846fdd4
--- /dev/null
+++ b/src/migrations/20250203145735-drop-rp-view-permissions.js
@@ -0,0 +1,21 @@
+exports.up = (db, cb) => {
+    db.runSql(`
+        DELETE
+        FROM permissions
+        WHERE permission IN
+              ('RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW', 'RELEASE_PLAN_TEMPLATE_VIEW');
+    `, cb);
+
+  };
+
+  exports.down = (db, cb) => {
+    db.runSql(`
+        INSERT INTO permissions(permission, display_name, type) VALUES
+            ('RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW', 'View overview of release plan templates', 'root'),
+            ('RELEASE_PLAN_TEMPLATE_VIEW', 'View details of specific release plan template', 'root');
+        INSERT INTO role_permission(role_id, permission, created_by_user_id)
+                SELECT id, 'RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW', '-1337' FROM roles WHERE name IN ('Viewer', 'Editor') AND type = 'root';
+        INSERT INTO role_permission(role_id, permission, created_by_user_id)
+                SELECT id, 'RELEASE_PLAN_TEMPLATE_VIEW', '-1337' FROM roles WHERE name = 'Editor' AND type = 'root';
+    `, cb);
+  };