Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-25 00:07:47 +01:00
Code Issues Projects Releases Wiki Activity

fix: change requests placeholder (#8724)

Browse Source 
If project does not have CRs configured, show correct info.
This commit is contained in:
Tymoteusz Czech 2024-11-25 17:54:25 +01:00 committed by GitHub
parent d75c63b6e8
commit 1433878f32
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 25 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/src/component/changeRequest/ProjectChangeRequests/ChangeRequestsTabs/ChangeRequestsTabs.tsx
View File

@ -1,3 +1,4 @@
import { type ReactNode, useEffect, useMemo, useState } from 'react';
import { PageContent } from 'component/common/PageContent/PageContent';
import { PageHeader } from 'component/common/PageHeader/PageHeader';
import {
@ -13,7 +14,6 @@ import { SearchHighlightProvider } from 'component/common/Table/SearchHighlightC
import { Box, styled, Tab, Tabs, useMediaQuery } from '@mui/material';
import { Link, useSearchParams } from 'react-router-dom';
import { sortTypes } from 'utils/sortTypes';
import { useEffect, useMemo, useState } from 'react';
import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
import { Search } from 'component/common/Search/Search';
import { featuresPlaceholder } from 'component/feature/FeatureToggleList/FeatureToggleListTable';
@ -34,6 +34,7 @@ export interface IChangeRequestTableProps {
changeRequests: any[];
loading: boolean;
projectId: string;
placeholder?: ReactNode;
}
const defaultSort: SortingRule<string> & {
@ -63,6 +64,7 @@ const ConftigurationLinkBox = styled(Box)(({ theme }) => ({
export const ChangeRequestsTabs = ({
changeRequests = [],
placeholder,
loading,
projectId,
}: IChangeRequestTableProps) => {
@ -368,7 +370,8 @@ export const ChangeRequestsTabs = ({
}
elseShow={
<TablePlaceholder>
None of the changes were submitted yet.
{placeholder ||
'None of the changes were submitted yet.'}
</TablePlaceholder>
}
/>

20
frontend/src/component/changeRequest/ProjectChangeRequests/ProjectChangeRequests.tsx
View File

@ -6,6 +6,8 @@ import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig';
import { PageContent } from 'component/common/PageContent/PageContent';
import { PremiumFeature } from 'component/common/PremiumFeature/PremiumFeature';
import { useProjectOverviewNameOrId } from 'hooks/api/getters/useProjectOverview/useProjectOverview';
import { useChangeRequestConfig } from 'hooks/api/getters/useChangeRequestConfig/useChangeRequestConfig';
import { Link } from 'react-router-dom';
export const ProjectChangeRequests = () => {
const projectId = useRequiredPathParam('projectId');
@ -15,6 +17,11 @@ export const ProjectChangeRequests = () => {
usePageTitle(`Change requests – ${projectName}`);
const { changeRequests, loading } = useProjectChangeRequests(projectId);
const { data: configData, loading: configLoading } =
useChangeRequestConfig(projectId);
const isConfigured = configData.some(
(config) => config.changeRequestEnabled,
);
if (isOss() || isPro()) {
return (
@ -29,6 +36,19 @@ export const ProjectChangeRequests = () => {
changeRequests={changeRequests}
projectId={projectId}
loading={loading}
placeholder={
!configLoading && !isConfigured ? (
<p>
Change requests are not configured for this project.
<br />
<Link
to={`/projects/${projectId}/settings/change-requests`}
>
Configure change requests
</Link>
</p>
) : undefined
}
/>
);
};