From 164d30e7ee866fd04652f24b8dc2be79312b6520 Mon Sep 17 00:00:00 2001 From: ivaosthu Date: Sat, 20 Jan 2018 14:01:47 +0100 Subject: [PATCH] Bugfix: filter regex should never throw. closes #103 --- .../src/component/feature/list-container.jsx | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/frontend/src/component/feature/list-container.jsx b/frontend/src/component/feature/list-container.jsx index 5847deae30..c20c2d1b1b 100644 --- a/frontend/src/component/feature/list-container.jsx +++ b/frontend/src/component/feature/list-container.jsx @@ -10,13 +10,17 @@ const mapStateToProps = state => { const settings = state.settings.toJS().feature || {}; let features = state.features.toJS(); if (settings.filter) { - const regex = new RegExp(settings.filter, 'i'); - features = features.filter( - feature => - regex.test(feature.name) || - regex.test(feature.description) || - feature.strategies.some(s => s && s.name && regex.test(s.name)) - ); + try { + const regex = new RegExp(settings.filter, 'i'); + features = features.filter( + feature => + regex.test(feature.name) || + regex.test(feature.description) || + feature.strategies.some(s => s && s.name && regex.test(s.name)) + ); + } catch (e) { + // Invalid filter regex + } } if (!settings.sort) {