Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-09 00:18:00 +01:00
Code Issues Projects Releases Wiki Activity

feat: pre-live is non production not just dev (#6946)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2024-04-26 12:43:10 +02:00 committed by GitHub
parent 66ec9a2f2f
commit 1739f8e11d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/features/feature-lifecycle/feature-lifecycle-service.test.ts
View File

@ -39,7 +39,7 @@ test('can insert and read lifecycle stages', async () => {
await environmentStore.create({ await environmentStore.create({
name: 'my-dev-environment', name: 'my-dev-environment',
type: 'development', type: 'test',
} as IEnvironment); } as IEnvironment);
await environmentStore.create({ await environmentStore.create({
name: 'my-prod-environment', name: 'my-prod-environment',

3
src/lib/features/feature-lifecycle/feature-lifecycle-service.ts
View File

@ -138,10 +138,9 @@ export class FeatureLifecycleService extends EventEmitter {
if (!env) { if (!env) {
return; return;
} }
await this.stageReceivedMetrics(features, 'pre-live');
if (env.type === 'production') { if (env.type === 'production') {
await this.stageReceivedMetrics(features, 'live'); await this.stageReceivedMetrics(features, 'live');
} else if (env.type === 'development') {
await this.stageReceivedMetrics(features, 'pre-live');
} }
} catch (e) { } catch (e) {
this.logger.warn( this.logger.warn(

1
src/lib/features/feature-lifecycle/feature-lifecycle.e2e.test.ts
View File

@ -136,6 +136,7 @@ test('should return lifecycle stages', async () => {
stage: 'initial', stage: 'initial',
enteredStageAt: expect.any(String), enteredStageAt: expect.any(String),
}, },
{ stage: 'pre-live', enteredStageAt: expect.any(String) },
{ {
stage: 'live', stage: 'live',
enteredStageAt: expect.any(String), enteredStageAt: expect.any(String),