Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-09 00:18:00 +01:00
Code Issues Projects Releases Wiki Activity

fix: use the correct design token color for the health chart background (#8783)

Browse Source 
This change swaps out the color of the health chart "unfilled" section
for `theme.palette.background.application`. This is the same color
that's used in the sketches, so it should apply better for dark mode.

Why? I noticed that the graph looks choppy in dark mode, so figured
I'd go and investigate. This update makes it look a lot smoother.

Light mode looks the same as before.

Before (notice the leaking light grey):

![image](https://github.com/user-attachments/assets/535ca24b-756b-460c-a7ab-78daf28d68ba)


After:

![image](https://github.com/user-attachments/assets/98d4c0de-bde3-4d10-9210-fdd0bf5dc572)
This commit is contained in:
Thomas Heartman 2024-11-18 13:07:40 +01:00 committed by GitHub
parent a55a956772
commit 18591dd017
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/component/project/Project/ProjectStatus/ProjectHealth.tsx
View File

@ -118,7 +118,7 @@ export const ProjectHealth = () => {
cy='50' cy='50'
r={ChartRadius} r={ChartRadius}
fill='none' fill='none'
stroke={theme.palette.grey[300]} stroke={theme.palette.background.application}
strokeWidth={ChartStrokeWidth} strokeWidth={ChartStrokeWidth}
strokeDasharray={`${filledLength * circumference} ${gapLength * circumference}`} strokeDasharray={`${filledLength * circumference} ${gapLength * circumference}`}
strokeDashoffset={offset * circumference} strokeDashoffset={offset * circumference}