From aae8c4d9d9d3a2930f637bb33ed0979498d086cd Mon Sep 17 00:00:00 2001 From: Youssef Date: Wed, 23 Feb 2022 00:10:48 +0100 Subject: [PATCH 1/5] refactor: update text in ui consistent --- .../component/admin/api-token/ApiTokenList/ApiTokenList.tsx | 2 +- .../admin/project-roles/EditProjectRole/EditProjectRole.tsx | 2 +- frontend/src/component/admin/users/EditUser/EditUser.tsx | 2 +- frontend/src/component/admin/users/UsersAdmin.tsx | 2 +- frontend/src/component/context/ContextList/ContextList.jsx | 2 +- frontend/src/component/context/EditContext/EditContext.tsx | 2 +- .../environments/EditEnvironment/EditEnvironment.tsx | 2 +- .../environments/EnvironmentList/EnvironmentList.tsx | 4 ++-- frontend/src/component/feature/EditFeature/EditFeature.tsx | 2 +- .../component/feature/FeatureToggleList/FeatureToggleList.jsx | 2 +- .../__tests__/__snapshots__/list-component-test.jsx.snap | 4 ++-- .../FeatureStrategiesEnvironments.tsx | 2 +- .../FeatureVariantsList/FeatureVariantsList.tsx | 2 +- .../src/component/project/Project/EditProject/EditProject.tsx | 2 +- frontend/src/component/project/ProjectList/ProjectList.tsx | 2 +- .../component/strategies/StrategiesList/StrategiesList.tsx | 2 +- .../src/component/strategies/StrategyForm/StrategyForm.tsx | 2 +- .../__tests__/__snapshots__/list-component-test.jsx.snap | 4 ++-- frontend/src/component/tags/EditTagType/EditTagType.tsx | 2 +- frontend/src/component/tags/TagTypeList/TagTypeList.jsx | 2 +- .../__tests__/__snapshots__/TagTypeList.test.js.snap | 4 ++-- 21 files changed, 25 insertions(+), 25 deletions(-) diff --git a/frontend/src/component/admin/api-token/ApiTokenList/ApiTokenList.tsx b/frontend/src/component/admin/api-token/ApiTokenList/ApiTokenList.tsx index 7e97a831b1..f313fc83ef 100644 --- a/frontend/src/component/admin/api-token/ApiTokenList/ApiTokenList.tsx +++ b/frontend/src/component/admin/api-token/ApiTokenList/ApiTokenList.tsx @@ -249,7 +249,7 @@ export const ApiTokenList = () => { } data-test={CREATE_API_TOKEN_BUTTON} > - Create API token + New API token } /> diff --git a/frontend/src/component/admin/project-roles/EditProjectRole/EditProjectRole.tsx b/frontend/src/component/admin/project-roles/EditProjectRole/EditProjectRole.tsx index eb79af949c..29c396ff6f 100644 --- a/frontend/src/component/admin/project-roles/EditProjectRole/EditProjectRole.tsx +++ b/frontend/src/component/admin/project-roles/EditProjectRole/EditProjectRole.tsx @@ -125,7 +125,7 @@ to resources within a project" getRoleKey={getRoleKey} > - Edit role + Save diff --git a/frontend/src/component/admin/users/EditUser/EditUser.tsx b/frontend/src/component/admin/users/EditUser/EditUser.tsx index 07e212bf56..4bafebbea2 100644 --- a/frontend/src/component/admin/users/EditUser/EditUser.tsx +++ b/frontend/src/component/admin/users/EditUser/EditUser.tsx @@ -95,7 +95,7 @@ const EditUser = () => { mode={EDIT} > - Edit user + Save diff --git a/frontend/src/component/admin/users/UsersAdmin.tsx b/frontend/src/component/admin/users/UsersAdmin.tsx index 0b9f2c7cf6..bb16b611d9 100644 --- a/frontend/src/component/admin/users/UsersAdmin.tsx +++ b/frontend/src/component/admin/users/UsersAdmin.tsx @@ -35,7 +35,7 @@ const UsersAdmin = () => { history.push('/admin/create-user') } > - Add new user + New user } elseShow={ diff --git a/frontend/src/component/context/ContextList/ContextList.jsx b/frontend/src/component/context/ContextList/ContextList.jsx index c9379b0110..99c5287eae 100644 --- a/frontend/src/component/context/ContextList/ContextList.jsx +++ b/frontend/src/component/context/ContextList/ContextList.jsx @@ -127,7 +127,7 @@ const ContextList = () => { color="primary" variant="contained" > - Add new context field + New context field } /> diff --git a/frontend/src/component/context/EditContext/EditContext.tsx b/frontend/src/component/context/EditContext/EditContext.tsx index 146353167b..4d4de9fc6c 100644 --- a/frontend/src/component/context/EditContext/EditContext.tsx +++ b/frontend/src/component/context/EditContext/EditContext.tsx @@ -107,7 +107,7 @@ const EditContext = () => { permission={UPDATE_CONTEXT_FIELD} type="submit" > - Edit context + Save diff --git a/frontend/src/component/environments/EditEnvironment/EditEnvironment.tsx b/frontend/src/component/environments/EditEnvironment/EditEnvironment.tsx index ecfc11ec5d..5513b15ea3 100644 --- a/frontend/src/component/environments/EditEnvironment/EditEnvironment.tsx +++ b/frontend/src/component/environments/EditEnvironment/EditEnvironment.tsx @@ -86,7 +86,7 @@ const EditEnvironment = () => { clearErrors={clearErrors} > - Edit environment + Save diff --git a/frontend/src/component/environments/EnvironmentList/EnvironmentList.tsx b/frontend/src/component/environments/EnvironmentList/EnvironmentList.tsx index 691946e0de..a2903ca300 100644 --- a/frontend/src/component/environments/EnvironmentList/EnvironmentList.tsx +++ b/frontend/src/component/environments/EnvironmentList/EnvironmentList.tsx @@ -172,10 +172,10 @@ const EnvironmentList = () => { - Add Environment + New Environment } diff --git a/frontend/src/component/feature/EditFeature/EditFeature.tsx b/frontend/src/component/feature/EditFeature/EditFeature.tsx index 239dac8030..636055c001 100644 --- a/frontend/src/component/feature/EditFeature/EditFeature.tsx +++ b/frontend/src/component/feature/EditFeature/EditFeature.tsx @@ -106,7 +106,7 @@ const EditFeature = () => { projectId={project} type="submit" > - Edit toggle + Save diff --git a/frontend/src/component/feature/FeatureToggleList/FeatureToggleList.jsx b/frontend/src/component/feature/FeatureToggleList/FeatureToggleList.jsx index 7c5ea29409..b6f94bf062 100644 --- a/frontend/src/component/feature/FeatureToggleList/FeatureToggleList.jsx +++ b/frontend/src/component/feature/FeatureToggleList/FeatureToggleList.jsx @@ -181,7 +181,7 @@ const FeatureToggleList = ({ skeleton: loading, })} > - Create feature toggle + New feature toggle } /> diff --git a/frontend/src/component/feature/FeatureToggleList/__tests__/__snapshots__/list-component-test.jsx.snap b/frontend/src/component/feature/FeatureToggleList/__tests__/__snapshots__/list-component-test.jsx.snap index 36bd2043b0..8999e76e61 100644 --- a/frontend/src/component/feature/FeatureToggleList/__tests__/__snapshots__/list-component-test.jsx.snap +++ b/frontend/src/component/feature/FeatureToggleList/__tests__/__snapshots__/list-component-test.jsx.snap @@ -163,7 +163,7 @@ exports[`renders correctly with one feature 1`] = ` - Create feature toggle + New feature toggle @@ -358,7 +358,7 @@ exports[`renders correctly with one feature without permissions 1`] = ` - Create feature toggle + New feature toggle diff --git a/frontend/src/component/feature/FeatureView/FeatureStrategies/FeatureStrategiesEnvironments/FeatureStrategiesEnvironments.tsx b/frontend/src/component/feature/FeatureView/FeatureStrategies/FeatureStrategiesEnvironments/FeatureStrategiesEnvironments.tsx index 5845f78f53..0cc45cf4e0 100644 --- a/frontend/src/component/feature/FeatureView/FeatureStrategies/FeatureStrategiesEnvironments/FeatureStrategiesEnvironments.tsx +++ b/frontend/src/component/feature/FeatureView/FeatureStrategies/FeatureStrategiesEnvironments/FeatureStrategiesEnvironments.tsx @@ -282,7 +282,7 @@ const FeatureStrategiesEnvironments = () => { environmentId={activeEnvironment.name} permission={CREATE_FEATURE_STRATEGY} > - Add new strategy + New strategy } /> diff --git a/frontend/src/component/feature/FeatureView/FeatureVariants/FeatureVariantsList/FeatureVariantsList.tsx b/frontend/src/component/feature/FeatureView/FeatureVariants/FeatureVariantsList/FeatureVariantsList.tsx index 5eab68a83f..a215e55731 100644 --- a/frontend/src/component/feature/FeatureView/FeatureVariants/FeatureVariantsList/FeatureVariantsList.tsx +++ b/frontend/src/component/feature/FeatureView/FeatureVariants/FeatureVariantsList/FeatureVariantsList.tsx @@ -293,7 +293,7 @@ const FeatureOverviewVariants = () => { permission={UPDATE_FEATURE_VARIANTS} projectId={projectId} > - Add variant + New variant { validateIdUniqueness={validateIdUniqueness} > - Edit project + Save diff --git a/frontend/src/component/project/ProjectList/ProjectList.tsx b/frontend/src/component/project/ProjectList/ProjectList.tsx index 98be2717f0..d4afcb3bcd 100644 --- a/frontend/src/component/project/ProjectList/ProjectList.tsx +++ b/frontend/src/component/project/ProjectList/ProjectList.tsx @@ -139,7 +139,7 @@ const ProjectListNew = () => { tooltip={createButtonData.title} disabled={createButtonData.disabled} > - Add new project + New project } /> diff --git a/frontend/src/component/strategies/StrategiesList/StrategiesList.tsx b/frontend/src/component/strategies/StrategiesList/StrategiesList.tsx index 8439435d58..cbe3a9f6b9 100644 --- a/frontend/src/component/strategies/StrategiesList/StrategiesList.tsx +++ b/frontend/src/component/strategies/StrategiesList/StrategiesList.tsx @@ -80,7 +80,7 @@ export const StrategiesList = () => { data-test={ADD_NEW_STRATEGY_ID} tooltip={'Add new strategy'} > - Add new strategy + New strategy } /> diff --git a/frontend/src/component/strategies/StrategyForm/StrategyForm.tsx b/frontend/src/component/strategies/StrategyForm/StrategyForm.tsx index c980baa622..2d87e2ce3a 100644 --- a/frontend/src/component/strategies/StrategyForm/StrategyForm.tsx +++ b/frontend/src/component/strategies/StrategyForm/StrategyForm.tsx @@ -178,7 +178,7 @@ export const StrategyForm = ({ editMode, strategy }: IStrategyFormProps) => { color="primary" style={{ display: 'block' }} > - Update + Save } elseShow={ diff --git a/frontend/src/component/strategies/__tests__/__snapshots__/list-component-test.jsx.snap b/frontend/src/component/strategies/__tests__/__snapshots__/list-component-test.jsx.snap index c3cceed402..729c09e34f 100644 --- a/frontend/src/component/strategies/__tests__/__snapshots__/list-component-test.jsx.snap +++ b/frontend/src/component/strategies/__tests__/__snapshots__/list-component-test.jsx.snap @@ -62,7 +62,7 @@ exports[`renders correctly with one strategy 1`] = ` - Add new strategy + New strategy @@ -287,7 +287,7 @@ exports[`renders correctly with one strategy without permissions 1`] = ` - Add new strategy + New strategy diff --git a/frontend/src/component/tags/EditTagType/EditTagType.tsx b/frontend/src/component/tags/EditTagType/EditTagType.tsx index cf73153ffe..59c7d0e0a1 100644 --- a/frontend/src/component/tags/EditTagType/EditTagType.tsx +++ b/frontend/src/component/tags/EditTagType/EditTagType.tsx @@ -75,7 +75,7 @@ const EditTagType = () => { clearErrors={clearErrors} > - Edit type + Save diff --git a/frontend/src/component/tags/TagTypeList/TagTypeList.jsx b/frontend/src/component/tags/TagTypeList/TagTypeList.jsx index 72bb7d8b12..e75396282d 100644 --- a/frontend/src/component/tags/TagTypeList/TagTypeList.jsx +++ b/frontend/src/component/tags/TagTypeList/TagTypeList.jsx @@ -80,7 +80,7 @@ export const TagTypeList = () => { history.push('/tag-types/create') } > - Add new tag type + New tag type } /> diff --git a/frontend/src/component/tags/TagTypeList/__tests__/__snapshots__/TagTypeList.test.js.snap b/frontend/src/component/tags/TagTypeList/__tests__/__snapshots__/TagTypeList.test.js.snap index 54f61d645e..505b5326f3 100644 --- a/frontend/src/component/tags/TagTypeList/__tests__/__snapshots__/TagTypeList.test.js.snap +++ b/frontend/src/component/tags/TagTypeList/__tests__/__snapshots__/TagTypeList.test.js.snap @@ -50,7 +50,7 @@ exports[`renders a list with elements correctly 1`] = ` - Add new tag type + New tag type - Add new tag type + New tag type From cdbf395aa226f0f8d7be59fbe73db0a1a9ec7e42 Mon Sep 17 00:00:00 2001 From: Youssef Date: Wed, 23 Feb 2022 01:29:28 +0100 Subject: [PATCH 2/5] fix: remove toast when clicking cancel --- .../src/component/addons/AddonForm/AddonForm.jsx | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/frontend/src/component/addons/AddonForm/AddonForm.jsx b/frontend/src/component/addons/AddonForm/AddonForm.jsx index d47e76c6d1..fce897feb1 100644 --- a/frontend/src/component/addons/AddonForm/AddonForm.jsx +++ b/frontend/src/component/addons/AddonForm/AddonForm.jsx @@ -1,7 +1,7 @@ -import React, { useState, useEffect } from 'react'; +import { useState, useEffect } from 'react'; import PropTypes from 'prop-types'; -import { TextField, FormControlLabel, Switch } from '@material-ui/core'; -import { FormButtons, styles as commonStyles } from '../../common'; +import { TextField, FormControlLabel, Switch, Button } from '@material-ui/core'; +import { styles as commonStyles } from '../../common'; import { trim } from '../../common/util'; import { AddonParameters } from './AddonParameters/AddonParameters'; import { AddonEvents } from './AddonEvents/AddonEvents'; @@ -149,7 +149,7 @@ export const AddonForm = ({ editMode, provider, addon, fetch }) => {

{errors.general}

-
+
{ />
- + +
From b0ba4f3a9d2364b2021b775e664f3f077e94addf Mon Sep 17 00:00:00 2001 From: Youssef Date: Wed, 23 Feb 2022 13:45:37 +0100 Subject: [PATCH 3/5] fix: remove tooltips --- .../addons/AddonList/AvailableAddons/AvailableAddons.tsx | 1 - .../AddonList/ConfiguredAddons/ConfiguredAddons.tsx | 2 -- .../ProjectRoleListItem/ProjectRoleListItem.tsx | 2 -- frontend/src/component/common/Constraint/Constraint.tsx | 2 -- .../common/PermissionButton/PermissionButton.tsx | 8 ++++---- .../common/PermissionIconButton/PermissionIconButton.tsx | 6 +++--- .../common/PermissionSwitch/PermissionSwitch.tsx | 8 ++++---- .../environments/EnvironmentList/EnvironmentList.tsx | 1 - .../FeatureOverviewEnvSwitch/FeatureOverviewEnvSwitch.tsx | 1 - .../FeatureSettingsProject/FeatureSettingsProject.tsx | 1 - frontend/src/component/project/Project/Project.tsx | 1 - .../ProjectFeatureToggles/ProjectFeatureToggles.tsx | 1 - .../component/project/Project/ProjectInfo/ProjectInfo.tsx | 1 - .../strategies/StrategiesList/StrategiesList.tsx | 4 ---- 14 files changed, 11 insertions(+), 28 deletions(-) diff --git a/frontend/src/component/addons/AddonList/AvailableAddons/AvailableAddons.tsx b/frontend/src/component/addons/AddonList/AvailableAddons/AvailableAddons.tsx index 9632b0e9e5..b9d470291a 100644 --- a/frontend/src/component/addons/AddonList/AvailableAddons/AvailableAddons.tsx +++ b/frontend/src/component/addons/AddonList/AvailableAddons/AvailableAddons.tsx @@ -44,7 +44,6 @@ export const AvailableAddons = ({ onClick={() => history.push(`/addons/create/${provider.name}`) } - tooltip={`Configure ${provider.name} Addon`} > Configure diff --git a/frontend/src/component/addons/AddonList/ConfiguredAddons/ConfiguredAddons.tsx b/frontend/src/component/addons/AddonList/ConfiguredAddons/ConfiguredAddons.tsx index 78ef5188cc..c3ee7595f2 100644 --- a/frontend/src/component/addons/AddonList/ConfiguredAddons/ConfiguredAddons.tsx +++ b/frontend/src/component/addons/AddonList/ConfiguredAddons/ConfiguredAddons.tsx @@ -122,7 +122,6 @@ export const ConfiguredAddons = ({ getAddonIcon }: IConfigureAddonsProps) => { { history.push(`/addons/edit/${addon.id}`); }} @@ -131,7 +130,6 @@ export const ConfiguredAddons = ({ getAddonIcon }: IConfigureAddonsProps) => { { setDeletedAddon(addon); setShowDelete(true); diff --git a/frontend/src/component/admin/project-roles/ProjectRoles/ProjectRoleList/ProjectRoleListItem/ProjectRoleListItem.tsx b/frontend/src/component/admin/project-roles/ProjectRoles/ProjectRoleList/ProjectRoleListItem/ProjectRoleListItem.tsx index fc32da759d..f6baeeb150 100644 --- a/frontend/src/component/admin/project-roles/ProjectRoles/ProjectRoleList/ProjectRoleListItem/ProjectRoleListItem.tsx +++ b/frontend/src/component/admin/project-roles/ProjectRoles/ProjectRoleList/ProjectRoleListItem/ProjectRoleListItem.tsx @@ -50,7 +50,6 @@ const RoleListItem = ({ { history.push(`/admin/roles/${id}/edit`); @@ -62,7 +61,6 @@ const RoleListItem = ({ { setCurrentRole({ id, name, description }); diff --git a/frontend/src/component/common/Constraint/Constraint.tsx b/frontend/src/component/common/Constraint/Constraint.tsx index 4a89e7bc1c..47092e0373 100644 --- a/frontend/src/component/common/Constraint/Constraint.tsx +++ b/frontend/src/component/common/Constraint/Constraint.tsx @@ -52,7 +52,6 @@ const Constraint = ({
@@ -61,7 +60,6 @@ const Constraint = ({ diff --git a/frontend/src/component/common/PermissionButton/PermissionButton.tsx b/frontend/src/component/common/PermissionButton/PermissionButton.tsx index 161a2ee05c..d5ead64d8c 100644 --- a/frontend/src/component/common/PermissionButton/PermissionButton.tsx +++ b/frontend/src/component/common/PermissionButton/PermissionButton.tsx @@ -16,7 +16,7 @@ export interface IPermissionIconButtonProps const PermissionButton: React.FC = ({ permission, - tooltip = 'Click to perform action', + tooltip, onClick, children, disabled, @@ -54,9 +54,9 @@ const PermissionButton: React.FC = ({ access = handleAccess(); - const tooltipText = access - ? tooltip - : "You don't have access to perform this operation"; + const tooltipText = !access + ? "You don't have access to perform this operation" + : ''; return ( diff --git a/frontend/src/component/common/PermissionIconButton/PermissionIconButton.tsx b/frontend/src/component/common/PermissionIconButton/PermissionIconButton.tsx index d987e05a94..3de4f88456 100644 --- a/frontend/src/component/common/PermissionIconButton/PermissionIconButton.tsx +++ b/frontend/src/component/common/PermissionIconButton/PermissionIconButton.tsx @@ -39,9 +39,9 @@ const PermissionIconButton: React.FC = ({ access = hasAccess(permission); } - const tooltipText = access - ? tooltip || '' - : "You don't have access to perform this operation"; + const tooltipText = !access + ? "You don't have access to perform this operation" + : ''; return ( diff --git a/frontend/src/component/common/PermissionSwitch/PermissionSwitch.tsx b/frontend/src/component/common/PermissionSwitch/PermissionSwitch.tsx index fa6f3d0da2..a9aa89e609 100644 --- a/frontend/src/component/common/PermissionSwitch/PermissionSwitch.tsx +++ b/frontend/src/component/common/PermissionSwitch/PermissionSwitch.tsx @@ -19,7 +19,7 @@ const PermissionSwitch = React.forwardRef< >((props, ref) => { const { permission, - tooltip = '', + tooltip, disabled, projectId, environmentId, @@ -39,9 +39,9 @@ const PermissionSwitch = React.forwardRef< access = hasAccess(permission); } - const tooltipText = access - ? tooltip - : "You don't have access to perform this operation"; + const tooltipText = !access + ? "You don't have access to perform this operation" + : ''; return ( diff --git a/frontend/src/component/environments/EnvironmentList/EnvironmentList.tsx b/frontend/src/component/environments/EnvironmentList/EnvironmentList.tsx index a2903ca300..83532c44f9 100644 --- a/frontend/src/component/environments/EnvironmentList/EnvironmentList.tsx +++ b/frontend/src/component/environments/EnvironmentList/EnvironmentList.tsx @@ -172,7 +172,6 @@ const EnvironmentList = () => { New Environment diff --git a/frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverviewEnvSwitches/FeatureOverviewEnvSwitch/FeatureOverviewEnvSwitch.tsx b/frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverviewEnvSwitches/FeatureOverviewEnvSwitch/FeatureOverviewEnvSwitch.tsx index 96d6a68999..dd0b11ee86 100644 --- a/frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverviewEnvSwitches/FeatureOverviewEnvSwitch/FeatureOverviewEnvSwitch.tsx +++ b/frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverviewEnvSwitches/FeatureOverviewEnvSwitch/FeatureOverviewEnvSwitch.tsx @@ -93,7 +93,6 @@ const FeatureOverviewEnvSwitch = ({ checked={env.enabled} onChange={toggleEnvironment} environmentId={env.name} - tooltip={''} /> {content}
diff --git a/frontend/src/component/feature/FeatureView/FeatureSettings/FeatureSettingsProject/FeatureSettingsProject.tsx b/frontend/src/component/feature/FeatureView/FeatureSettings/FeatureSettingsProject/FeatureSettingsProject.tsx index b33c203f1c..8aa3f3ebe0 100644 --- a/frontend/src/component/feature/FeatureView/FeatureSettings/FeatureSettingsProject/FeatureSettingsProject.tsx +++ b/frontend/src/component/feature/FeatureView/FeatureSettings/FeatureSettingsProject/FeatureSettingsProject.tsx @@ -101,7 +101,6 @@ const FeatureSettingsProject = () => { show={ setShowConfirmDialog(true)} projectId={projectId} > diff --git a/frontend/src/component/project/Project/Project.tsx b/frontend/src/component/project/Project/Project.tsx index c61f71dbe8..3c2938d843 100644 --- a/frontend/src/component/project/Project/Project.tsx +++ b/frontend/src/component/project/Project/Project.tsx @@ -125,7 +125,6 @@ const Project = () => {
{project?.name}
history.push(`/projects/${id}/edit`)} data-loading diff --git a/frontend/src/component/project/Project/ProjectFeatureToggles/ProjectFeatureToggles.tsx b/frontend/src/component/project/Project/ProjectFeatureToggles/ProjectFeatureToggles.tsx index 33e2bea70a..f15eebdef7 100644 --- a/frontend/src/component/project/Project/ProjectFeatureToggles/ProjectFeatureToggles.tsx +++ b/frontend/src/component/project/Project/ProjectFeatureToggles/ProjectFeatureToggles.tsx @@ -66,7 +66,6 @@ const ProjectFeatureToggles = ({ ) } maxWidth="700px" - tooltip="New feature toggle" Icon={Add} projectId={id} permission={CREATE_FEATURE} diff --git a/frontend/src/component/project/Project/ProjectInfo/ProjectInfo.tsx b/frontend/src/component/project/Project/ProjectInfo/ProjectInfo.tsx index f70a85174c..769b886a87 100644 --- a/frontend/src/component/project/Project/ProjectInfo/ProjectInfo.tsx +++ b/frontend/src/component/project/Project/ProjectInfo/ProjectInfo.tsx @@ -50,7 +50,6 @@ const ProjectInfo = ({ const permissionButton = ( { data-test={ADD_NEW_STRATEGY_ID} onClick={() => history.push('/strategies/create')} permission={CREATE_STRATEGY} - tooltip={'Add new strategy'} > @@ -78,7 +77,6 @@ export const StrategiesList = () => { color="primary" permission={CREATE_STRATEGY} data-test={ADD_NEW_STRATEGY_ID} - tooltip={'Add new strategy'} > New strategy @@ -163,7 +161,6 @@ export const StrategiesList = () => { onReactivateStrategy(strategy)} permission={UPDATE_STRATEGY} - tooltip={'Reactivate activation strategy'} > @@ -203,7 +200,6 @@ export const StrategiesList = () => { onDeleteStrategy(strategy)} permission={DELETE_STRATEGY} - tooltip={'Delete strategy'} > From 8c9d4c556d2ce48de98118ef514ac03cb473787a Mon Sep 17 00:00:00 2001 From: Youssef Date: Wed, 23 Feb 2022 13:51:30 +0100 Subject: [PATCH 4/5] test: update snapshots --- .../__tests__/__snapshots__/list-component-test.jsx.snap | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend/src/component/strategies/__tests__/__snapshots__/list-component-test.jsx.snap b/frontend/src/component/strategies/__tests__/__snapshots__/list-component-test.jsx.snap index 729c09e34f..073d9db764 100644 --- a/frontend/src/component/strategies/__tests__/__snapshots__/list-component-test.jsx.snap +++ b/frontend/src/component/strategies/__tests__/__snapshots__/list-component-test.jsx.snap @@ -38,7 +38,7 @@ exports[`renders correctly with one strategy 1`] = ` onMouseOver={[Function]} onTouchEnd={[Function]} onTouchStart={[Function]} - title="Add new strategy" + title="" > - +