Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

fix: add permissions to editor

Browse Source
This commit is contained in:
Fredrik Oseberg 2022-01-03 16:24:09 +01:00 committed by Ivar Conradi Østhus
parent 5ca23b80e7
commit 19f78314d1
No known key found for this signature in database
GPG Key ID: 31AC596886B0BD09
2 changed files with 267 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/migrations/20220103143843-add-permissions-to-editor-role.js Normal file
View File

@ -0,0 +1,27 @@
exports.up = function (db, cb) {
db.runSql(
`
INSERT INTO role_permission (role_id, permission_id, environment)
SELECT
(SELECT id as role_id from roles WHERE name = 'Editor' LIMIT 1),
p.id as permission_id,
e.name as environment
FROM permissions p
CROSS JOIN environments e
WHERE p.permission IN
('CREATE_FEATURE_STRATEGY',
'UPDATE_FEATURE_STRATEGY',
'DELETE_FEATURE_STRATEGY',
'UPDATE_FEATURE_ENVIRONMENT');
`,
cb,
);
};
exports.down = function (db, cb) {
db.runSql(
`
`,
cb,
);
};

246
src/test/e2e/services/access-service.e2e.test.ts
View File

@ -114,30 +114,264 @@ test('should not have admin permission', async () => {
expect(await accessService.hasPermission(user, ADMIN)).toBe(false); expect(await accessService.hasPermission(user, ADMIN)).toBe(false);
}); });
test('should have project admin to default project', async () => { test('should have project admin to default project as editor', async () => {
const projectName = 'default';
const defaultEnv = 'default';
const developmentEnv = 'development';
const productionEnv = 'production';
const { const {
DELETE_PROJECT, DELETE_PROJECT,
UPDATE_PROJECT, UPDATE_PROJECT,
CREATE_FEATURE, CREATE_FEATURE,
UPDATE_FEATURE, UPDATE_FEATURE,
DELETE_FEATURE, DELETE_FEATURE,
CREATE_FEATURE_STRATEGY,
UPDATE_FEATURE_STRATEGY,
DELETE_FEATURE_STRATEGY,
UPDATE_FEATURE_ENVIRONMENT,
} = permissions; } = permissions;
const user = editorUser; const user = editorUser;
expect( expect(
await accessService.hasPermission(user, DELETE_PROJECT, 'default'), await accessService.hasPermission(user, DELETE_PROJECT, projectName),
).toBe(true); ).toBe(true);
expect( expect(
await accessService.hasPermission(user, UPDATE_PROJECT, 'default'), await accessService.hasPermission(user, UPDATE_PROJECT, projectName),
).toBe(true); ).toBe(true);
expect( expect(
await accessService.hasPermission(user, CREATE_FEATURE, 'default'), await accessService.hasPermission(user, CREATE_FEATURE, projectName),
).toBe(true); ).toBe(true);
expect( expect(
await accessService.hasPermission(user, UPDATE_FEATURE, 'default'), await accessService.hasPermission(user, UPDATE_FEATURE, projectName),
).toBe(true); ).toBe(true);
expect( expect(
await accessService.hasPermission(user, DELETE_FEATURE, 'default'), await accessService.hasPermission(user, DELETE_FEATURE, projectName),
).toBe(true); ).toBe(true);
expect(
await accessService.hasPermission(
user,
CREATE_FEATURE_STRATEGY,
projectName,
defaultEnv,
),
).toBe(true);
expect(
await accessService.hasPermission(
user,
UPDATE_FEATURE_STRATEGY,
projectName,
defaultEnv,
),
).toBe(true);
expect(
await accessService.hasPermission(
user,
DELETE_FEATURE_STRATEGY,
projectName,
defaultEnv,
),
).toBe(true);
expect(
await accessService.hasPermission(
user,
UPDATE_FEATURE_ENVIRONMENT,
projectName,
defaultEnv,
),
).toBe(true);
expect(
await accessService.hasPermission(
user,
CREATE_FEATURE_STRATEGY,
projectName,
developmentEnv,
),
).toBe(true);
expect(
await accessService.hasPermission(
user,
UPDATE_FEATURE_STRATEGY,
projectName,
developmentEnv,
),
).toBe(true);
expect(
await accessService.hasPermission(
user,
DELETE_FEATURE_STRATEGY,
projectName,
developmentEnv,
),
).toBe(true);
expect(
await accessService.hasPermission(
user,
UPDATE_FEATURE_ENVIRONMENT,
projectName,
developmentEnv,
),
).toBe(true);
expect(
await accessService.hasPermission(
user,
CREATE_FEATURE_STRATEGY,
projectName,
productionEnv,
),
).toBe(true);
expect(
await accessService.hasPermission(
user,
UPDATE_FEATURE_STRATEGY,
projectName,
productionEnv,
),
).toBe(true);
expect(
await accessService.hasPermission(
user,
DELETE_FEATURE_STRATEGY,
projectName,
productionEnv,
),
).toBe(true);
expect(
await accessService.hasPermission(
user,
UPDATE_FEATURE_ENVIRONMENT,
projectName,
productionEnv,
),
).toBe(true);
});
test('Editor should not have project admin to other projects', async () => {
const projectName = 'unusedprojectname';
const defaultEnv = 'default';
const developmentEnv = 'development';
const productionEnv = 'production';
const {
DELETE_PROJECT,
UPDATE_PROJECT,
CREATE_FEATURE,
UPDATE_FEATURE,
DELETE_FEATURE,
CREATE_FEATURE_STRATEGY,
UPDATE_FEATURE_STRATEGY,
DELETE_FEATURE_STRATEGY,
UPDATE_FEATURE_ENVIRONMENT,
} = permissions;
const user = editorUser;
expect(
await accessService.hasPermission(user, DELETE_PROJECT, projectName),
).toBe(false);
expect(
await accessService.hasPermission(user, UPDATE_PROJECT, projectName),
).toBe(false);
expect(
await accessService.hasPermission(user, CREATE_FEATURE, projectName),
).toBe(false);
expect(
await accessService.hasPermission(user, UPDATE_FEATURE, projectName),
).toBe(false);
expect(
await accessService.hasPermission(user, DELETE_FEATURE, projectName),
).toBe(false);
expect(
await accessService.hasPermission(
user,
CREATE_FEATURE_STRATEGY,
projectName,
defaultEnv,
),
).toBe(false);
expect(
await accessService.hasPermission(
user,
UPDATE_FEATURE_STRATEGY,
projectName,
defaultEnv,
),
).toBe(false);
expect(
await accessService.hasPermission(
user,
DELETE_FEATURE_STRATEGY,
projectName,
defaultEnv,
),
).toBe(false);
expect(
await accessService.hasPermission(
user,
UPDATE_FEATURE_ENVIRONMENT,
projectName,
defaultEnv,
),
).toBe(false);
expect(
await accessService.hasPermission(
user,
CREATE_FEATURE_STRATEGY,
projectName,
developmentEnv,
),
).toBe(false);
expect(
await accessService.hasPermission(
user,
UPDATE_FEATURE_STRATEGY,
projectName,
developmentEnv,
),
).toBe(false);
expect(
await accessService.hasPermission(
user,
DELETE_FEATURE_STRATEGY,
projectName,
developmentEnv,
),
).toBe(false);
expect(
await accessService.hasPermission(
user,
UPDATE_FEATURE_ENVIRONMENT,
projectName,
developmentEnv,
),
).toBe(false);
expect(
await accessService.hasPermission(
user,
CREATE_FEATURE_STRATEGY,
projectName,
productionEnv,
),
).toBe(false);
expect(
await accessService.hasPermission(
user,
UPDATE_FEATURE_STRATEGY,
projectName,
productionEnv,
),
).toBe(false);
expect(
await accessService.hasPermission(
user,
DELETE_FEATURE_STRATEGY,
projectName,
productionEnv,
),
).toBe(false);
expect(
await accessService.hasPermission(
user,
UPDATE_FEATURE_ENVIRONMENT,
projectName,
productionEnv,
),
).toBe(false);
}); });
test('cannot add CREATE_FEATURE without defining project', async () => { test('cannot add CREATE_FEATURE without defining project', async () => {