From 19f97a388e72b717fe17b966a8e598fe4ef219fd Mon Sep 17 00:00:00 2001
From: olav <mail@olav.io>
Date: Fri, 27 May 2022 10:04:26 +0200
Subject: [PATCH] fix: avoid direct mutation of setState return value (#1034)

---
 .../component/addons/AddonForm/AddonForm.tsx  | 21 ++++++++++++-------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/frontend/src/component/addons/AddonForm/AddonForm.tsx b/frontend/src/component/addons/AddonForm/AddonForm.tsx
index fab9f48166..3fe0123605 100644
--- a/frontend/src/component/addons/AddonForm/AddonForm.tsx
+++ b/frontend/src/component/addons/AddonForm/AddonForm.tsx
@@ -108,14 +108,19 @@ export const AddonForm: VFC<IAddonFormProps> = ({
 
     const setEventValue =
         (name: string) => (event: ChangeEvent<HTMLInputElement>) => {
-            const newConfig = { ...formValues };
-            if (event.target.checked) {
-                newConfig.events.push(name);
-            } else {
-                newConfig.events = newConfig.events.filter(e => e !== name);
-            }
-            setFormValues(newConfig);
-            setErrors({ ...errors, events: undefined });
+            setFormValues(
+                produce(draft => {
+                    if (event.target.checked) {
+                        draft.events.push(name);
+                    } else {
+                        draft.events = draft.events.filter(e => e !== name);
+                    }
+                })
+            );
+            setErrors(prev => ({
+                ...prev,
+                events: undefined,
+            }));
         };
 
     const onCancel = () => {