Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-06-04 01:18:20 +02:00
Code Issues Projects Releases Wiki Activity

fix: demo topics should work with new flag design (#9765)

Browse Source 
https://linear.app/unleash/issue/2-3512/bug-flow-2-enable-for-a-specific-user-doesnt-work

https://linear.app/unleash/issue/2-3513/bug-flow-4-adjust-variants-doesnt-work

Fixes our demo topics by making them work with the new flag page design.

We achieve this by adding 2 new interactive steps in `demoApp.step2` and
`demoApp.step4` to expand the respective environment accordions. We mark
them as optional so they are not strictly required and will be skipped
if not found. This means the demo will be resilient to rolling back the
`flagOverviewRedesign` flag, for example.

We also mark 2 steps as optional: saving constraints in `demoApp.step2`
and `demoApp.step4`. It seems like we no longer have an extra button to
save the constraints after adding them, so by marking these steps as
optional the demo flow is able to proceed without breaking.
This commit is contained in:
Nuno Góis 2025-04-15 16:18:33 +01:00 committed by GitHub
parent 713c5560a8
commit 1d94c261e6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
frontend/src/component/demo/demo-topics.tsx
View File

@ -129,6 +129,17 @@ export const TOPICS: ITutorialTopic[] = [
),
preventDefault: true,
},
{
href: `/projects/${PROJECT}/features/demoApp.step2`,
target: `div[data-testid="FEATURE_ENVIRONMENT_ACCORDION_${ENVIRONMENT}"] .MuiAccordionSummary-expandIconWrapper`,
content: (
<Description>
Expand the environment card to see all the defined
strategies by using the arrow button.
</Description>
),
optional: true,
},
{
href: `/projects/${PROJECT}/features/demoApp.step2`,
target: 'button[data-testid="ADD_STRATEGY_BUTTON"]',
@ -264,6 +275,7 @@ export const TOPICS: ITutorialTopic[] = [
Save the constraint by using this button.
</Description>
),
optional: true,
},
{
target: 'button[data-testid="STRATEGY_FORM_SUBMIT_ID"]',
@ -467,6 +479,17 @@ export const TOPICS: ITutorialTopic[] = [
),
preventDefault: true,
},
{
href: `/projects/${PROJECT}/features/demoApp.step4`,
target: `div[data-testid="FEATURE_ENVIRONMENT_ACCORDION_${ENVIRONMENT}"] .MuiAccordionSummary-expandIconWrapper`,
content: (
<Description>
Expand the environment card to see all the defined
strategies by using the arrow button.
</Description>
),
optional: true,
},
{
href: `/projects/${PROJECT}/features/demoApp.step4`,
target: 'button[data-testid="ADD_STRATEGY_BUTTON"]',
@ -602,6 +625,7 @@ export const TOPICS: ITutorialTopic[] = [
Save the constraint by using this button.
</Description>
),
optional: true,
},
{
target: 'button[data-testid="STRATEGY_VARIANTS_TAB"]',