Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-06-04 01:18:20 +02:00
Code Issues Projects Releases Wiki Activity

feat: adjust filter UI (#9720)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2025-04-08 14:32:30 +02:00 committed by GitHub
parent f8e75e5250
commit 1e027dcf4f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.test.tsx
View File

@ -76,14 +76,14 @@ const setupApi = (features: APIFeature[], projects: APIProject[]) => {
const verifyTableFeature = async (feature: Partial<UIFeature>) => { const verifyTableFeature = async (feature: Partial<UIFeature>) => {
await screen.findByText('Search'); await screen.findByText('Search');
await screen.findByText('Add Filter'); await screen.findByText('Filter');
await Promise.all( await Promise.all(
Object.values(feature).map((value) => screen.findByText(value)), Object.values(feature).map((value) => screen.findByText(value)),
); );
}; };
const filterFeaturesByProject = async (projectName: string) => { const filterFeaturesByProject = async (projectName: string) => {
const addFilterButton = screen.getByText('Add Filter'); const addFilterButton = screen.getByText('Filter');
addFilterButton.click(); addFilterButton.click();
const projectItem = await screen.findByText('Project'); const projectItem = await screen.findByText('Project');

13
frontend/src/component/filter/AddFilterButton.tsx
View File

@ -4,7 +4,7 @@ import Button from '@mui/material/Button';
import Menu from '@mui/material/Menu'; import Menu from '@mui/material/Menu';
import MenuItem from '@mui/material/MenuItem'; import MenuItem from '@mui/material/MenuItem';
import { Icon, styled } from '@mui/material'; import { Icon, styled } from '@mui/material';
import Add from '@mui/icons-material/Add'; import FilterList from '@mui/icons-material/FilterList';
import { Box } from '@mui/system'; import { Box } from '@mui/system';
import type { IFilterItem } from './Filters/Filters'; import type { IFilterItem } from './Filters/Filters';
import { FILTERS_MENU } from 'utils/testIds'; import { FILTERS_MENU } from 'utils/testIds';
@ -117,13 +117,16 @@ export const AddFilterButton = ({
describeChild describeChild
open={archiveTooltipOpen} open={archiveTooltipOpen}
> >
<StyledButton onClick={handleClick} startIcon={<Add />}> <StyledButton
Add Filter onClick={handleClick}
startIcon={<FilterList />}
>
Filter
</StyledButton> </StyledButton>
</StyledHtmlTooltip> </StyledHtmlTooltip>
) : ( ) : (
<StyledButton onClick={handleClick} startIcon={<Add />}> <StyledButton onClick={handleClick} startIcon={<FilterList />}>
Add Filter Filter
</StyledButton> </StyledButton>
)} )}

2
frontend/src/component/filter/Filters/Filters.test.tsx
View File

@ -120,7 +120,7 @@ test('should remove selected item from the add filter list', async () => {
); );
// initial selection list // initial selection list
const addFilterButton = await screen.findByText('Add Filter'); const addFilterButton = await screen.findByText('Filter');
fireEvent.click(addFilterButton); fireEvent.click(addFilterButton);
expect((await screen.findByTestId(FILTERS_MENU)).textContent).toBe( expect((await screen.findByTestId(FILTERS_MENU)).textContent).toBe(
'StateTags', 'StateTags',

2
frontend/src/component/insights/Insights.test.tsx
View File

@ -31,7 +31,7 @@ test('Filter insights by project and date', async () => {
vi.setSystemTime(currentTime); vi.setSystemTime(currentTime);
setupApi(); setupApi();
render(<Insights withCharts={false} />); render(<Insights withCharts={false} />);
const addFilter = await screen.findByText('Add Filter'); const addFilter = await screen.findByText('Filter');
fireEvent.click(addFilter); fireEvent.click(addFilter);
const projectFilter = await screen.findByText('Project'); const projectFilter = await screen.findByText('Project');

2
frontend/src/component/project/Project/PaginatedProjectFeatureToggles/ProjectFeatureToggles.test.tsx
View File

@ -150,7 +150,7 @@ test('filters by flag author', async () => {
route: '/projects/default', route: '/projects/default',
}, },
); );
const addFilter = await screen.findByText('Add Filter'); const addFilter = await screen.findByText('Filter');
fireEvent.click(addFilter); fireEvent.click(addFilter);
const createdBy = await screen.findByText('Created by'); const createdBy = await screen.findByText('Created by');