chore: remove configurableFeatureTypeLifetimes flag (#4569)

frontend/src/component/menu/__tests__/__snapshots__/routes.test.tsx.snap

@@ -195,7 +195,6 @@ exports[`returns all baseRoutes 1`] = `
   },
   {
     "component": [Function],
-    "flag": "configurableFeatureTypeLifetimes",
     "menu": {
       "advanced": true,
       "mobile": true,

frontend/src/component/menu/routes.ts

@@ -216,7 +216,6 @@ export const routes: IRoute[] = [
         component: FeatureTypesList,
         type: 'protected',
         menu: { mobile: true, advanced: true },
-        flag: 'configurableFeatureTypeLifetimes',
     },
 
     // Strategies

frontend/src/interfaces/uiConfig.ts

@@ -52,7 +52,6 @@ export interface IFlags {
     advancedPlayground?: boolean;
     customRootRolesKillSwitch?: boolean;
     strategyVariant?: boolean;
-    configurableFeatureTypeLifetimes?: boolean;
     segmentChangeRequests?: boolean;
     changeRequestReject?: boolean;
     lastSeenByEnvironment?: boolean;

src/lib/__snapshots__/create-config.test.ts.snap

@@ -71,7 +71,6 @@ exports[`should create default config 1`] = `
       "anonymiseEventLog": false,
       "caseInsensitiveInOperators": false,
       "changeRequestReject": false,
-      "configurableFeatureTypeLifetimes": false,
       "customRootRolesKillSwitch": false,
       "demo": false,
       "disableBulkToggle": false,
@@ -107,7 +106,6 @@ exports[`should create default config 1`] = `
       "anonymiseEventLog": false,
       "caseInsensitiveInOperators": false,
       "changeRequestReject": false,
-      "configurableFeatureTypeLifetimes": false,
       "customRootRolesKillSwitch": false,
       "demo": false,
       "disableBulkToggle": false,

src/lib/routes/admin-api/feature-type.ts

@@ -113,20 +113,16 @@ When a feature toggle type's expected lifetime is changed, this will also cause
         >,
         res: Response<FeatureTypeSchema>,
     ): Promise<void> {
-        if (this.flagResolver.isEnabled('configurableFeatureTypeLifetimes')) {
-            const result = await this.featureTypeService.updateLifetime(
-                req.params.id.toLowerCase(),
-                req.body.lifetimeDays,
-            );
+        const result = await this.featureTypeService.updateLifetime(
+            req.params.id.toLowerCase(),
+            req.body.lifetimeDays,
+        );
 
-            this.openApiService.respondWithValidation(
-                200,
-                res,
-                featureTypeSchema.$id,
-                result,
-            );
-        } else {
-            res.status(409).end();
-        }
+        this.openApiService.respondWithValidation(
+            200,
+            res,
+            featureTypeSchema.$id,
+            result,
+        );
     }
 }

src/lib/types/experimental.ts

@@ -22,7 +22,6 @@ export type IFlagKey =
     | 'advancedPlayground'
     | 'strategyVariant'
     | 'slackAppAddon'
-    | 'configurableFeatureTypeLifetimes'
     | 'filterInvalidClientMetrics'
     | 'lastSeenByEnvironment'
     | 'segmentChangeRequests'
@@ -105,10 +104,6 @@ const flags: IFlags = {
         process.env.UNLEASH_SLACK_APP_ADDON,
         false,
     ),
-    configurableFeatureTypeLifetimes: parseEnvVarBoolean(
-        process.env.UNLEASH_EXPERIMENTAL_CONFIGURABLE_FEATURE_TYPE_LIFETIMES,
-        false,
-    ),
     filterInvalidClientMetrics: parseEnvVarBoolean(
         process.env.FILTER_INVALID_CLIENT_METRICS,
         false,

src/server-dev.ts

@@ -39,7 +39,6 @@ process.nextTick(async () => {
                         responseTimeWithAppNameKillSwitch: false,
                         strategyVariant: true,
                         slackAppAddon: true,
-                        configurableFeatureTypeLifetimes: true,
                         lastSeenByEnvironment: true,
                         segmentChangeRequests: true,
                         newApplicationList: true,

src/test/e2e/api/admin/feature-type.test.ts

@@ -12,7 +12,6 @@ beforeAll(async () => {
     app = await setupAppWithCustomConfig(db.stores, {
         experimental: {
             flags: {
-                configurableFeatureTypeLifetimes: true,
                 strictSchemaValidation: true,
             },
         },