Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-07-12 13:48:35 +02:00
Code Issues Projects Releases Wiki Activity

chore: remove configurableFeatureTypeLifetimes flag (#4569)

Browse Source
This commit is contained in:
Jaanus Sellin 2023-08-25 10:19:08 +03:00 committed by GitHub
parent 3ebeea4d64
commit 1f96c1646c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 10 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
frontend/src/component/menu/__tests__/__snapshots__/routes.test.tsx.snap
View File

@ -195,7 +195,6 @@ exports[`returns all baseRoutes 1`] = `
}, },
{ {
"component": [Function], "component": [Function],
"flag": "configurableFeatureTypeLifetimes",
"menu": { "menu": {
"advanced": true, "advanced": true,
"mobile": true, "mobile": true,

1
frontend/src/component/menu/routes.ts
View File

@ -216,7 +216,6 @@ export const routes: IRoute[] = [
component: FeatureTypesList, component: FeatureTypesList,
type: 'protected', type: 'protected',
menu: { mobile: true, advanced: true }, menu: { mobile: true, advanced: true },
flag: 'configurableFeatureTypeLifetimes',
}, },
// Strategies // Strategies

1
frontend/src/interfaces/uiConfig.ts
View File

@ -52,7 +52,6 @@ export interface IFlags {
advancedPlayground?: boolean; advancedPlayground?: boolean;
customRootRolesKillSwitch?: boolean; customRootRolesKillSwitch?: boolean;
strategyVariant?: boolean; strategyVariant?: boolean;
configurableFeatureTypeLifetimes?: boolean;
segmentChangeRequests?: boolean; segmentChangeRequests?: boolean;
changeRequestReject?: boolean; changeRequestReject?: boolean;
lastSeenByEnvironment?: boolean; lastSeenByEnvironment?: boolean;

2
src/lib/__snapshots__/create-config.test.ts.snap
View File

@ -71,7 +71,6 @@ exports[`should create default config 1`] = `
"anonymiseEventLog": false, "anonymiseEventLog": false,
"caseInsensitiveInOperators": false, "caseInsensitiveInOperators": false,
"changeRequestReject": false, "changeRequestReject": false,
"configurableFeatureTypeLifetimes": false,
"customRootRolesKillSwitch": false, "customRootRolesKillSwitch": false,
"demo": false, "demo": false,
"disableBulkToggle": false, "disableBulkToggle": false,
@ -107,7 +106,6 @@ exports[`should create default config 1`] = `
"anonymiseEventLog": false, "anonymiseEventLog": false,
"caseInsensitiveInOperators": false, "caseInsensitiveInOperators": false,
"changeRequestReject": false, "changeRequestReject": false,
"configurableFeatureTypeLifetimes": false,
"customRootRolesKillSwitch": false, "customRootRolesKillSwitch": false,
"demo": false, "demo": false,
"disableBulkToggle": false, "disableBulkToggle": false,

24
src/lib/routes/admin-api/feature-type.ts
View File

@ -113,20 +113,16 @@ When a feature toggle type's expected lifetime is changed, this will also cause
>, >,
res: Response<FeatureTypeSchema>, res: Response<FeatureTypeSchema>,
): Promise<void> { ): Promise<void> {
if (this.flagResolver.isEnabled('configurableFeatureTypeLifetimes')) { const result = await this.featureTypeService.updateLifetime(
const result = await this.featureTypeService.updateLifetime( req.params.id.toLowerCase(),
req.params.id.toLowerCase(), req.body.lifetimeDays,
req.body.lifetimeDays, );
);
this.openApiService.respondWithValidation( this.openApiService.respondWithValidation(
200, 200,
res, res,
featureTypeSchema.$id, featureTypeSchema.$id,
result, result,
); );
} else {
res.status(409).end();
}
} }
} }

5
src/lib/types/experimental.ts
View File

@ -22,7 +22,6 @@ export type IFlagKey =
| 'advancedPlayground' | 'advancedPlayground'
| 'strategyVariant' | 'strategyVariant'
| 'slackAppAddon' | 'slackAppAddon'
| 'configurableFeatureTypeLifetimes'
| 'filterInvalidClientMetrics' | 'filterInvalidClientMetrics'
| 'lastSeenByEnvironment' | 'lastSeenByEnvironment'
| 'segmentChangeRequests' | 'segmentChangeRequests'
@ -105,10 +104,6 @@ const flags: IFlags = {
process.env.UNLEASH_SLACK_APP_ADDON, process.env.UNLEASH_SLACK_APP_ADDON,
false, false,
), ),
configurableFeatureTypeLifetimes: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_CONFIGURABLE_FEATURE_TYPE_LIFETIMES,
false,
),
filterInvalidClientMetrics: parseEnvVarBoolean( filterInvalidClientMetrics: parseEnvVarBoolean(
process.env.FILTER_INVALID_CLIENT_METRICS, process.env.FILTER_INVALID_CLIENT_METRICS,
false, false,

1
src/server-dev.ts
View File

@ -39,7 +39,6 @@ process.nextTick(async () => {
responseTimeWithAppNameKillSwitch: false, responseTimeWithAppNameKillSwitch: false,
strategyVariant: true, strategyVariant: true,
slackAppAddon: true, slackAppAddon: true,
configurableFeatureTypeLifetimes: true,
lastSeenByEnvironment: true, lastSeenByEnvironment: true,
segmentChangeRequests: true, segmentChangeRequests: true,
newApplicationList: true, newApplicationList: true,

1
src/test/e2e/api/admin/feature-type.test.ts
View File

@ -12,7 +12,6 @@ beforeAll(async () => {
app = await setupAppWithCustomConfig(db.stores, { app = await setupAppWithCustomConfig(db.stores, {
experimental: { experimental: {
flags: { flags: {
configurableFeatureTypeLifetimes: true,
strictSchemaValidation: true, strictSchemaValidation: true,
}, },
}, },