Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-05 17:53:12 +02:00
Code Issues Projects Releases Wiki Activity

chore: create new flag to hide insights ui (#6638)

Browse Source 
Creates a new flag to control the executive dashboard ui

Closes #
[1-2208](https://linear.app/unleash/issue/1-2208/create-separate-ui-flag-decoupled-from-the-backend-flag)

---------

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

(cherry picked from commit 84707e2bf3)
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
This commit is contained in:
andreas-unleash 2024-03-20 17:21:46 +02:00
parent d11fd4dbe1
commit 1f98b17bb7
No known key found for this signature in database
GPG Key ID: 86EF87A739B39099
7 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/component/menu/Header/Header.tsx
View File

@ -166,7 +166,7 @@ const Header: VFC = () => {
const increaseUnleashWidth = useUiFlag('increaseUnleashWidth'); const increaseUnleashWidth = useUiFlag('increaseUnleashWidth');
const celebatoryUnleash = useUiFlag('celebrateUnleash'); const celebatoryUnleash = useUiFlag('celebrateUnleash');
const insightsDashboard = useUiFlag('executiveDashboard'); const insightsDashboard = useUiFlag('executiveDashboardUI');
const routes = getRoutes(); const routes = getRoutes();
const adminRoutes = useAdminRoutes(); const adminRoutes = useAdminRoutes();

2
frontend/src/component/menu/__tests__/__snapshots__/routes.test.tsx.snap
View File

@ -13,7 +13,7 @@ exports[`returns all baseRoutes 1`] = `
{ {
"component": [Function], "component": [Function],
"enterprise": false, "enterprise": false,
"flag": "executiveDashboard", "flag": "executiveDashboardUI",
"menu": { "menu": {
"advanced": true, "advanced": true,
"mobile": true, "mobile": true,

4
frontend/src/component/menu/routes.ts
View File

@ -66,8 +66,8 @@ export const routes: IRoute[] = [
title: 'Insights', title: 'Insights',
component: ExecutiveDashboard, component: ExecutiveDashboard,
type: 'protected', type: 'protected',
menu: { mobile: true, advanced: true }, menu: { mobile: true },
flag: 'executiveDashboard', flag: 'executiveDashboardUI',
enterprise: false, enterprise: false,
}, },

2
frontend/src/interfaces/uiConfig.ts
View File

@ -72,7 +72,7 @@ export type UiFlags = {
newStrategyConfigurationFeedback?: boolean; newStrategyConfigurationFeedback?: boolean;
extendedUsageMetricsUI?: boolean; extendedUsageMetricsUI?: boolean;
adminTokenKillSwitch?: boolean; adminTokenKillSwitch?: boolean;
executiveDashboard?: boolean; executiveDashboardUI?: boolean;
feedbackComments?: Variant; feedbackComments?: Variant;
displayUpgradeEdgeBanner?: boolean; displayUpgradeEdgeBanner?: boolean;
showInactiveUsers?: boolean; showInactiveUsers?: boolean;

1
src/lib/__snapshots__/create-config.test.ts.snap
View File

@ -94,6 +94,7 @@ exports[`should create default config 1`] = `
"enableLicenseChecker": false, "enableLicenseChecker": false,
"encryptEmails": false, "encryptEmails": false,
"executiveDashboard": false, "executiveDashboard": false,
"executiveDashboardUI": false,
"extendedUsageMetrics": false, "extendedUsageMetrics": false,
"extendedUsageMetricsUI": false, "extendedUsageMetricsUI": false,
"featureSearchFeedback": { "featureSearchFeedback": {

5
src/lib/types/experimental.ts
View File

@ -40,6 +40,7 @@ export type IFlagKey =
| 'extendedUsageMetricsUI' | 'extendedUsageMetricsUI'
| 'adminTokenKillSwitch' | 'adminTokenKillSwitch'
| 'executiveDashboard' | 'executiveDashboard'
| 'executiveDashboardUI'
| 'feedbackComments' | 'feedbackComments'
| 'createdByUserIdDataMigration' | 'createdByUserIdDataMigration'
| 'showInactiveUsers' | 'showInactiveUsers'
@ -197,6 +198,10 @@ const flags: IFlags = {
process.env.UNLEASH_EXPERIMENTAL_EXECUTIVE_DASHBOARD, process.env.UNLEASH_EXPERIMENTAL_EXECUTIVE_DASHBOARD,
false, false,
), ),
executiveDashboardUI: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_EXECUTIVE_DASHBOARD_UI,
false,
),
sdkReporting: parseEnvVarBoolean( sdkReporting: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_SDK_REPORTING, process.env.UNLEASH_EXPERIMENTAL_SDK_REPORTING,
false, false,

1
src/server-dev.ts
View File

@ -48,6 +48,7 @@ process.nextTick(async () => {
featureSearchFeedbackPosting: true, featureSearchFeedbackPosting: true,
extendedUsageMetricsUI: true, extendedUsageMetricsUI: true,
executiveDashboard: true, executiveDashboard: true,
executiveDashboardUI: true,
userAccessUIEnabled: true, userAccessUIEnabled: true,
sdkReporting: true, sdkReporting: true,
}, },