Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-25 00:07:47 +01:00
Code Issues Projects Releases Wiki Activity

chore: make login history GA (remove flag) (#3604)

Browse Source 
https://linear.app/unleash/issue/2-956/remove-loginhistory-feature-flag

Promotes [login
history](https://docs.getunleash.io/reference/login-history) to GA by
removing the `loginHistory` feature flag.
This commit is contained in:
Nuno Góis 2023-04-24 12:37:13 +01:00 committed by GitHub
parent 0141e2bec6
commit 2129736ca6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
frontend/src/component/menu/routes.ts
View File

@ -451,7 +451,6 @@ export const adminMenuRoutes: INavigationMenuItem[] = [
path: '/admin/logins',
title: 'Login history',
menu: { adminSettings: true, mode: ['enterprise'] },
flag: 'loginHistory',
},
{
path: '/admin/users',

6
frontend/src/hooks/api/getters/useLoginHistory/useLoginHistory.ts
View File

@ -6,12 +6,10 @@ import { useConditionalSWR } from '../useConditionalSWR/useConditionalSWR';
import useUiConfig from '../useUiConfig/useUiConfig';
export const useLoginHistory = () => {
const { uiConfig, isEnterprise } = useUiConfig();
const { loginHistory } = uiConfig.flags;
const { isEnterprise } = useUiConfig();
const { data, error, mutate } = useConditionalSWR(
loginHistory && isEnterprise(),
isEnterprise(),
{ events: [] },
formatApiPath(`api/admin/logins`),
fetcher

1
frontend/src/interfaces/uiConfig.ts
View File

@ -46,7 +46,6 @@ export interface IFlags {
crOnVariants?: boolean;
proPlanAutoCharge?: boolean;
notifications?: boolean;
loginHistory?: boolean;
bulkOperations?: boolean;
projectScopedStickiness?: boolean;
personalAccessTokensKillSwitch?: boolean;

2
src/lib/__snapshots__/create-config.test.ts.snap
View File

@ -77,7 +77,6 @@ exports[`should create default config 1`] = `
"embedProxyFrontend": true,
"featuresExportImport": true,
"groupRootRoles": false,
"loginHistory": false,
"maintenanceMode": false,
"messageBanner": false,
"migrationLock": false,
@ -105,7 +104,6 @@ exports[`should create default config 1`] = `
"embedProxyFrontend": true,
"featuresExportImport": true,
"groupRootRoles": false,
"loginHistory": false,
"maintenanceMode": false,
"messageBanner": false,
"migrationLock": false,

1
src/lib/types/experimental.ts
View File

@ -50,7 +50,6 @@ const flags = {
process.env.UNLEASH_PRO_PLAN_AUTO_CHARGE,
false,
),
loginHistory: parseEnvVarBoolean(process.env.UNLEASH_LOGIN_HISTORY, false),
bulkOperations: parseEnvVarBoolean(
process.env.UNLEASH_BULK_OPERATIONS,
false,