From 2185742b1d8df997c8c9b4ac62cef61db97a56c0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ivar=20Conradi=20=C3=98sthus?= <ivar@getunleash.io>
Date: Wed, 6 Mar 2024 09:03:50 +0100
Subject: [PATCH] fix: clone feature toggle should not copy createdAt (#6442)

This is a small fix to avoid that cloning a feature toggle also clones
the "createdAt" field, which does not make sense.

fixes: #6426
---
 .../feature-toggle/feature-toggle-service.ts  |  1 +
 .../tests/feature-toggles.e2e.test.ts         | 36 +++++++++++++++++++
 2 files changed, 37 insertions(+)

diff --git a/src/lib/features/feature-toggle/feature-toggle-service.ts b/src/lib/features/feature-toggle/feature-toggle-service.ts
index 215c135b57..c5b6f0a750 100644
--- a/src/lib/features/feature-toggle/feature-toggle-service.ts
+++ b/src/lib/features/feature-toggle/feature-toggle-service.ts
@@ -1324,6 +1324,7 @@ class FeatureToggleService {
             ...cToggle,
             name: newFeatureName,
             variants: undefined,
+            createdAt: undefined,
         };
         const created = await this.createFeatureToggle(
             projectId,
diff --git a/src/lib/features/feature-toggle/tests/feature-toggles.e2e.test.ts b/src/lib/features/feature-toggle/tests/feature-toggles.e2e.test.ts
index 69a6c6fc73..84b68d0477 100644
--- a/src/lib/features/feature-toggle/tests/feature-toggles.e2e.test.ts
+++ b/src/lib/features/feature-toggle/tests/feature-toggles.e2e.test.ts
@@ -2191,6 +2191,42 @@ test('should clone feature toggle without replacing groupId', async () => {
         });
 });
 
+test('should clone feature toggle WITHOUT createdAt field', async () => {
+    const featureName = 'feature.toggle.base.5';
+    const cloneName = 'feature.toggle.clone.5';
+    const type = 'eExperiment';
+    const description = 'Lorem ipsum...';
+    const originalCreatedAt = new Date(2011, 11, 11);
+
+    await app.request
+        .post('/api/admin/projects/default/features')
+        .send({
+            name: featureName,
+            description,
+            type,
+            createdAt: originalCreatedAt,
+        })
+        .expect(201);
+
+    await app.request
+        .post(`/api/admin/projects/default/features/${featureName}/clone`)
+        .send({ name: cloneName })
+        .expect(201);
+    await app.request
+        .get(`/api/admin/projects/default/features/${cloneName}`)
+        .expect(200)
+        .expect((res) => {
+            expect(res.body.name).toBe(cloneName);
+            expect(res.body.type).toBe(type);
+            expect(res.body.project).toBe('default');
+            expect(res.body.description).toBe(description);
+            expect(new Date(res.body.createdAt).getFullYear()).toBe(
+                new Date().getFullYear(),
+            );
+            expect(res.body.createdAt).not.toBe('2011-12-11T00:00:00.000Z');
+        });
+});
+
 test('Should not allow changing project to target project without the same enabled environments', async () => {
     const envNameNotInBoth = 'not-in-both';
     const featureName = 'feature.dont.allow.change.project';