mirror of
https://github.com/Unleash/unleash.git
synced 2025-02-23 00:22:19 +01:00
chore: unify build and build PRs workflow (#5570)
## About the changes Our build and build_prs workflows are almost the same with some minor details: 1. **Build** also builds the frontend, but **PR Build** does not by specifying `--ignore-scripts` 1. **Build PR** uploads test results: Upload test report to build. We'll ignore this when building on main 1. **Build PR** just builds the backend (reason why the build is much faster: 50s vs ~5m). We have a workflow for building frontend PRs, we'd be removing the build frontend from the build on main, but we're already exercising that to upload to dockerhub:  These are the main differences:  This PR unifies the two workflows into one
This commit is contained in:
parent
7be0c55d39
commit
218d5625fb
18
.github/workflows/build.yaml
vendored
18
.github/workflows/build.yaml
vendored
@ -1,4 +1,4 @@
|
|||||||
name: Build & Tests
|
name: Build, Lint & Tests
|
||||||
|
|
||||||
on:
|
on:
|
||||||
push:
|
push:
|
||||||
@ -7,7 +7,11 @@ on:
|
|||||||
paths-ignore:
|
paths-ignore:
|
||||||
- website/**
|
- website/**
|
||||||
- coverage/**
|
- coverage/**
|
||||||
|
pull_request:
|
||||||
|
paths-ignore:
|
||||||
|
- frontend/**
|
||||||
|
- website/**
|
||||||
|
- coverage/**
|
||||||
jobs:
|
jobs:
|
||||||
build:
|
build:
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
@ -39,11 +43,17 @@ jobs:
|
|||||||
with:
|
with:
|
||||||
node-version: ${{ matrix.node-version }}
|
node-version: ${{ matrix.node-version }}
|
||||||
cache: 'yarn'
|
cache: 'yarn'
|
||||||
- run: yarn
|
- run: yarn install --frozen-lockfile --ignore-scripts
|
||||||
- run: yarn build:frontend:if-needed
|
|
||||||
- run: yarn lint
|
- run: yarn lint
|
||||||
|
- run: yarn build:backend
|
||||||
- run: yarn run test:report # This adds test results as github check to the workflow
|
- run: yarn run test:report # This adds test results as github check to the workflow
|
||||||
env:
|
env:
|
||||||
CI: true
|
CI: true
|
||||||
TEST_DATABASE_URL: postgres://postgres:postgres@localhost:5432/postgres
|
TEST_DATABASE_URL: postgres://postgres:postgres@localhost:5432/postgres
|
||||||
DATABASE_URL: postgres://postgres:postgres@localhost:5432/postgres
|
DATABASE_URL: postgres://postgres:postgres@localhost:5432/postgres
|
||||||
|
- name: Upload test report to build # Done this way since external PRs would not be able to write the check. See https://github.com/marketplace/actions/test-reporter#recommended-setup-for-public-repositories
|
||||||
|
uses: actions/upload-artifact@v3
|
||||||
|
if: (success() || failure()) && github.ref == 'refs/heads/main'
|
||||||
|
with:
|
||||||
|
name: test-results
|
||||||
|
path: ./reports/jest-junit.xml
|
51
.github/workflows/build_prs.yaml
vendored
51
.github/workflows/build_prs.yaml
vendored
@ -1,51 +0,0 @@
|
|||||||
name: PR -> Build & Lint
|
|
||||||
|
|
||||||
on:
|
|
||||||
pull_request:
|
|
||||||
paths-ignore:
|
|
||||||
- frontend/**
|
|
||||||
- website/**
|
|
||||||
- coverage/**
|
|
||||||
|
|
||||||
jobs:
|
|
||||||
build:
|
|
||||||
runs-on: ubuntu-latest
|
|
||||||
services:
|
|
||||||
# Label used to access the service container
|
|
||||||
postgres:
|
|
||||||
# Docker Hub image
|
|
||||||
image: postgres
|
|
||||||
# Provide the password for postgres
|
|
||||||
env:
|
|
||||||
POSTGRES_PASSWORD: postgres
|
|
||||||
POSTGRES_INITDB_ARGS: "--no-sync"
|
|
||||||
# Set health checks to wait until postgres has started
|
|
||||||
ports:
|
|
||||||
- 5432:5432
|
|
||||||
options: >-
|
|
||||||
--health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
|
|
||||||
|
|
||||||
strategy:
|
|
||||||
matrix:
|
|
||||||
node-version: [18.x]
|
|
||||||
steps:
|
|
||||||
- uses: actions/checkout@v4
|
|
||||||
- name: Use Node.js ${{ matrix.node-version }}
|
|
||||||
uses: actions/setup-node@v3
|
|
||||||
with:
|
|
||||||
node-version: 18.x
|
|
||||||
cache: 'yarn'
|
|
||||||
- run: yarn install --frozen-lockfile --ignore-scripts
|
|
||||||
- run: yarn lint
|
|
||||||
- run: yarn build:backend
|
|
||||||
- run: yarn test:report
|
|
||||||
env:
|
|
||||||
CI: true
|
|
||||||
TEST_DATABASE_URL: postgres://postgres:postgres@localhost:5432/postgres
|
|
||||||
DATABASE_URL: postgres://postgres:postgres@localhost:5432/postgres
|
|
||||||
- name: Upload test report to build # Done this way since external PRs would not be able to write the check. See https://github.com/marketplace/actions/test-reporter#recommended-setup-for-public-repositories
|
|
||||||
uses: actions/upload-artifact@v3
|
|
||||||
if: success() || failure()
|
|
||||||
with:
|
|
||||||
name: test-results
|
|
||||||
path: ./reports/jest-junit.xml
|
|
Loading…
Reference in New Issue
Block a user