Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-03-04 00:18:40 +01:00
Code Issues Projects Releases Wiki Activity

fix($env): fix environment order form state (#8449)

Browse Source
This commit is contained in:
Tymoteusz Czech 2024-10-15 11:44:40 +02:00 committed by GitHub
parent e22f6a04ba
commit 258eb36afe
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 19 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/component/environments/EnvironmentTable/OrderEnvironments/OrderEnvironmentsDialog/OrderEnvironmentsDialog.test.tsx
View File

@ -157,7 +157,7 @@ describe('OrderEnvironmentsDialog Component', () => {
expect(onSubmitMock).toHaveBeenCalledTimes(1); expect(onSubmitMock).toHaveBeenCalledTimes(1);
expect(onSubmitMock).toHaveBeenCalledWith([ expect(onSubmitMock).toHaveBeenCalledWith([
{ name: 'Dev', type: 'development' }, { name: 'Dev', type: 'development' },
{ name: 'Prod', type: 'development' }, { name: 'Staging', type: 'development' },
]); ]);
}); });

29
frontend/src/component/environments/EnvironmentTable/OrderEnvironments/OrderEnvironmentsDialog/OrderEnvironmentsDialog.tsx
View File

@ -111,6 +111,22 @@ export const OrderEnvironmentsDialog: FC<OrderEnvironmentsDialogProps> = ({
}); });
}; };
const onTypeChange = (index: number, type: string) => {
setEnvironments(
environments.map((env, i) =>
i === index ? { ...env, type } : { ...env },
),
);
};
const onNameChange = (index: number, name: string) => {
setEnvironments(
environments.map((env, i) =>
i === index ? { ...env, name } : { ...env },
),
);
};
return ( return (
<StyledDialog open={open} title=''> <StyledDialog open={open} title=''>
<FormTemplate <FormTemplate
@ -199,11 +215,7 @@ export const OrderEnvironmentsDialog: FC<OrderEnvironmentsDialogProps> = ({
}), }),
)} )}
onChange={(type) => { onChange={(type) => {
const newEnvironments = [ onTypeChange(i, type);
...environments,
];
newEnvironments[i].type = type;
setEnvironments(newEnvironments);
}} }}
/> />
<TextField <TextField
@ -211,12 +223,7 @@ export const OrderEnvironmentsDialog: FC<OrderEnvironmentsDialogProps> = ({
label={`Environment ${i + 1} Name`} label={`Environment ${i + 1} Name`}
value={environments[i]?.name || ''} value={environments[i]?.name || ''}
onChange={(e) => { onChange={(e) => {
const newEnvironments = [ onNameChange(i, e.target.value);
...environments,
];
newEnvironments[i].name =
e.target.value;
setEnvironments(newEnvironments);
}} }}
error={!!error} error={!!error}
helperText={error} helperText={error}