Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-06-27 01:19:00 +02:00
Code Issues Projects Releases Wiki Activity

fix: namespace flag-repo for unleash sdk (#9910)

Browse Source 
Did two things:

1. Use basePath to prefix the Unleash repo used with the Unleash
Frontend SDK.
2. Use JSON.stringify as key for useEffect to avoid potential render
loop
This commit is contained in:
Ivar Conradi Østhus 2025-05-06 19:05:06 +02:00 committed by GitHub
parent a7118e0c18
commit 28373f5e37
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
frontend/src/component/providers/UnleashFlagProvider/UnleashFlagProvider.tsx
View File

@ -1,7 +1,11 @@
import type React from 'react'; import type React from 'react';
import { type FC, useEffect } from 'react'; import { type FC, useEffect } from 'react';
import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig'; import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig';
import FlagProvider, { UnleashClient } from '@unleash/proxy-client-react'; import FlagProvider, {
LocalStorageProvider,
UnleashClient,
} from '@unleash/proxy-client-react';
import { basePath } from '../../../utils/formatPath';
const UNLEASH_API = 'https://hosted.edge.getunleash.io/api/frontend'; const UNLEASH_API = 'https://hosted.edge.getunleash.io/api/frontend';
const DEV_TOKEN = ''; const DEV_TOKEN = '';
@ -27,6 +31,7 @@ export const UnleashFlagProvider: FC<{ children?: React.ReactNode }> = ({
token = getUnleashFrontendToken(); token = getUnleashFrontendToken();
client = new UnleashClient({ client = new UnleashClient({
storageProvider: new LocalStorageProvider(`${basePath}:unleash`),
url: UNLEASH_API, url: UNLEASH_API,
clientKey: token || 'offline', clientKey: token || 'offline',
appName: 'Unleash Cloud UI', appName: 'Unleash Cloud UI',
@ -45,7 +50,7 @@ export const UnleashFlagProvider: FC<{ children?: React.ReactNode }> = ({
} else { } else {
// nothing // nothing
} }
}, [uiConfig.unleashContext]); }, [JSON.stringify(uiConfig.unleashContext)]);
return ( return (
<FlagProvider unleashClient={client} startClient={false}> <FlagProvider unleashClient={client} startClient={false}>