Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-04 00:18:01 +01:00
Code Issues Projects Releases Wiki Activity

fix: loading is causing a glitch that changes the size of the dialog for a split second (#7062)

Browse Source 
The loading state of the FormTemplate is causing the form glitch. This
fixes it by removing the loading

Closes #
[1-2362](https://linear.app/unleash/issue/1-2362/fix-visual-glitch-when-you-submit-the-form)


https://github.com/Unleash/unleash/assets/104830839/1782ca09-a8b4-4fd1-92c1-111843869b25

Signed-off-by: andreas-unleash <andreas@getunleash.ai>
This commit is contained in:
andreas-unleash 2024-05-16 09:59:56 +03:00 committed by GitHub
parent 793cd76e93
commit 28ca626bac
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/src/component/project/Project/CreateProject/CreateProjectDialog/CreateProjectDialog.tsx
View File

@ -1,4 +1,3 @@
import type React from 'react';
import { formatUnknownError } from 'utils/formatUnknownError'; import { formatUnknownError } from 'utils/formatUnknownError';
import useProjectApi from 'hooks/api/actions/useProjectApi/useProjectApi'; import useProjectApi from 'hooks/api/actions/useProjectApi/useProjectApi';
import useToast from 'hooks/useToast'; import useToast from 'hooks/useToast';
@ -18,7 +17,7 @@ import { Button, Dialog, styled } from '@mui/material';
interface ICreateProjectDialogueProps { interface ICreateProjectDialogueProps {
open: boolean; open: boolean;
onClose: (e: React.SyntheticEvent) => void; onClose: () => void;
} }
const StyledDialog = styled(Dialog)(({ theme, maxWidth }) => ({ const StyledDialog = styled(Dialog)(({ theme, maxWidth }) => ({
@ -40,7 +39,7 @@ export const CreateProjectDialogue = ({
open, open,
onClose, onClose,
}: ICreateProjectDialogueProps) => { }: ICreateProjectDialogueProps) => {
const { createProject, loading } = useProjectApi(); const { createProject } = useProjectApi();
const { refetchUser } = useAuthUser(); const { refetchUser } = useAuthUser();
const { uiConfig } = useUiConfig(); const { uiConfig } = useUiConfig();
const { setToastData, setToastApiError } = useToast(); const { setToastData, setToastApiError } = useToast();
@ -118,7 +117,6 @@ export const CreateProjectDialogue = ({
<StyledDialog open={open} onClose={onClose}> <StyledDialog open={open} onClose={onClose}>
<FormTemplate <FormTemplate
disablePadding disablePadding
loading={loading}
description={documentation} description={documentation}
documentationLink='https://docs.getunleash.io/reference/projects' documentationLink='https://docs.getunleash.io/reference/projects'
documentationLinkLabel='Projects documentation' documentationLinkLabel='Projects documentation'