Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-05 17:53:12 +02:00
Code Issues Projects Releases Wiki Activity

fix: Only show "not enough data" text when there isn't enough data. (#10604)

Browse Source 
The previous implementation had a small bug where it would show "not
enough data" even if the graph was loading. This commit fixes that.

While working, I thought that maybe we should keep the current data
while we're fetching new data instead of adding a cover, but all the
other graphs use a cover when loading, so I've not made any changes to
that effect.
This commit is contained in:
Thomas Heartman 2025-09-03 12:23:36 +02:00 committed by GitHub
parent 5b74299420
commit 295a3abd59
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
frontend/src/component/insights/componentsChart/CreationArchiveChart/CreationArchiveChart.tsx
View File

@ -139,6 +139,7 @@ export const CreationArchiveChart: FC<ICreationArchiveChartProps> = ({
}, [creationVsArchivedChart, theme]); }, [creationVsArchivedChart, theme]);
const useGraphCover = notEnoughData || isLoading; const useGraphCover = notEnoughData || isLoading;
const showNotEnoughDataText = notEnoughData && !isLoading;
const data = useGraphCover ? placeholderData : aggregateOrProjectData; const data = useGraphCover ? placeholderData : aggregateOrProjectData;
const options = useMemo( const options = useMemo(
@ -229,7 +230,7 @@ export const CreationArchiveChart: FC<ICreationArchiveChartProps> = ({
<CreationArchiveRatioTooltip tooltip={tooltip} /> <CreationArchiveRatioTooltip tooltip={tooltip} />
{useGraphCover ? ( {useGraphCover ? (
<GraphCover> <GraphCover>
{notEnoughData ? <NotEnoughData /> : isLoading} {showNotEnoughDataText ? <NotEnoughData /> : isLoading}
</GraphCover> </GraphCover>
) : null} ) : null}
</> </>