Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-24 17:51:14 +02:00
Code Issues Projects Releases Wiki Activity

refactor: remove unused getStageCount function and simplify LifecycleFilters usage

Browse Source
This commit is contained in:
Tymoteusz Czech 2025-09-11 12:43:10 +02:00
parent 92db5a02c3
commit 2a248ec085
No known key found for this signature in database
GPG Key ID: 133555230D88D75F
2 changed files with 12 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
frontend/src/component/common/LifecycleFilters/LifecycleFilters.tsx
View File

@ -64,12 +64,11 @@ export const LifecycleFilters = ({
total, total,
children, children,
countData, countData,
sx,
}: ILifecycleFiltersBaseProps) => { }: ILifecycleFiltersBaseProps) => {
const current = state.lifecycle?.values ?? []; const current = state.lifecycle?.values ?? [];
return ( return (
<Wrapper sx={sx}> <Wrapper>
<StyledContainer> <StyledContainer>
{lifecycleOptions.map(({ label, value }) => { {lifecycleOptions.map(({ label, value }) => {
const isActive = const isActive =

46
frontend/src/component/feature/FeatureToggleList/FeatureToggleFilters/FeatureLifecycleFilters.tsx
View File

@ -1,31 +1,9 @@
import type { FC, ReactNode } from 'react'; import type { FC, ReactNode } from 'react';
import { Box } from '@mui/material';
import type { FilterItemParamHolder } from '../../../filter/Filters/Filters.tsx'; import type { FilterItemParamHolder } from '../../../filter/Filters/Filters.tsx';
import type { LifecycleStage } from '../../FeatureView/FeatureOverview/FeatureLifecycle/LifecycleStage.tsx';
import { useLifecycleCount } from 'hooks/api/getters/useLifecycleCount/useLifecycleCount'; import { useLifecycleCount } from 'hooks/api/getters/useLifecycleCount/useLifecycleCount';
import type { FeatureLifecycleCountSchema } from 'openapi';
import { LifecycleFilters } from '../../../common/LifecycleFilters/LifecycleFilters.tsx'; import { LifecycleFilters } from '../../../common/LifecycleFilters/LifecycleFilters.tsx';
const getStageCount = (
lifecycle: LifecycleStage['name'] | null,
lifecycleCount?: FeatureLifecycleCountSchema,
) => {
if (!lifecycleCount) {
return undefined;
}
if (lifecycle === null) {
return (
(lifecycleCount.initial || 0) +
(lifecycleCount.preLive || 0) +
(lifecycleCount.live || 0) +
(lifecycleCount.completed || 0)
);
}
const key = lifecycle === 'pre-live' ? 'preLive' : lifecycle;
return lifecycleCount[key];
};
interface ILifecycleFiltersProps { interface ILifecycleFiltersProps {
state: FilterItemParamHolder; state: FilterItemParamHolder;
onChange: (value: FilterItemParamHolder) => void; onChange: (value: FilterItemParamHolder) => void;
@ -49,17 +27,15 @@ export const FeatureLifecycleFilters: FC<ILifecycleFiltersProps> = ({
); );
return ( return (
<LifecycleFilters <Box sx={(theme) => ({ padding: theme.spacing(1.5, 3, 0, 3) })}>
state={state} <LifecycleFilters
onChange={onChange} state={state}
total={total} onChange={onChange}
countData={countData} total={total}
sx={{ countData={countData}
padding: (theme) => >
`${theme.spacing(1.5)} ${theme.spacing(3)} 0 ${theme.spacing(3)}`, {children}
}} </LifecycleFilters>
> </Box>
{children}
</LifecycleFilters>
); );
}; };