Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

fix: validate project names on blur (#7668)

Browse Source 
This fix validates the project name when you blur the field in the new
project form. The only instances where it'll be wrong is if you have
just whitespace or an empty string, but you'll be notified immediately.

Also removes some unused variables and parameters that I found.
This commit is contained in:
Thomas Heartman 2024-07-25 14:43:38 +02:00 committed by GitHub
parent dc37503b7d
commit 2c41cbbd3c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/component/project/Project/CreateProject/NewCreateProjectForm/CreateProjectDialog.tsx
View File

@ -128,7 +128,6 @@ export const CreateProjectDialog = ({
const navigate = useNavigate(); const navigate = useNavigate();
const { trackEvent } = usePlausibleTracker(); const { trackEvent } = usePlausibleTracker();
const { const {
projectId,
projectName, projectName,
projectDesc, projectDesc,
projectMode, projectMode,
@ -276,6 +275,7 @@ export const CreateProjectDialog = ({
errors={errors} errors={errors}
icon={StyledProjectIcon} icon={StyledProjectIcon}
onClose={onClose} onClose={onClose}
validateName={validateName}
configButtons={ configButtons={
<> <>
<MultiSelectConfigButton <MultiSelectConfigButton

10
frontend/src/component/project/ProjectList/ProjectList.tsx
View File

@ -86,14 +86,12 @@ function resolveCreateButtonData(
} }
} }
const ProjectCreationButton: FC<{ projectCount: number }> = ({ const ProjectCreationButton: FC = () => {
projectCount,
}) => {
const [searchParams] = useSearchParams(); const [searchParams] = useSearchParams();
const showCreateDialog = Boolean(searchParams.get('create')); const showCreateDialog = Boolean(searchParams.get('create'));
const [openCreateDialog, setOpenCreateDialog] = useState(showCreateDialog); const [openCreateDialog, setOpenCreateDialog] = useState(showCreateDialog);
const { hasAccess } = useContext(AccessContext); const { hasAccess } = useContext(AccessContext);
const { isOss, uiConfig, loading } = useUiConfig(); const { isOss, loading } = useUiConfig();
const createButtonData = resolveCreateButtonData( const createButtonData = resolveCreateButtonData(
isOss(), isOss(),
@ -203,9 +201,7 @@ export const ProjectListNew = () => {
</> </>
} }
/> />
<ProjectCreationButton <ProjectCreationButton />
projectCount={projects.length}
/>
</> </>
} }
> >