diff --git a/src/lib/metrics.test.ts b/src/lib/metrics.test.ts index a4020332bb..4b0e4bbcf4 100644 --- a/src/lib/metrics.test.ts +++ b/src/lib/metrics.test.ts @@ -266,10 +266,10 @@ test('Should collect metrics for client sdk versions', async () => { 'client_sdk_versions', ); expect(metrics).toMatch( - /client_sdk_versions\{sdk_name="unleash-client-node",sdk_version="3\.2\.5"\,platformName=\"not-set\",platformVersion=\"not-set\",yggdrasilVersion=\"not-set\",specVersion=\"not-set\"} 3/, + /client_sdk_versions\{sdk_name="unleash-client-node",sdk_version="3\.2\.5"\,platform_name=\"not-set\",platform_version=\"not-set\",yggdrasil_version=\"not-set\",spec_version=\"not-set\"} 3/, ); expect(metrics).toMatch( - /client_sdk_versions\{sdk_name="unleash-client-java",sdk_version="5\.0\.0"\,platformName=\"not-set\",platformVersion=\"not-set\",yggdrasilVersion=\"not-set\",specVersion=\"not-set\"} 3/, + /client_sdk_versions\{sdk_name="unleash-client-java",sdk_version="5\.0\.0"\,platform_name=\"not-set\",platform_version=\"not-set\",yggdrasil_version=\"not-set\",spec_version=\"not-set\"} 3/, ); eventStore.emit(CLIENT_REGISTER, { sdkName: 'unleash-client-node', @@ -279,7 +279,7 @@ test('Should collect metrics for client sdk versions', async () => { 'client_sdk_versions', ); expect(newmetrics).toMatch( - /client_sdk_versions\{sdk_name="unleash-client-node",sdk_version="3\.2\.5"\,platformName=\"not-set\",platformVersion=\"not-set\",yggdrasilVersion=\"not-set\",specVersion=\"not-set\"} 4/, + /client_sdk_versions\{sdk_name="unleash-client-node",sdk_version="3\.2\.5"\,platform_name=\"not-set\",platform_version=\"not-set\",yggdrasil_version=\"not-set\",spec_version=\"not-set\"} 4/, ); }); diff --git a/src/lib/metrics.ts b/src/lib/metrics.ts index cae55b2624..265ec2fdd8 100644 --- a/src/lib/metrics.ts +++ b/src/lib/metrics.ts @@ -248,10 +248,10 @@ export default class MetricsMonitor { labelNames: [ 'sdk_name', 'sdk_version', - 'platformName', - 'platformVersion', - 'yggdrasilVersion', - 'specVersion', + 'platform_name', + 'platform_version', + 'yggdrasil_version', + 'spec_version', ], }); @@ -801,23 +801,23 @@ export default class MetricsMonitor { clientSdkVersionUsage.increment({ sdk_name: heartbeatEvent.sdkName, sdk_version: heartbeatEvent.sdkVersion, - platformName: + platform_name: heartbeatEvent.metadata?.platformName ?? 'not-set', - platformVersion: + platform_version: heartbeatEvent.metadata?.platformVersion ?? 'not-set', - yggdrasilVersion: + yggdrasil_version: heartbeatEvent.metadata?.yggdrasilVersion ?? 'not-set', - specVersion: + spec_version: heartbeatEvent.metadata?.specVersion ?? 'not-set', }); } else { clientSdkVersionUsage.increment({ sdk_name: heartbeatEvent.sdkName, sdk_version: heartbeatEvent.sdkVersion, - platformName: 'not-set', - platformVersion: 'not-set', - yggdrasilVersion: 'not-set', - specVersion: 'not-set', + platform_name: 'not-set', + platform_version: 'not-set', + yggdrasil_version: 'not-set', + spec_version: 'not-set', }); } });