From 2e43e2cb99a9751c654cf916e31839621590510e Mon Sep 17 00:00:00 2001 From: sjaanus Date: Thu, 26 Jun 2025 09:58:38 +0300 Subject: [PATCH] Make it a wrapper --- src/lib/util/transactionContext.test.ts | 38 +++---------------------- src/lib/util/transactionContext.ts | 9 ++---- 2 files changed, 7 insertions(+), 40 deletions(-) diff --git a/src/lib/util/transactionContext.test.ts b/src/lib/util/transactionContext.test.ts index 433873de24..f2fb78528e 100644 --- a/src/lib/util/transactionContext.test.ts +++ b/src/lib/util/transactionContext.test.ts @@ -1,7 +1,4 @@ -import { - TransactionContext, - type OperationContext, -} from './transactionContext.js'; +import { TransactionContext } from './transactionContext.js'; import { vi } from 'vitest'; describe('TransactionContext', () => { @@ -30,33 +27,6 @@ describe('TransactionContext', () => { expect(txContext.transaction).toBe(mockTransaction); }); - it('should create transaction context with custom operation', () => { - const customOperation: OperationContext = { - type: 'change-request', - id: 42, - }; - - const txContext = new TransactionContext( - mockTransaction, - customOperation, - ); - - expect(txContext.operationContext.type).toBe('change-request'); - expect(txContext.operationContext.id).toBe(42); - expect(txContext.transaction).toBe(mockTransaction); - }); - - it('should create transaction context with partial operation context', () => { - const txContext = new TransactionContext(mockTransaction, { - type: 'change-request', - }); - - expect(txContext.operationContext.type).toBe('change-request'); - expect(txContext.operationContext.id).toBeDefined(); - expect(typeof txContext.operationContext.id).toBe('number'); - expect(txContext.transaction).toBe(mockTransaction); - }); - it('should generate unique IDs for different contexts', () => { const txContext1 = new TransactionContext(mockTransaction); const txContext2 = new TransactionContext(mockTransaction); @@ -68,18 +38,18 @@ describe('TransactionContext', () => { }); describe('operationContext', () => { - it('should allow updating operation context', () => { + it('should allow setting custom operation context', () => { const txContext = new TransactionContext(mockTransaction); expect(txContext.operationContext.type).toBe('transaction'); txContext.operationContext = { type: 'change-request', - id: 123, + id: 42, }; expect(txContext.operationContext.type).toBe('change-request'); - expect(txContext.operationContext.id).toBe(123); + expect(txContext.operationContext.id).toBe(42); }); it('should allow partial updates to operation context', () => { diff --git a/src/lib/util/transactionContext.ts b/src/lib/util/transactionContext.ts index ffbb5b4017..0ee0078156 100644 --- a/src/lib/util/transactionContext.ts +++ b/src/lib/util/transactionContext.ts @@ -15,14 +15,11 @@ export class TransactionContext { public readonly transaction: Knex.Transaction; public operationContext: OperationContext; - constructor( - transaction: Knex.Transaction, - operationContext?: Partial, - ) { + constructor(transaction: Knex.Transaction) { this.transaction = transaction; this.operationContext = { - type: operationContext?.type || 'transaction', - id: operationContext?.id || generateNumericTransactionId(), + type: 'transaction', + id: generateNumericTransactionId(), }; } }